GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/367
More jclouds location unit tests
Following on from @bostko's great changes in
https://github.com/apache/brooklyn-server/pull/366 (to allow us to write more
real unit tests, for JcloudsLocation testing), this PR converts the easiest
tests into real unit tests.
@duncangrant you may well find this helpful for the JcloudsLocation
customizer changes that you are making.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
more-jcloudsLocation-unit-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/367.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #367
----
commit 602df32d20123ce65f977026070e420bf9ffd94e
Author: Aled Sage <aled.s...@gmail.com>
Date: 2016-10-04T15:54:44Z
Extract AbstractJcloudsStubbedUnitTest
Extracted from JcloudsReachableAddressStubbedTest, and makes
StubbedComputeServiceRegistry configurable for whether it should
delegate at all to the cloud provider (or stub everything).
Also updates JcloudsSshMachineLocation, so we only call
computeContext().getContext().utils().injector().getInstance(RunScriptOnNode.Factory)
if we really need to. This change only affects deprecated code paths.
commit 17b5eb89db1a5b8e9c85668099413bdf83e825e3
Author: Aled Sage <aled.s...@gmail.com>
Date: 2016-10-04T15:55:19Z
Convert jclouds live-sanity tests to unit tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
