[GitHub] [incubator-brpc] amosbird commented on a diff in pull request #1762: Check append return code

2022-05-13 Thread GitBox
amosbird commented on code in PR #1762: URL: https://github.com/apache/incubator-brpc/pull/1762#discussion_r872159761 ## src/brpc/policy/baidu_rpc_protocol.cpp: ## @@ -80,11 +80,11 @@ static void SerializeRpcHeaderAndMeta( ::google::protobuf::io::CodedOutputStream

[GitHub] [incubator-brpc] amosbird commented on a diff in pull request #1762: Check append return code

2022-05-13 Thread GitBox
amosbird commented on code in PR #1762: URL: https://github.com/apache/incubator-brpc/pull/1762#discussion_r872108717 ## src/brpc/policy/baidu_rpc_protocol.cpp: ## @@ -80,11 +80,11 @@ static void SerializeRpcHeaderAndMeta( ::google::protobuf::io::CodedOutputStream

[GitHub] [incubator-brpc] amosbird commented on a diff in pull request #1762: Check append return code

2022-05-13 Thread GitBox
amosbird commented on code in PR #1762: URL: https://github.com/apache/incubator-brpc/pull/1762#discussion_r872108717 ## src/brpc/policy/baidu_rpc_protocol.cpp: ## @@ -80,11 +80,11 @@ static void SerializeRpcHeaderAndMeta( ::google::protobuf::io::CodedOutputStream