Re: [GitHub] [incubator-brpc] jamesge commented on a change in pull request #915: add license header for scripts

2019-09-02 Thread Tan,Zhongyi
https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash/21613044 hi, gejun, from this thread, it seems that env bash is more preferred to bash. Please take a look , thanks 在 2019/9/2 下午4:12,“GitBox” 写入: jamesge commented on a change in pull request #915

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #915: add license header for scripts

2019-09-02 Thread GitBox
jamesge commented on a change in pull request #915: add license header for scripts URL: https://github.com/apache/incubator-brpc/pull/915#discussion_r319848436 ## File path: build_in_travis_ci.sh ## @@ -1,3 +1,22 @@ +#!/usr/bin/env sh Review comment: 这些命令未必兼容所有系统,不要加

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #915: add license header for scripts

2019-09-02 Thread GitBox
jamesge commented on a change in pull request #915: add license header for scripts URL: https://github.com/apache/incubator-brpc/pull/915#discussion_r319848436 ## File path: build_in_travis_ci.sh ## @@ -1,3 +1,22 @@ +#!/usr/bin/env sh Review comment: 这些命令未必兼容所有系统,不要加