[GitHub] [incubator-brpc] jamesge commented on a change in pull request #915: add license header for scripts

2019-09-02 Thread GitBox
jamesge commented on a change in pull request #915: add license header for 
scripts
URL: https://github.com/apache/incubator-brpc/pull/915#discussion_r319848436
 
 

 ##
 File path: build_in_travis_ci.sh
 ##
 @@ -1,3 +1,22 @@
+#!/usr/bin/env sh
 
 Review comment:
   这些命令未必兼容所有系统,不要加。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] jamesge commented on a change in pull request #915: add license header for scripts

2019-09-02 Thread GitBox
jamesge commented on a change in pull request #915: add license header for 
scripts
URL: https://github.com/apache/incubator-brpc/pull/915#discussion_r319848436
 
 

 ##
 File path: build_in_travis_ci.sh
 ##
 @@ -1,3 +1,22 @@
+#!/usr/bin/env sh
 
 Review comment:
   这些命令未必兼容所有系统,不要加。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org