[GitHub] [incubator-brpc] libratiger commented on issue #852: bad performance for ParseFromCompressedData
libratiger commented on issue #852: bad performance for ParseFromCompressedData URL: https://github.com/apache/incubator-brpc/issues/852#issuecomment-539301544 > @libratiger > > > 如果自己比较明确数据格式的画，可以尝试streaming rpc，这个里面没有调用Pb的反序列化，brpc会把IOBuf交给用户来处理。 > > 碰到这种场景，一般用http + body是pb更合理一些，brpc中的streaming rpc是解决有序传输和处理问题，grpc层面的streaming目前brpc并不支持。 嗯，我理解streaming rpc的设计不是干这个事的，但是我看如果把IOBuf交给用户来处理的画，应该是会比使用pb更加高效，可以减少反序列化的开销，尤其是用户自己知道格式的情况下。 btw: brpc有对pb, http+body这种的性能对比吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] libratiger commented on issue #852: bad performance for ParseFromCompressedData
libratiger commented on issue #852: bad performance for ParseFromCompressedData URL: https://github.com/apache/incubator-brpc/issues/852#issuecomment-536405150 @hnwyllmm 你有benchmark对比过吗？我觉得两者都快不了，不过从原理上理解，repeated应该是会快一点。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] libratiger commented on issue #852: bad performance for ParseFromCompressedData
libratiger commented on issue #852: bad performance for ParseFromCompressedData URL: https://github.com/apache/incubator-brpc/issues/852#issuecomment-536379966 @gxkevin 你后来有其他的优化吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] libratiger commented on issue #852: bad performance for ParseFromCompressedData
libratiger commented on issue #852: bad performance for ParseFromCompressedData URL: https://github.com/apache/incubator-brpc/issues/852#issuecomment-536377792 我也发现过这种情况，就是序列化和反序列化慢。我看了一下底层，都是调用的pb的反序列化，这个锅应该是pb的问题。 如果自己比较明确数据格式的画，可以尝试streaming rpc，这个里面没有调用Pb的反序列化，brpc会把IOBuf交给用户来处理。 但是brpc的streaming和grpc的差别好像很大，grpc不用改什么借口，但是brpc需要换成```StreamWrite```这些接口。这个文档也没有多说原因，如果能够补上会更好？@jamesge This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
