Re: [PR] Fix bthread_usleep return unexpected error (brpc)

2024-01-22 Thread via GitHub


wwbmmm commented on PR #2511:
URL: https://github.com/apache/brpc/pull/2511#issuecomment-1905243010

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] Fix bthread_usleep return unexpected error (brpc)

2024-01-22 Thread via GitHub


chenBright commented on PR #2511:
URL: https://github.com/apache/brpc/pull/2511#issuecomment-1905191387

   @wwbmmm 有空看看这个问题


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[PR] Fix bthread_usleep return unexpected error (brpc)

2024-01-17 Thread via GitHub


chenBright opened a new pull request, #2511:
URL: https://github.com/apache/brpc/pull/2511

   ### What problem does this PR solve?
   
   Issue Number:
   
   Problem Summary:
   
   #2435 的改动可能会导致bthread_usleep实际上成功执行,但是返回ESTOP失败。
   
   `_add_sleep_event`函数中,定时器添加成功后,`e.meta->current_sleep = 
sleep_id`之前,定时器执行,唤醒了协程。
   
https://github.com/apache/brpc/blob/09141d4d87e2a68736144ebc6dad55eba449c6cc/src/bthread/task_group.cpp#L757-L775
   
   协程被唤醒后,`current_sleep`为0、`interrupted`为false,返回了ESTOP错误。
   
https://github.com/apache/brpc/blob/09141d4d87e2a68736144ebc6dad55eba449c6cc/src/bthread/task_group.cpp#L804-L808
 
   
   ### What is changed and the side effects?
   
   Changed:
   
   使用一个特定的成员变量代替`current_sleep==0`来表示定时器添加失败。
   
   Side effects:
   - Performance effects(性能影响):
   
   - Breaking backward compatibility(向后兼容性): 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related 
tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of 
Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org