Re: Is it safa to include valgrind.h?
Thanks, dave. 在 2019/9/4 上午12:44，“Dave Fisher” 写入: Hi - > On Sep 2, 2019, at 10:59 PM, tan zhongyi wrote: > > Hi, kevin & JB & von, > > We have included one file named as valgrind.h under brpc’s source code. > > https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/LICENSE > https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/valgrind.h > > According to its license statement, valgrind.h is released under BSD style license, > Other part of valgrind is released under GPL v2. > > But we only include valgrind.h and its license file. > > And I also get its original version as > https://github.com/svn2github/valgrind/blob/master/include/valgrind.h You should include this version of the header file. You need to incorporate the BSD license in the overall LICENSE for Doris with a heading pointing to the header file in the Doris source. > > we will include them in our next apache release > So it looks that it is safe for us to include valgrind.h and its License in brpc’s source tarball, > right? Is valgrind a dependency in any way? If so then this is a different issue. Regards, Dave > > Please help us to confirm, thanks > > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: Is it safa to include valgrind.h?
Hi - > On Sep 2, 2019, at 10:59 PM, tan zhongyi wrote: > > Hi, kevin & JB & von, > > We have included one file named as valgrind.h under brpc’s source code. > > https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/LICENSE > https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/valgrind.h > > According to its license statement, valgrind.h is released under BSD style > license, > Other part of valgrind is released under GPL v2. > > But we only include valgrind.h and its license file. > > And I also get its original version as > https://github.com/svn2github/valgrind/blob/master/include/valgrind.h You should include this version of the header file. You need to incorporate the BSD license in the overall LICENSE for Doris with a heading pointing to the header file in the Doris source. > > we will include them in our next apache release > So it looks that it is safe for us to include valgrind.h and its License in > brpc’s source tarball, > right? Is valgrind a dependency in any way? If so then this is a different issue. Regards, Dave > > Please help us to confirm, thanks > > > - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Is it safa to include valgrind.h?
Hi, kevin & JB & von, We have included one file named as valgrind.h under brpc’s source code. https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/LICENSE https://github.com/apache/incubator-brpc/blob/master/src/butil/third_party/valgrind/valgrind.h According to its license statement, valgrind.h is released under BSD style license, Other part of valgrind is released under GPL v2. But we only include valgrind.h and its license file. And I also get its original version as https://github.com/svn2github/valgrind/blob/master/include/valgrind.h we will include them in our next apache release So it looks that it is safe for us to include valgrind.h and its License in brpc’s source tarball, right? Please help us to confirm, thanks
