Re: [PR] span for new bthread (brpc)

2024-02-25 Thread via GitHub


wwbmmm merged PR #2519:
URL: https://github.com/apache/brpc/pull/2519


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-02-08 Thread via GitHub


wwbmmm commented on PR #2519:
URL: https://github.com/apache/brpc/pull/2519#issuecomment-1935250334

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-02-08 Thread via GitHub


wwbmmm commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1483804359


##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
 // Make GOOGLE_LOG print to comlog device
 SetLogHandler();
 
+// Set bthread create span function
+bthread_set_create_span_func(CreateBthreadSpan);

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-02-07 Thread via GitHub


yanglimingcn commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482420118


##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
 // Make GOOGLE_LOG print to comlog device
 SetLogHandler();
 
+// Set bthread create span function
+bthread_set_create_span_func(CreateBthreadSpan);

Review Comment:
   感觉别人也得从rpcz_service查询trace内容比较合理,直接读trace这个leveldb也不太合理。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-02-07 Thread via GitHub


yanglimingcn commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482419094


##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
 // Make GOOGLE_LOG print to comlog device
 SetLogHandler();
 
+// Set bthread create span function
+bthread_set_create_span_func(CreateBthreadSpan);

Review Comment:
   
我这边使用的话,会通过rpcz_service服务把span信息查询出来,上报到我们的trace服务端,这里加了一个type,但是通过rpcz_service查询其实是感知不到bthread这个类型的,它看上去是server
 span的内容。
   其实我本来不想多加一个类型,但是没有这个类型处理上会不合理。
   不太清楚其他人的使用方式,如果依赖了span.proto确实协议变了。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-02-07 Thread via GitHub


wwbmmm commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482380653


##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
 // Make GOOGLE_LOG print to comlog device
 SetLogHandler();
 
+// Set bthread create span function
+bthread_set_create_span_func(CreateBthreadSpan);

Review Comment:
   如果只是使用内置服务查看应该没什么影响
   不过有些用户会自己处理Span数据,做一些分析、上报的工作,如果多了一种SpanType,可能需要特殊处理一下
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-02-07 Thread via GitHub


yanglimingcn commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482210916


##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
 // Make GOOGLE_LOG print to comlog device
 SetLogHandler();
 
+// Set bthread create span function
+bthread_set_create_span_func(CreateBthreadSpan);

Review Comment:
   不是很理解,能举个例子吗?
   这里加了一个bthread span,在展示的时候其实看不到它,看上去像是server span的一部分。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-02-06 Thread via GitHub


wwbmmm commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1481020372


##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
 // Make GOOGLE_LOG print to comlog device
 SetLogHandler();
 
+// Set bthread create span function
+bthread_set_create_span_func(CreateBthreadSpan);

Review Comment:
   这个行为是不是加个开关来控制?否则可能会影响现有的用户



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-02-04 Thread via GitHub


yanglimingcn commented on PR #2519:
URL: https://github.com/apache/brpc/pull/2519#issuecomment-1926075788

   @wwbmmm 这个PR有时间可以review了。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



Re: [PR] span for new bthread (brpc)

2024-01-28 Thread via GitHub


yanglimingcn commented on PR #2519:
URL: https://github.com/apache/brpc/pull/2519#issuecomment-1913831481

   这个是什么地方单测失败了,看不出来呢?显示不出来呢


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org