AW: Another Calcite-related paper accepted for SIGMOD -- "One SQL to Rule Them All"

2019-02-13 Thread Julian Feinauer
Congratulations... Would also like to see a preprint. Von meinem Mobiltelefon gesendet Ursprüngliche Nachricht Betreff: Re: Another Calcite-related paper accepted for SIGMOD -- "One SQL to Rule Them All" Von: Andrei Sereda An: dev@calcite.apache.org Cc: Congratulations. When

[jira] [Created] (CALCITE-2847) Optimize global LOOKAHEAD for SQL parsers

2019-02-13 Thread Hongze Zhang (JIRA)
Hongze Zhang created CALCITE-2847: - Summary: Optimize global LOOKAHEAD for SQL parsers Key: CALCITE-2847 URL: https://issues.apache.org/jira/browse/CALCITE-2847 Project: Calcite Issue Type:

Re: [DISCUSS] Towards Calcite 1.19.0

2019-02-13 Thread Zoltan Haindrich
Hello, In Hive I'm a little bit behind in upgrading to 1.18 and although the upgrade would not cause any correctness issues; but in a sense it's more conservative in doing some simplifications - which could be interpreted as regressions; if we take that into account that even the plan could get

[GitHub] zhztheplayer opened a new pull request #1041: [CALCITE-2847] Optimize global LOOKAHEAD for SQL parsers

2019-02-13 Thread GitBox
zhztheplayer opened a new pull request #1041: [CALCITE-2847] Optimize global LOOKAHEAD for SQL parsers URL: https://github.com/apache/calcite/pull/1041 See JIRA case: https://issues.apache.org/jira/browse/CALCITE-2847

[GitHub] vlsi commented on issue #84: [CALCITE-2845] Avoid duplication of exception messages

2019-02-13 Thread GitBox
vlsi commented on issue #84: [CALCITE-2845] Avoid duplication of exception messages URL: https://github.com/apache/calcite-avatica/pull/84#issuecomment-463223491 @joshelser , @risdenk , this PR passes all the tests, and it makes exceptions more readable. I'm inclined to merge the

Re: [DISCUSS] Towards Calcite 1.19.0

2019-02-13 Thread Hongze Zhang
Thank you very much for managing the release, Kevin. If the community have enough reviewing resource I would hope the fix of CALCITE-2785[1] and CALCITE-2787[2] could be bring to Calcite 1.19.0. Besides I think I can try my best helping review PRs with which I have enough knowledge too.

Re: Global LOOKAHEAD of the SQL parser

2019-02-13 Thread Hongze Zhang
Thank you very much for the quick response, Julian! The parse will be broken if we simply set LOOKAHEAD to 1. There will be a lot of lookahead warning that are newly produced or hidden before (JavaCC does not perform LA check when global LOOKAHEAD is larger than 1[1]), and many test cases

Re: [DISCUSS] Towards Calcite 1.19.0

2019-02-13 Thread Zoltan Haindrich
On 2/13/19 4:24 PM, Julian Hyde wrote: Sorry, there’s been a misunderstanding. Let me clarify. I didn’t say that your patches were too small. Or intend to imply it. When I said “widespread changes for no good reason” - or something like that - I meant changes to the RexNode format due to

[GitHub] vlsi commented on issue #1040: [CALCITE-2842] Computing digest of IN expressions leads to Exceptions

2019-02-13 Thread GitBox
vlsi commented on issue #1040: [CALCITE-2842] Computing digest of IN expressions leads to Exceptions URL: https://github.com/apache/calcite/pull/1040#issuecomment-463260237 LGTM This is an automated message from the Apache

[GitHub] danny0405 commented on issue #1042: Avoid use of new RuntimeException(e) in tests

2019-02-13 Thread GitBox
danny0405 commented on issue #1042: Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042#issuecomment-463511096 @vlsi Should we need add some Checked Exception instead of raw RuntimeException, we can see the overall exception category when

[GitHub] michaelmior commented on issue #1024: [CALCITE-2817] Make CannotPlanException great

2019-02-13 Thread GitBox
michaelmior commented on issue #1024: [CALCITE-2817] Make CannotPlanException great URL: https://github.com/apache/calcite/pull/1024#issuecomment-463478900 Excellent! Thanks @vlsi :) This would have saved me a lot of pain in the past...

Re: [DISCUSS] Move site repositories from svn to gitbox

2019-02-13 Thread Francis Chuang
I have opened a request with INFRA to get the site moved to Gitbox [1]. [1] https://issues.apache.org/jira/browse/INFRA-17846 On 11/02/2019 9:00 pm, Francis Chuang wrote: Hey all, ASF project sites have the ability to use git instead of subversion as their repository for web site content

Calcite-Master - Build # 1021 - Still Failing

2019-02-13 Thread Apache Jenkins Server
The Apache Jenkins build system has built Calcite-Master (build #1021) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/1021/ to view the results.

Re: new RuntimeException(Throwable) vs SneakyThrows

2019-02-13 Thread Enrico Olivelli
Vladimir, Il giorno mer 13 feb 2019 alle ore 21:49 Vladimir Sitnikov ha scritto: > > Hi, > > I've recently discovered that new RuntimeException(Throwable) results in a > duplicated error messages. > In fact Throwable#(Throwable) just calls cause.getMessage() and uses > it as its own message. > >

[GitHub] asfgit merged pull request #1024: [CALCITE-2817] Make CannotPlanException great

2019-02-13 Thread GitBox
asfgit merged pull request #1024: [CALCITE-2817] Make CannotPlanException great URL: https://github.com/apache/calcite/pull/1024 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] vlsi opened a new pull request #1042: Avoid use of new RuntimeException(e) in tests

2019-02-13 Thread GitBox
vlsi opened a new pull request #1042: Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042 `new RuntimeException(e)` adds very little info in tests, and it makes stacktraces harder to read. So it makes sense to just sneaky-throw in those cases,

Re: Global LOOKAHEAD of the SQL parser

2019-02-13 Thread Julian Hyde
The performance improvements are impressive - basically the parser got 10x faster. However, the parser is now more difficult to develop. Is this worth the speedup? Julian > On Feb 13, 2019, at 5:30 AM, Hongze Zhang wrote: > > Thank you very much for the quick response, Julian! > > > The

new RuntimeException(Throwable) vs SneakyThrows

2019-02-13 Thread Vladimir Sitnikov
Hi, I've recently discovered that new RuntimeException(Throwable) results in a duplicated error messages. In fact Throwable#(Throwable) just calls cause.getMessage() and uses it as its own message. This makes exceptions harder to follow since the new RuntimeException(e) is very often used just

Re: new RuntimeException(Throwable) vs SneakyThrows

2019-02-13 Thread Julian Hyde
If we ban } catch (FooException e) { throw new RuntimeException(e); } then there is a real chance that people will instead write } catch (FooException e) { System.out.println(e); } instead. So, let’s give them a good alternative, or just let them continue writing "new

Re: new RuntimeException(Throwable) vs SneakyThrows

2019-02-13 Thread Vladimir Sitnikov
Julian> then there is a real chance that people will instead write Julian> System.out.println(e); Isn't System.out banned already? Of course we would just ban it and that's it. Julian>new RuntimeException(e), which I don’t think is that bad It produces garbage in the exception stacktraces

[GitHub] sukumaar opened a new pull request #1043: Calcite 2552

2019-02-13 Thread GitBox
sukumaar opened a new pull request #1043: Calcite 2552 URL: https://github.com/apache/calcite/pull/1043 Pull request for JIRA https://issues.apache.org/jira/browse/CALCITE-2552 Added: 1.Support for column alias in order by clause for BigQuerySqlDialect and HiveSqlDialect

[GitHub] vlsi commented on issue #1042: Avoid use of new RuntimeException(e) in tests

2019-02-13 Thread GitBox
vlsi commented on issue #1042: Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042#issuecomment-463517152 @danny0405 , lambdas can't have checked exceptions, and we don't really add exception class alone is not very useful either. >can even

Re: [DISCUSS] Towards Calcite 1.19.0

2019-02-13 Thread Julian Hyde
Sorry, there’s been a misunderstanding. Let me clarify. I didn’t say that your patches were too small. Or intend to imply it. When I said “widespread changes for no good reason” - or something like that - I meant changes to the RexNode format due to removing IS TRUE nodes. I like small

[GitHub] vlsi merged pull request #84: [CALCITE-2845] Avoid duplication of exception messages

2019-02-13 Thread GitBox
vlsi merged pull request #84: [CALCITE-2845] Avoid duplication of exception messages URL: https://github.com/apache/calcite-avatica/pull/84 This is an automated message from the Apache Git Service. To respond to the