Re: [ANNOUNCE] New committer: Laurent Goujon

> > On behalf of the PMC I am delighted to announce Laurent Goujon as a new > > Calcite committer. Laurent has been rounding out the product in several > > areas, including support for the standard set of built-in functions, and > > improving JDBC complianc

Re: [VOTE] Separate Avatica into its own repository

+1 On Sun, Mar 26, 2017 at 1:25 PM, James Taylor wrote: > +1 > > On Sun, Mar 26, 2017 at 1:15 PM Julian Hyde wrote: > > > +1 > > > > Thanks for running this vote, Josh. > > > > > On Mar 26, 2017, at 10:05 AM, Josh Elser wrote: > > >

Re: query about avatica odbc

Apache Drill ODBC driver is not based on the Avatica protocol but on the Drill RPC protocol (Drill uses Avatica for the JDBC driver as a framework). The C++ RPC logic is open source ( https://github.com/apache/drill/tree/master/contrib/native/client) but the ODBC adaptation layer is closed source.

Re: [DISCUSS] Towards Avatica 1.12.0

I'll try to wrap up CALCITE-2219 asap. At the same time, I can also help reviewing CALCITE-1884, CALCITE-2322 and CALCITE-2303. On Tue, May 29, 2018 at 12:51 PM, Julian Hyde wrote: > Thanks, that’s a good list. > > I’m glad you listed 1884 and 2303. I will make sure those get in. > > In

Re: [DISCUSS] Towards Avatica 1.12.0

I updated my patch, sorry that it took longer than expected, but I was not expecting checkstyle having issues with lambdas (I will open an issue for checkstyle as it doesn't seem to be as trivial as to update the plugin version) Laurent On Mon, Jun 4, 2018, 09:36 Josh Elser wrote: > Yay!

Re: RelNode#getDescription and memory consumption

> > On Aug 15, 2018, at 1:46 PM, Laurent Goujon wrote: > > > > Hi folks, > > > > I'm looking for some guidance here before opening JIRAs/pull requests. > > > > I'm examining a memory dump during a planning operation and a significant > > amount of m

Re: RelNode#getDescription and memory consumption

UNDED PRECEDING and CURRENT ROW aggs [COUNT()])),$0=$9)" On Wed, Aug 15, 2018 at 2:09 PM Laurent Goujon wrote: > Here's one (partial) example (truncated because it contains potential > sensitive info, and didn't obfuscate or try to reproduce locally with non > sensitive data): &

Re: RelNode#getDescription and memory consumption

Sorry, I should have mentioned the method too: HepPlanner#buildFinalPlan (when running RelOptRulesTest#testWindowInParenthesis()) On Wed, Aug 15, 2018 at 2:36 PM Laurent Goujon wrote: > It looks to happen when building the final plan: the hep planner goes > recursively to each node to rec

RelNode#getDescription and memory consumption

Hi folks, I'm looking for some guidance here before opening JIRAs/pull requests. I'm examining a memory dump during a planning operation and a significant amount of memory are strings used for RelNode digest and description (some strings being around 130kb). In that particular case, the relnode

Re: RelNode#getDescription and memory consumption

hen I run that test I get > > LogicalProject(input=HepRelVertex#10,$0=$9) > > Have you screwed something up? > > > On Aug 15, 2018, at 2:23 PM, Laurent Goujon wrote: > > > > Just ran RelOptRulesTest with a breakpoint in > > AbstractRelNode#computeD

Re: RelNode#getDescription and memory consumption

the comment > > // Substring uses the same underlying array of chars, so saves a bit > // of memory. > > was true until JDK 1.6 but is no longer true. > > Can you log a JIRA case please. > > Julian > > > > > On Aug 15, 2018, at 2:37 PM, Laurent Goujon

Re: Use of CalciteSchema across Calcite

of CalciteSchema that has that policy? I have been asking > for this for a long time. > > If we did what you suggest, and make CalciteSchema (or a base interface of > it) a public API then people will go and create implementations of that > interface that will get broken all the time. &

Re: Use of CalciteSchema across Calcite

On Mon, Apr 9, 2018 at 11:07 PM, Laurent Goujon <laur...@dremio.com> wrote: > That was my understanding, but it seems usage of CalciteSchema is > prevalent outside the scope of the JDBC adapter: > > $ grep -rl import.*CalciteSchema core/src/main/java|grep -v calcite/jdbc > core/src

Use of CalciteSchema across Calcite

Hi, While working on rebasing our code on top of Calcite 1.16, I noticed that a new method was introduced to SqlValidatorCatalogReader: CalciteSchema `SqlValidatorCatalogReader#getRootSchema()` (not recently, it was added for Calcite 1.12) My understanding of CalciteSchema was that this class is

Re: [DISCUSS] Towards Avatica 1.11.0

I just posted a pull request for https://issues.apache.org/jira/browse/CALCITE-2140: this is a small improvement for AvaticaStatement to add compatibility with DataGrip and other tools. It would be a nice to have for 1.11.0 Laurent On Tue, Feb 27, 2018 at 2:44 PM, F21

Re: CALCITE-2458 Use of Kotlin for unit tests

-0 I kind of share Michael's concern that it might be a barrier, and the provided patch doesn't really showcase the announced benefits, and I would be fairly careful when introducing a new language into the project (the patch for example allows compiling production code with kotlin notably). Is

Re: CyclicMetadataException in testPushDownJoinConditionsWithExpandedIsNotDistinctUsingCase

Looks like Jenkins started to timeout with the following change: https://github.com/apache/calcite/commit/73e6d05fa65f16485caca80571d1fe4fda5c7468 . Ruben, Stamatis: any idea? On Wed, May 29, 2019 at 8:22 PM Laurent Goujon wrote: > It looks like Jenkins build with JDK8 now takes more t

Re: CyclicMetadataException in testPushDownJoinConditionsWithExpandedIsNotDistinctUsingCase

e not 100% that will resolve the problem, > getting rid of the statics seems like a good idea and beneficial in any > case. > > On Thu, May 30, 2019 at 12:02 AM Laurent Goujon > wrote: > > > Unfortunately, not locally, so I ended in crude debugging and code > analysi

Re: CyclicMetadataException in testPushDownJoinConditionsWithExpandedIsNotDistinctUsingCase

gt; On Wed, May 29, 2019 at 11:29 PM Laurent Goujon > wrote: > > > Here's the pull request: https://github.com/apache/calcite/pull/1240 > > > > On Wed, May 29, 2019 at 1:58 PM Laurent Goujon > wrote: > > > > > Looks like most {{RelNode#create()}}

Re: CyclicMetadataException in testPushDownJoinConditionsWithExpandedIsNotDistinctUsingCase

I actually did the change from using a static relbuilder to a mix of static (to create the scans) and per test because of concurrency issues :( Maybe the test should only been using a per test-case relbuilder instead, but it would mean that there's some code relying on the static relbuilder (by

Re: CyclicMetadataException in testPushDownJoinConditionsWithExpandedIsNotDistinctUsingCase

Here's the pull request: https://github.com/apache/calcite/pull/1240 On Wed, May 29, 2019 at 1:58 PM Laurent Goujon wrote: > Looks like most {{RelNode#create()}} access the RelOptCluster/RelBuilder > instance from their child, and some then, perform metadata operation, which > wo

Re: CyclicMetadataException in testPushDownJoinConditionsWithExpandedIsNotDistinctUsingCase

Looks like most {{RelNode#create()}} access the RelOptCluster/RelBuilder instance from their child, and some then, perform metadata operation, which would cause CyclicMetadataException for example. I'll create a fixup patch. On Wed, May 29, 2019 at 9:00 AM Laurent Goujon wrote: > I actually

Re: Rejected commits to master

Since it was a simple patch, I used Github UI to push the commit. And now I see that Jenkins is broken by it somehow. On Wed, May 22, 2019 at 2:36 PM Julian Hyde wrote: > That sounds plausible. > > It looks as if the system accepted a commit from Laurent on one repo, > and a commit from me in

Re: How to build and publish non-SNAPSHOT version?

quick followup: I usually encode the sha directly into the suffix for test versions, so tagging into git has not been required until now. On Tue, Apr 28, 2020 at 9:47 AM Laurent Goujon wrote: > Thanks, very useful. Will give it a try. > > On Tue, Apr 28, 2020 at 9:38 AM Julian Hy

How to build and publish non-SNAPSHOT version?

Hi, I'd like to build my own non-SNAPSHOT version of Calcite and publish it in my internal repository but I haven't found a way to do it with gradle. As far as I can tell, there is a release plugin (com.github.vlsi.stage-vote-release) which supports `-Prelease` property, and will remove the

Re: How to build and publish non-SNAPSHOT version?

xxx" > > password = "xxx" > > } > > } > > } > > } > > } > > } > > > > To deploy a release, do this: > > > > ./gradlew -Prelease -PskipSign > publish

Re: Apache calcite / jdbc Oracle

I checked https://docs.oracle.com/javase/7/docs/api/java/sql/Wrapper.html#isWrapperFor(java.lang.Class), and it mentions interface in multiple places, but it doesn't say explicitly that it should throw if the provided argument is not an interface. And I guess Oracle driver chose to enforce this

bug in DelegatingScope?

Hi, I was looking at the validation code and at some point I saw that piece of code in DelegatingScope#fullyQualify: https://github.com/apache/calcite/blob/571731b80a58eb095ebac7123285c375e7afff90/core/src/main/java/org/apache/calcite/sql/validate/DelegatingScope.java#L309 for (; i > 0;

Re: How to build and publish non-SNAPSHOT version?

Worked fine for me (small variation: I didn't put the file in my ~/.gradle directory and instead use the -I option to point to it). Thanks for the help On Tue, Apr 28, 2020 at 10:41 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > > a couple of properties on the commandline to

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

I meant the source distribution here. I guess I didn't realize Calcite source tree has embedded copies of some 3rd party css/js, but since those are not fetched dynamically and are part of the source tree, I think the committed LICENCE file should include those vs altering it at release time. As

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

I'm slightly confused. Are any of MIT dependencies mentioned in LICENSE bundled with the distribution? On Fri, May 22, 2020 at 12:45 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Julian>It does not need to happen before > Julian>the release, but before we announce. > >

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

My intent was not to cause sadness, sorry about that. I should have elaborated a bit more why I don't think Github is that much of an issue: - LICENSE file at the root of the project is the source of truth, not Github mention. It is a nice to have the correct license for Github for sure, but it

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Vote: +1 (binding) - Local Calcite builds (./gradlew clean build && ./gradlew testSlow) on MacOS and JDK8/11/14: OK - tarball content and signature: OK On Fri, May 15, 2020 at 9:02 PM Haisheng Yuan wrote: > Hi all, > > I have created a build for Apache Calcite 1.23.0, release > candidate 1. >

Re: [DISCUSSION] Rename master branch to main

Hi, +1 for me too. On Wed, Aug 12, 2020 at 11:07 AM Josh Elser wrote: > +1 change it. > > On 7/28/20 1:43 PM, Julian Hyde wrote: > > I am in favor of renaming ‘master’ to ‘main’. To most people it doesn’t > make any difference. To some, such as potential members currently outside > the

Re: Tableau dialect specification for Calcite

We will get back to you guys! Laurent On Mon, Sep 20, 2021 at 4:55 PM Julian Hyde wrote: > Looks very promising, and has the .tdd file that I was looking for. Thanks > Jacques. > > That said, there is no LICENSE file. I will file an issue to clarify the > license. > > Julian > > > > > On Sep

[jira] [Created] (CALCITE-1604) Add missing support for system JDBC functions

Laurent Goujon created CALCITE-1604: --- Summary: Add missing support for system JDBC functions Key: CALCITE-1604 URL: https://issues.apache.org/jira/browse/CALCITE-1604 Project: Calcite

[jira] [Created] (CALCITE-1606) Add missing support for datetime JDBC functions

Laurent Goujon created CALCITE-1606: --- Summary: Add missing support for datetime JDBC functions Key: CALCITE-1606 URL: https://issues.apache.org/jira/browse/CALCITE-1606 Project: Calcite

[jira] [Created] (CALCITE-1407) MetaImpl#fieldMetaData(Class) sets wrong ordinal

Laurent Goujon created CALCITE-1407: --- Summary: MetaImpl#fieldMetaData(Class) sets wrong ordinal Key: CALCITE-1407 URL: https://issues.apache.org/jira/browse/CALCITE-1407 Project: Calcite

[jira] [Created] (CALCITE-1410) MetaImpl.MetaColumn doesn't follow JDBC spec

Laurent Goujon created CALCITE-1410: --- Summary: MetaImpl.MetaColumn doesn't follow JDBC spec Key: CALCITE-1410 URL: https://issues.apache.org/jira/browse/CALCITE-1410 Project: Calcite Issue

[jira] [Created] (CALCITE-1433) avatica-server module depends on non-existent avatica test-jar

Laurent Goujon created CALCITE-1433: --- Summary: avatica-server module depends on non-existent avatica test-jar Key: CALCITE-1433 URL: https://issues.apache.org/jira/browse/CALCITE-1433 Project

[jira] [Created] (CALCITE-1557) Add missing support for numerical JDBC functions

Laurent Goujon created CALCITE-1557: --- Summary: Add missing support for numerical JDBC functions Key: CALCITE-1557 URL: https://issues.apache.org/jira/browse/CALCITE-1557 Project: Calcite

[jira] [Created] (CALCITE-2288) Type assertion error when reducing partially constant expression

Laurent Goujon created CALCITE-2288: --- Summary: Type assertion error when reducing partially constant expression Key: CALCITE-2288 URL: https://issues.apache.org/jira/browse/CALCITE-2288 Project

[jira] [Created] (CALCITE-2341) ImmutableBitSetTest fails with JDK11

Laurent Goujon created CALCITE-2341: --- Summary: ImmutableBitSetTest fails with JDK11 Key: CALCITE-2341 URL: https://issues.apache.org/jira/browse/CALCITE-2341 Project: Calcite Issue Type

[jira] [Created] (CALCITE-2340) Invalid cast generated by AvgVarianceConvertlet

Laurent Goujon created CALCITE-2340: --- Summary: Invalid cast generated by AvgVarianceConvertlet Key: CALCITE-2340 URL: https://issues.apache.org/jira/browse/CALCITE-2340 Project: Calcite

[jira] [Created] (CALCITE-2342) use of assert with side-effect in Schemas

Laurent Goujon created CALCITE-2342: --- Summary: use of assert with side-effect in Schemas Key: CALCITE-2342 URL: https://issues.apache.org/jira/browse/CALCITE-2342 Project: Calcite Issue

[jira] [Created] (CALCITE-2344) Wrong constant reduction over windows function

Laurent Goujon created CALCITE-2344: --- Summary: Wrong constant reduction over windows function Key: CALCITE-2344 URL: https://issues.apache.org/jira/browse/CALCITE-2344 Project: Calcite

[jira] [Created] (CALCITE-2343) PushProjector with OVER expression causing infinite loop

Laurent Goujon created CALCITE-2343: --- Summary: PushProjector with OVER expression causing infinite loop Key: CALCITE-2343 URL: https://issues.apache.org/jira/browse/CALCITE-2343 Project: Calcite

[jira] [Created] (CALCITE-2290) Type mismatch during flattening

Laurent Goujon created CALCITE-2290: --- Summary: Type mismatch during flattening Key: CALCITE-2290 URL: https://issues.apache.org/jira/browse/CALCITE-2290 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-2437) FilterMultiJoinMergeRule doesn't combine postFilterCondition

Laurent Goujon created CALCITE-2437: --- Summary: FilterMultiJoinMergeRule doesn't combine postFilterCondition Key: CALCITE-2437 URL: https://issues.apache.org/jira/browse/CALCITE-2437 Project

[jira] [Created] (CALCITE-2471) RelNode description includes all tree when recomputed

Laurent Goujon created CALCITE-2471: --- Summary: RelNode description includes all tree when recomputed Key: CALCITE-2471 URL: https://issues.apache.org/jira/browse/CALCITE-2471 Project: Calcite

[jira] [Created] (CALCITE-2537) Make sure assertions are enabled before calling VolcanoPlanner#validate

Laurent Goujon created CALCITE-2537: --- Summary: Make sure assertions are enabled before calling VolcanoPlanner#validate Key: CALCITE-2537 URL: https://issues.apache.org/jira/browse/CALCITE-2537

[jira] [Created] (CALCITE-2538) Missing RelMetadataQuery invalidation before subset cost improvement propagation

Laurent Goujon created CALCITE-2538: --- Summary: Missing RelMetadataQuery invalidation before subset cost improvement propagation Key: CALCITE-2538 URL: https://issues.apache.org/jira/browse/CALCITE-2538

[jira] [Created] (CALCITE-2219) Avatica Connection/Statement/ResultSet don't throw if resource is closed

Laurent Goujon created CALCITE-2219: --- Summary: Avatica Connection/Statement/ResultSet don't throw if resource is closed Key: CALCITE-2219 URL: https://issues.apache.org/jira/browse/CALCITE-2219

[jira] [Created] (CALCITE-2629) Unnecessary call to CatalogReader#getAllSchemaObjects in CatalogScope

Laurent Goujon created CALCITE-2629: --- Summary: Unnecessary call to CatalogReader#getAllSchemaObjects in CatalogScope Key: CALCITE-2629 URL: https://issues.apache.org/jira/browse/CALCITE-2629

[jira] [Created] (CALCITE-2803) Identify expanded IS NOT DISTINCT FROM expression when pushing project past join

Laurent Goujon created CALCITE-2803: --- Summary: Identify expanded IS NOT DISTINCT FROM expression when pushing project past join Key: CALCITE-2803 URL: https://issues.apache.org/jira/browse/CALCITE-2803

[jira] [Created] (CALCITE-2807) Identify expanded IS NOT DISTINCT FROM expression when pushing down filter past join

Laurent Goujon created CALCITE-2807: --- Summary: Identify expanded IS NOT DISTINCT FROM expression when pushing down filter past join Key: CALCITE-2807 URL: https://issues.apache.org/jira/browse/CALCITE-2807

[jira] [Created] (CALCITE-3062) Do not populate provenanceMap if not used

Laurent Goujon created CALCITE-3062: --- Summary: Do not populate provenanceMap if not used Key: CALCITE-3062 URL: https://issues.apache.org/jira/browse/CALCITE-3062 Project: Calcite Issue

[jira] [Created] (CALCITE-3085) Unused stack field in RelShuttleImpl

Laurent Goujon created CALCITE-3085: --- Summary: Unused stack field in RelShuttleImpl Key: CALCITE-3085 URL: https://issues.apache.org/jira/browse/CALCITE-3085 Project: Calcite Issue Type

[jira] [Created] (CALCITE-3082) NPE in SqlUtil#getSelectListItem

Laurent Goujon created CALCITE-3082: --- Summary: NPE in SqlUtil#getSelectListItem Key: CALCITE-3082 URL: https://issues.apache.org/jira/browse/CALCITE-3082 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-3216) ClassCastException when running window function over union

Laurent Goujon created CALCITE-3216: --- Summary: ClassCastException when running window function over union Key: CALCITE-3216 URL: https://issues.apache.org/jira/browse/CALCITE-3216 Project: Calcite

[jira] [Created] (CALCITE-3965) Excessive time waiting on DiffRepository lock

Laurent Goujon created CALCITE-3965: --- Summary: Excessive time waiting on DiffRepository lock Key: CALCITE-3965 URL: https://issues.apache.org/jira/browse/CALCITE-3965 Project: Calcite

[jira] [Created] (CALCITE-4179) org.apache.calcite.jdbc package polluting core Calcite planning packages

Laurent Goujon created CALCITE-4179: --- Summary: org.apache.calcite.jdbc package polluting core Calcite planning packages Key: CALCITE-4179 URL: https://issues.apache.org/jira/browse/CALCITE-4179

[jira] [Created] (CALCITE-4025) DelegatingScope#fullyQualify may exit too soon when resolving table alias

Laurent Goujon created CALCITE-4025: --- Summary: DelegatingScope#fullyQualify may exit too soon when resolving table alias Key: CALCITE-4025 URL: https://issues.apache.org/jira/browse/CALCITE-4025