Hello,
Yeah, I've also taken a look but it doesn't seemed connected - but after a
while I've started suspecting that my I had too many back noise...
I instead went the other way; and looked at it with a profiler; and it seems to
me that there are parts of an old 2-3 year old logic; which seems
Hello,
I plan to submit a patch to restore earlier performance today - I think I've came up with a plan to make a more complete fix; but that will definetly take more time than a
few days...and of course there is a risk that I'm wrong :)
cheers,
Zoltan
On 07/02/2018 09:13 PM, Volodymyr
Hello,
I would like to kindly ask someone to take a look at CALCITE-2384 - Performance
issue in getPulledUpPredicates.
It adds an internal feature toggle to RexSimplify to disable CALCITE-2247's
enhancements during predicate pullups.
https://issues.apache.org/jira/browse/CALCITE-2384
Hello Andrei!
I've also bumped into this earlier - from a little bit different angle :)
I've found some "back story about it": It works currently like this because a
long time ago there was no other way to do the subquery conversion of IN;
I think now the preferred way would be to have a rule
Hello,
I've found a simplification issue a while ago; written an ignored test for it -
and opened a new jira to have the fix its own ticket:
https://issues.apache.org/jira/browse/CALCITE-2327 - because it was not
connected to the actual ticket.
* I've submitted a patch to disable this
Hello
Could someone please take a look at this small patch?
It enables to unparse statements which contain IN expressions.
https://issues.apache.org/jira/browse/CALCITE-2444
https://github.com/apache/calcite/pull/805
cheers,
Zoltan
fig parameter to disable previous behavior.
>That’s fine, but let’s do it in such a way that the parameter can
>disappear in a (near) future release. I hate config parameters.
>
>Julian
>
>
>> On Jul 3, 2018, at 1:26 AM, Zoltan Haindrich wrote:
>>
>> Hello,
>>
&
Hello,
I think Calcite-2384 will fix the regression; but its waiting on
feedback/approval/etc :)
cheers,
Zoltan
On 9 July 2018 23:11:37 CEST, Josh Elser wrote:
>Based on the comment in the test case, the test has a timeout because
>it
>previously took 15+minutes.
>
>With a timeout of
On 10/19/18 3:27 AM, Albert wrote:
maybe Zoltan could share his feel on that review, and Vladimir could act
correspondingly.
During the review process Vladimir had some good points; I tried to focus on those - and tried to overlook he's style - it kinda worked well to just see the value in
On 10/3/18 2:35 PM, Vladimir Sitnikov wrote:
> mvn install -pl core -DskipTests -Dcheckstyle.skip
org.jetbrains.kotlin:kotlin-maven-plugin:1.2.71:test-compile
What do you mean by "install" here?
"install" here builds the full project with all the plugins, and it includes
regular javac stuff.
On 10/3/18 12:50 PM, Vladimir Sitnikov wrote:
I would like to note that this change have also altered that now all tests
in the core module are now compiled by the kotlin compiler.
What do you mean by that?
If I understand it correctly it works by wrapping around the java compiler
Hello,
I would like to note that this change have also altered that now all tests in
the core module are now compiled by the kotlin compiler.
As I think Calcite is still a java library: I think that it would be better to compile and run the main tests by the supported platform's tools - and
Hello,
Sorry for holding it back...I was busy doing other things...
I've went thru it; and right now I don't see any new issues; I've only noticed
a bug going away :)
cheers,
Zoltan
On 12/18/18 3:21 AM, Julian Hyde wrote:
Zoltan,
Can you give us a status update please?
The release train is
Hello,
I've attached a patch for Hive to run all the tests against the RC - and the
results seemed promising; but a null related query is failing with incorrect
results.
Hello,
I've run the Hive tests and I've found something which might cause problems: in
CALCITE-1413 we were extra cautious to not simplify cases like:
CASE a=0 THEN 0 ELSE 1/a END
and it worked correctly; however: RexProgramBuilder is also executes simplify -
but the protection at that point
or
>make it private?
>
>Julian
>
>
>> On Nov 19, 2018, at 7:57 AM, Zoltan Haindrich (JIRA)
> wrote:
>>
>> Zoltan Haindrich created CALCITE-2685:
>> -
>>
>> Summary: Bridge cases
, at 23:09, Hongze Zhang (JIRA) wrote:
[
https://issues.apache.org/jira/browse/CALCITE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hongze Zhang reassigned CALCITE-2838:
-
Assignee: Hongze Zhang (was: Zoltan Haindrich)
Simp
Hello,
I have run Hive tests - and it looks good.
I right now know about 2 things which might worth mentioning:
* CALCITE-2929 is about an issue which was noticed in Hive recently, namely:
The expression CAST(col as integer) IS NULL is reduced to (col IS NULL) which
might discard errors/etc
On 3/19/19 8:33 AM, Zoltan Haindrich wrote:
* I've been using some jenkins jobs to run calcite tests - and in yesterday's
builds TpchTest started hanging (and timeouted after 10h) even in master branch
builds
I've run all tests locally on my machine - they passed; I right now doubt
I'm happy that this have came up - I think Gradle is much more transparent than Maven in
general; with no "built-in" limitations
My experience with maven is that I'm looking for some plugin which might do something similar what is needed...and depending on "lifecycle/etc" things it might
Hello,
In Hive I'm a little bit behind in upgrading to 1.18 and although the upgrade would not cause any correctness issues; but in a sense it's more conservative in doing some
simplifications - which could be interpreted as regressions; if we take that into account that even the plan could get
to removing IS TRUE nodes.
I like small patches, provided each one fixes a well defined issue and has
appropriate tests.
From now on I will try to provide a testcase when opening the jira.
Sorry for the misunderstanding, thank you for making it clear!
Julian
On Feb 13, 2019, at 3:40 AM, Zoltan
, Zoltan! You’ve already contributed plenty of great work, and I
look forward to further contributions!
Julian
On Jan 30, 2019, at 10:05 AM, Jesus Camacho Rodriguez <
jcama...@apache.org> wrote:
Apache Calcite's Project Management Committee (PMC) has invited Zoltan
Haindrich to become a com
Congratulations Stamatis!
On 4/28/19 4:40 PM, Andrei Sereda wrote:
Congrats, Stamatis.
On Sat, Apr 27, 2019 at 11:08 PM Michael Mior wrote:
Congratulations Stamatis and thanks for all you've done!
--
Michael Mior
mm...@apache.org
Le ven. 26 avr. 2019 à 22:44, Francis Chuang
a écrit :
Congratulations Zhiwei!
On 4/28/19 4:43 PM, Andrei Sereda wrote:
Congrats Zhiwei!
On Sat, Apr 27, 2019 at 11:06 PM Michael Mior wrote:
Welcome Zhiwei and thanks for your contributions!
--
Michael Mior
mm...@apache.org
Le ven. 26 avr. 2019 à 22:37, Francis Chuang
a écrit :
Apache
Congratulations Chunwei!
On 4/28/19 4:43 PM, Andrei Sereda wrote:
Congrats Chunwei!
On Sat, Apr 27, 2019 at 11:06 PM Michael Mior wrote:
Congratulations and welcome Chunwei!
--
Michael Mior
mm...@apache.org
Le ven. 26 avr. 2019 à 22:34, Francis Chuang
a écrit :
Apache Calcite's Project
Hello,
I would like to join the party :)
I was not able to pull Yuzhao and Haisheng-s public key.
pub rsa2048 2017-02-16 [SC]
CA63 B37F 4E9E 5006 4F0E 4A22 5DEF 9167 E76F 84FD
uid [ultimate] Zoltan Haindrich
sub rsa2048 2017-02-16 [E]
cheers,
Zoltan
On 5/2/19 9:27 AM
I think you might try another approach: introduce some UDF and use your
translation logic to call that - as the UDF will be opaque for calcite it will
be left alone.
I guess Calcite might probably won't be able to do much with these ORs anyway...
On 10/3/19 11:26 PM, Haisheng Yuan wrote:
I
m join
conditions does not affect the result of the join.
And the same apply to filter conditions.
I don't know whether removing casts, _ IS TRUE and _ IS NOT FALSE from
conditions genuinely make the world "simpler". But let's try it and
see.
On Mon, Mar 30, 2020 at 8:06 AM Zoltan Haindrich
ink we should strive to eliminate all of
the slightly unhelpful things that Calcite does; those things can add up
and cause major inefficiencies in the planning process and/or sub-optimal
plans.
Julian
On Mar 24, 2020, at 1:47 AM, Zoltan Haindrich wrote:
Hey,
That's a great diagnosis :)
I would gue
Congratulations!
On 4/29/20 7:32 AM, Enrico Olivelli wrote:
Congrats!
Enrico
Il Mer 29 Apr 2020, 04:51 Feng Zhu ha scritto:
Congrations! Yanlin!
best,
Feng
Chunwei Lei 于2020年4月29日周三 上午10:16写道：
Congrats, Yanlin!
Best,
Chunwei
On Wed, Apr 29, 2020 at 10:07 AM Forward Xu
wrote:
Congrats!
On 4/29/20 7:32 AM, Enrico Olivelli wrote:
Congratulations!
Enrico
Il Mer 29 Apr 2020, 04:51 Feng Zhu ha scritto:
Congrations!
best,
Feng
Chunwei Lei 于2020年4月29日周三 上午10:16写道：
Congrats, Jin!
Best,
Chunwei
On Wed, Apr 29, 2020 at 10:07 AM Forward Xu
wrote:
Congrats
Congratulations!
On 4/29/20 7:31 AM, Enrico Olivelli wrote:
Congrats!
Enrico
Il Mer 29 Apr 2020, 04:52 Feng Zhu ha scritto:
Congrations! Forward!
best,
Feng
Chunwei Lei 于2020年4月29日周三 上午10:17写道：
Congrats, Forward!
Best,
Chunwei
On Wed, Apr 29, 2020 at 6:46 AM Rui Wang wrote:
Hey Shuo!
I think that simplification should been made on join conditions - I've done a
quick check; and it seems to be working for me.
I suspected that it will be either a missing call to RexSimplify for some reason - or it is added by a forced return type correction: IIRC there are some cases
in Filter/Calc, may be we can omit the
nullability?
Best Regards,
Shuo
On Tue, Mar 24, 2020 at 3:35 PM Zoltan Haindrich mailto:k...@rxd.hu>> wrote:
Hey Shuo!
I think that simplification should been made on join conditions - I've done
a quick check; and it seems to be
Hey Chunwei!
about CALCITE-4118: I wanted to get back to it - but I was busy doing other
things...
The patch is not ready; it's wip branch is here:
https://github.com/kgyrtkirk/calcite/tree/4118-cast-varbinary
My plan was to figure out how to do it without writing down concreate
types(like
Congartulations Alessandro!
On 12/18/21 4:42 PM, Enrico Olivelli wrote:
Congrats!
Enrico
Il Sab 18 Dic 2021, 16:00 Alessandro Solimando <
alessandro.solima...@gmail.com> ha scritto:
Hello everyone,
it's an honour and privilege to be part of this great community, I have
really learned a lot
Hey,
I think the main problem is still the lack of active committers/reviewers
and not so much the assignment.
Totally agree - I think this is the core of the problem; the assign-by-files
could somewhat help pulling in the right people - but will not make the job
done.
We could opt for
I think there might be an another approach; by making it possible to define
safetiness of an operator - going back to the first example and considering:
SELECT e.name
FROM emp e
INNER JOIN dep d ON e.deptno = d.deptno
WHERE (10 / e.empno) = 1
and the pushed down version:
SELECT e.name
FROM
Hi,
I was wondering about the pros and cons of having a Calcite rule which could
rewrite a join to utilize bloom filters; something like:
select e.*
from emp e
join dept d on(e.deptno=d.deptno);
where d.dname='Sales';
into something like:
select e.*
from (
Zoltan Haindrich created CALCITE-2326:
-
Summary: Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in
RexSimplify
Key: CALCITE-2326
URL: https://issues.apache.org/jira/browse/CALCITE-2326
Project
Zoltan Haindrich created CALCITE-2444:
-
Summary: Rel2Sql: support c IN (1,2)
Key: CALCITE-2444
URL: https://issues.apache.org/jira/browse/CALCITE-2444
Project: Calcite
Issue Type: Bug
Zoltan Haindrich created CALCITE-2445:
-
Summary: RexSimplify x=x
Key: CALCITE-2445
URL: https://issues.apache.org/jira/browse/CALCITE-2445
Project: Calcite
Issue Type: Improvement
Zoltan Haindrich created CALCITE-2401:
-
Summary: Improve RelMdPredicates performance
Key: CALCITE-2401
URL: https://issues.apache.org/jira/browse/CALCITE-2401
Project: Calcite
Issue Type
Zoltan Haindrich created CALCITE-2240:
-
Summary: Predicate push into CASE statment doesn't happen in some
cases
Key: CALCITE-2240
URL: https://issues.apache.org/jira/browse/CALCITE-2240
Project
Zoltan Haindrich created CALCITE-2631:
-
Summary: Address small issues in case simplification
Key: CALCITE-2631
URL: https://issues.apache.org/jira/browse/CALCITE-2631
Project: Calcite
Zoltan Haindrich created CALCITE-2632:
-
Summary: Add hashCode and equals implementations to RexNode
Key: CALCITE-2632
URL: https://issues.apache.org/jira/browse/CALCITE-2632
Project: Calcite
Zoltan Haindrich created CALCITE-2652:
-
Summary: Fix Rel2Sql conversion in case the join condition
contains a boolean column reference
Key: CALCITE-2652
URL: https://issues.apache.org/jira/browse/CALCITE-2652
Zoltan Haindrich created CALCITE-2675:
-
Summary: ReduceExpressionRule may leave behind altered types w.r.t
nullability
Key: CALCITE-2675
URL: https://issues.apache.org/jira/browse/CALCITE-2675
Zoltan Haindrich created CALCITE-2611:
-
Summary: Code generation fails if one side of an or contains
unknown
Key: CALCITE-2611
URL: https://issues.apache.org/jira/browse/CALCITE-2611
Project
Zoltan Haindrich created CALCITE-2606:
-
Summary: Return type inference for and/or may identify result type
incorrectly
Key: CALCITE-2606
URL: https://issues.apache.org/jira/browse/CALCITE-2606
Zoltan Haindrich created CALCITE-2731:
-
Summary: Case statements are simplified with unsafe conditions
Key: CALCITE-2731
URL: https://issues.apache.org/jira/browse/CALCITE-2731
Project: Calcite
Zoltan Haindrich created CALCITE-2695:
-
Summary: Simplify casts which are only widening nullability
Key: CALCITE-2695
URL: https://issues.apache.org/jira/browse/CALCITE-2695
Project: Calcite
Zoltan Haindrich created CALCITE-2687:
-
Summary: Is distinct from could lead to Exceptions in
ReduceExpressionRule
Key: CALCITE-2687
URL: https://issues.apache.org/jira/browse/CALCITE-2687
Zoltan Haindrich created CALCITE-2685:
-
Summary: Bridge cases in which Calcite's type resolution is more
stricter than Hive.
Key: CALCITE-2685
URL: https://issues.apache.org/jira/browse/CALCITE-2685
Zoltan Haindrich created CALCITE-2688:
-
Summary: Improve diagnosability when return type could not be
inferred.
Key: CALCITE-2688
URL: https://issues.apache.org/jira/browse/CALCITE-2688
Project
Zoltan Haindrich created CALCITE-2886:
-
Summary: Simplification of AND expressions should push negations
earlier
Key: CALCITE-2886
URL: https://issues.apache.org/jira/browse/CALCITE-2886
Project
Zoltan Haindrich created CALCITE-2929:
-
Summary: Simplification of IS NULL checks are incorrectly assuming
that CAST-s are possible
Key: CALCITE-2929
URL: https://issues.apache.org/jira/browse/CALCITE-2929
Zoltan Haindrich created CALCITE-2840:
-
Summary: Simplification may use narrower UnknownAs modes during
AND/OR simplification
Key: CALCITE-2840
URL: https://issues.apache.org/jira/browse/CALCITE-2840
Zoltan Haindrich created CALCITE-2842:
-
Summary: Computing digest of IN expressions leads to Exceptions
Key: CALCITE-2842
URL: https://issues.apache.org/jira/browse/CALCITE-2842
Project: Calcite
Zoltan Haindrich created CALCITE-2841:
-
Summary: Simplification: push negation into Case expression
Key: CALCITE-2841
URL: https://issues.apache.org/jira/browse/CALCITE-2841
Project: Calcite
Zoltan Haindrich created CALCITE-2838:
-
Summary: Simplification: Remove redundant IS TRUE checks
Key: CALCITE-2838
URL: https://issues.apache.org/jira/browse/CALCITE-2838
Project: Calcite
Zoltan Haindrich created CALCITE-2839:
-
Summary: Simplify x = true to x and x = false to not x
Key: CALCITE-2839
URL: https://issues.apache.org/jira/browse/CALCITE-2839
Project: Calcite
Zoltan Haindrich created CALCITE-2851:
-
Summary: Simplification: track visited nodes in paranoid mode
Key: CALCITE-2851
URL: https://issues.apache.org/jira/browse/CALCITE-2851
Project: Calcite
Zoltan Haindrich created CALCITE-2848:
-
Summary: Simplifying a case statement's first branch should
disregard its safety
Key: CALCITE-2848
URL: https://issues.apache.org/jira/browse/CALCITE-2848
Zoltan Haindrich created CALCITE-2802:
-
Summary: Druid adapter: Usage of range conditions like "2010-01-01
< timestamp" leads to incorrect results
Key: CALCITE-2802
URL: https://issues.apache.or
Zoltan Haindrich created CALCITE-3215:
-
Summary: Simplification may not fully simplify IsNotNull
expressions
Key: CALCITE-3215
URL: https://issues.apache.org/jira/browse/CALCITE-3215
Project
Zoltan Haindrich created CALCITE-3887:
-
Summary: Filter and Join conditions may not need to retain
nullability during simplifications
Key: CALCITE-3887
URL: https://issues.apache.org/jira/browse/CALCITE-3887
Zoltan Haindrich created CALCITE-4006:
-
Summary: Add ordered-set aggregate functions
Key: CALCITE-4006
URL: https://issues.apache.org/jira/browse/CALCITE-4006
Project: Calcite
Issue Type
Zoltan Haindrich created CALCITE-6020:
-
Summary: SqlToRelConverter should not replace windowed SUM with
equivalent expression using SUM0
Key: CALCITE-6020
URL: https://issues.apache.org/jira/browse/CALCITE
Zoltan Haindrich created CALCITE-5953:
-
Summary: AggregateCaseToFilterRule may make inaccurate SUM
transformation
Key: CALCITE-5953
URL: https://issues.apache.org/jira/browse/CALCITE-5953
Project
71 matches
Mail list logo
