[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread F21
Github user F21 commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 Thanks for the heads up, I'll make sure to include the `v` in the tag for the next release. As the fix is not super urgent, I'll wait for a few more commits before starting a vote for a

[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread kenshaw
Github user kenshaw commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 I actually don't need this merged any time soon. I've already fixed the dependency issues in vgo. Also, please note that you might want to consider tagging releases as `vX.X.X`

[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread F21
Github user F21 commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 @kenshaw Thanks! I'll merge it when the test turns green. As the project is now part of the Apache Foundation, I will need to start a vote on the mailing list in order to tag a release. How

[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread kenshaw
Github user kenshaw commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 @F21 done. ---

[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread F21
Github user F21 commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 @kenshaw Can you use `(` instead of `[`? Sorry for being picky, but these are the standards being set by Apache Calcite. ---

[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread kenshaw
Github user kenshaw commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 @F21 updated. ---

[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread F21
Github user F21 commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 @kenshaw, thanks that looks great! As you're not a committer of Apache Calcite, can you please include your name in parenthesis at the end of the commit message? ---

[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread kenshaw
Github user kenshaw commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 Updated, see: https://issues.apache.org/jira/browse/CALCITE-2367 ---

[GitHub] calcite-avatica-go issue #24: Change UUID package to github.com/hashicorp/go...

2018-06-15 Thread F21
Github user F21 commented on the issue: https://github.com/apache/calcite-avatica-go/pull/24 @kenshaw Thanks, this is a good idea! As this project is now part of the Apache Calcite project and the change is not trivial, can you please do the following: - Open an issue in JIRA and