[GitHub] vlsi commented on issue #1040: [CALCITE-2842] Computing digest of IN expressions leads to Exceptions

2019-02-13 Thread GitBox 
vlsi commented on issue #1040: [CALCITE-2842] Computing digest of IN 
expressions leads to Exceptions
URL: https://github.com/apache/calcite/pull/1040#issuecomment-463260237
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vlsi commented on issue #1040: [CALCITE-2842] Computing digest of IN expressions leads to Exceptions

2019-02-12 Thread GitBox 
vlsi commented on issue #1040: [CALCITE-2842] Computing digest of IN 
expressions leads to Exceptions
URL: https://github.com/apache/calcite/pull/1040#issuecomment-462869415
 
 
   @kgyrtkirk , this looks good to me, however would you please add `&& 
operandsSize == 2` check to 
https://github.com/apache/calcite/blob/883666929478aabe07ee5b9e572c43a6f1a703e2/core/src/main/java/org/apache/calcite/rex/RexCall.java#L114
 ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services