Re: Avatica maven

2018-05-29 Thread Kevin Risden
I was able to reproduce this and it looks like the root cause:

https://issues.apache.org/jira/browse/MNG-6300

Maven 3.5.3 fixes this. Maven 3.5.1 and 3.5.2 look to be the only versions
that have the offending Maven commit
(be223808939d75152d7157db33d45f230114555e) but no fix. Maven 3.5.0 works as
well.

Doesn't look like there is anything we can do to work around this from what
I can tell.

Kevin Risden

On Tue, May 29, 2018 at 5:19 PM, Julian Hyde  wrote:

> The symptoms look very much like this: https://github.com/travis-ci/
> travis-ci/issues/8499  >.
>
> If so, maven versions before 3.5.0 (e.g. 3.3.9) should be OK.
>
> Julian
>
>
> > On May 29, 2018, at 2:46 PM, Kevin Risden  wrote:
> >
> > Are they fixed in Maven proper or are we relying on a default Maven
> plugin
> > version that is failing?
> >
> > Maven 3.5.3 was released early in March. Seems weird to require such a
> > recent version.
> >
> > I can try to take a look tonight to see if I can reproduce.
> >
> > Kevin Risden
> >
> > On Tue, May 29, 2018, 16:43 Michael Mior  wrote:
> >
> >> Sounds like a good idea to me. Unfortunately, Ubuntu 18.04 (the current
> LTS
> >> release) is currently on Maven 3.5.2. Not much we can do about that
> though.
> >>
> >> --
> >> Michael Mior
> >> mm...@uwaterloo.ca
> >>
> >>
> >> Le mar. 29 mai 2018 à 17:24, Julian Hyde  a écrit :
> >>
> >>> I’ve run into problems building Avatica using maven-3.5.2 that are
> fixed
> >>> using maven-3.5.3. When executing “mvn clean install javadoc:javadoc
> >> site”
> >>> (on Ubuntu, on virtually any JDK version), I get
> >>>
> >>>  [ERROR] Failed to execute goal
> >>> org.apache.maven.plugins:maven-shade-plugin:2.1:shade (default) on
> >> project
> >>> avatica-standalone-server: Error creating shaded jar:
> >>> /home/jhyde/regress/calcite-avatica/server/target/classes (Is a
> >> directory)
> >>> -> [Help 1]
> >>>
> >>> The currently recommended version is "3.2.1 or later” [1]. Any
> objections
> >>> if I change the recommended version to "3.5.3 or later”?
> >>>
> >>>
> >>> Julian
> >>>
> >>> [1] http://calcite.apache.org/avatica/develop/avatica.html <
> >>> http://calcite.apache.org/avatica/develop/avatica.html>
> >>
>
>


Re: Avatica maven

2018-05-29 Thread Julian Hyde
The symptoms look very much like this: 
https://github.com/travis-ci/travis-ci/issues/8499 
.

If so, maven versions before 3.5.0 (e.g. 3.3.9) should be OK.

Julian


> On May 29, 2018, at 2:46 PM, Kevin Risden  wrote:
> 
> Are they fixed in Maven proper or are we relying on a default Maven plugin
> version that is failing?
> 
> Maven 3.5.3 was released early in March. Seems weird to require such a
> recent version.
> 
> I can try to take a look tonight to see if I can reproduce.
> 
> Kevin Risden
> 
> On Tue, May 29, 2018, 16:43 Michael Mior  wrote:
> 
>> Sounds like a good idea to me. Unfortunately, Ubuntu 18.04 (the current LTS
>> release) is currently on Maven 3.5.2. Not much we can do about that though.
>> 
>> --
>> Michael Mior
>> mm...@uwaterloo.ca
>> 
>> 
>> Le mar. 29 mai 2018 à 17:24, Julian Hyde  a écrit :
>> 
>>> I’ve run into problems building Avatica using maven-3.5.2 that are fixed
>>> using maven-3.5.3. When executing “mvn clean install javadoc:javadoc
>> site”
>>> (on Ubuntu, on virtually any JDK version), I get
>>> 
>>>  [ERROR] Failed to execute goal
>>> org.apache.maven.plugins:maven-shade-plugin:2.1:shade (default) on
>> project
>>> avatica-standalone-server: Error creating shaded jar:
>>> /home/jhyde/regress/calcite-avatica/server/target/classes (Is a
>> directory)
>>> -> [Help 1]
>>> 
>>> The currently recommended version is "3.2.1 or later” [1]. Any objections
>>> if I change the recommended version to "3.5.3 or later”?
>>> 
>>> 
>>> Julian
>>> 
>>> [1] http://calcite.apache.org/avatica/develop/avatica.html <
>>> http://calcite.apache.org/avatica/develop/avatica.html>
>> 



Re: Avatica maven

2018-05-29 Thread Kevin Risden
Are they fixed in Maven proper or are we relying on a default Maven plugin
version that is failing?

Maven 3.5.3 was released early in March. Seems weird to require such a
recent version.

I can try to take a look tonight to see if I can reproduce.

Kevin Risden

On Tue, May 29, 2018, 16:43 Michael Mior  wrote:

> Sounds like a good idea to me. Unfortunately, Ubuntu 18.04 (the current LTS
> release) is currently on Maven 3.5.2. Not much we can do about that though.
>
> --
> Michael Mior
> mm...@uwaterloo.ca
>
>
> Le mar. 29 mai 2018 à 17:24, Julian Hyde  a écrit :
>
> > I’ve run into problems building Avatica using maven-3.5.2 that are fixed
> > using maven-3.5.3. When executing “mvn clean install javadoc:javadoc
> site”
> > (on Ubuntu, on virtually any JDK version), I get
> >
> >   [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-shade-plugin:2.1:shade (default) on
> project
> > avatica-standalone-server: Error creating shaded jar:
> > /home/jhyde/regress/calcite-avatica/server/target/classes (Is a
> directory)
> > -> [Help 1]
> >
> > The currently recommended version is "3.2.1 or later” [1]. Any objections
> > if I change the recommended version to "3.5.3 or later”?
> >
> >
> > Julian
> >
> > [1] http://calcite.apache.org/avatica/develop/avatica.html <
> > http://calcite.apache.org/avatica/develop/avatica.html>
>


Re: Avatica maven

2018-05-29 Thread Michael Mior
Sounds like a good idea to me. Unfortunately, Ubuntu 18.04 (the current LTS
release) is currently on Maven 3.5.2. Not much we can do about that though.

--
Michael Mior
mm...@uwaterloo.ca


Le mar. 29 mai 2018 à 17:24, Julian Hyde  a écrit :

> I’ve run into problems building Avatica using maven-3.5.2 that are fixed
> using maven-3.5.3. When executing “mvn clean install javadoc:javadoc site”
> (on Ubuntu, on virtually any JDK version), I get
>
>   [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.1:shade (default) on project
> avatica-standalone-server: Error creating shaded jar:
> /home/jhyde/regress/calcite-avatica/server/target/classes (Is a directory)
> -> [Help 1]
>
> The currently recommended version is "3.2.1 or later” [1]. Any objections
> if I change the recommended version to "3.5.3 or later”?
>
>
> Julian
>
> [1] http://calcite.apache.org/avatica/develop/avatica.html <
> http://calcite.apache.org/avatica/develop/avatica.html>