Re: Use of noDag parameter in HepPlanner

2019-02-17 Thread Stamatis Zampetakis
Thanks for the additional info Vitalii! It made me also realize that I had a typo in my previous email. I meant to write that I tried setting *noDag=false* (since I wanted to enable DAGs) everywhere but I had failures in various places. Setting *noDag=true* globally will not work and most likely

Re: Use of noDag parameter in HepPlanner

2019-02-17 Thread Vitalii Diravka
Stamatis, Just FYI, maybe it will be useful for you, Drill uses *noDAG: true *as default value for HepPlanner [1]. After changing it to false, a lot of Drill unit tests failed [2]. [1]

Re: Use of noDag parameter in HepPlanner

2019-02-15 Thread Stamatis Zampetakis
FYI, what I concluded by going through the code and the various test cases is the following. By allowing DAGs the planner can detect common sub expressions in queries and re-use an existing result without re-applying a rule if that is not necessary. This should lead to fewer object creations and

Re: Use of noDag parameter in HepPlanner

2019-02-12 Thread Julian Hyde
I don’t recall. Could you review the tests and see whether tests tend to use noDag=true or false most of the time? Are there any tests that use the less popular value, and if so, is there a particular reason that those tests use that option? Julian > On Feb 12, 2019, at 6:47 AM, Stamatis