[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #225: Rename substitutions class names
lburgazzoli commented on a change in pull request #225: Rename substitutions
class names
URL: https://github.com/apache/camel-quarkus/pull/225#discussion_r331072870
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/graal/SubstituteIntrospectionSupport.java
##
@@ -21,14 +21,17 @@
import com.oracle.svm.core.annotate.Alias;
import com.oracle.svm.core.annotate.RecomputeFieldValue;
import com.oracle.svm.core.annotate.TargetClass;
+import com.oracle.svm.core.annotate.TargetElement;
import org.apache.camel.spi.BeanIntrospection;
import org.apache.camel.support.LRUCacheFactory;
+//
+// Don't use class here to avoid warning triggered by IntrospectionSupport
deprecation
+//
@TargetClass(className = "org.apache.camel.support.IntrospectionSupport")
-final class Target_org_apache_camel_support_IntrospectionSupport {
-
+final class SubstituteIntrospectionSupport {
@Alias
+@TargetElement(name = "CACHE")
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.FromAlias)
-private static Map, BeanIntrospection.ClassInfo> CACHE =
LRUCacheFactory.newLRUWeakCache(256);
-
+private static Map, BeanIntrospection.ClassInfo> cache =
LRUCacheFactory.newLRUWeakCache(256);
Review comment:
Yes, everything adds a little bit of noise, if you feel the check-style
comment is better, feel free to change it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #225: Rename substitutions class names
lburgazzoli commented on a change in pull request #225: Rename substitutions
class names
URL: https://github.com/apache/camel-quarkus/pull/225#discussion_r331051866
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/graal/SubstituteIntrospectionSupport.java
##
@@ -21,14 +21,17 @@
import com.oracle.svm.core.annotate.Alias;
import com.oracle.svm.core.annotate.RecomputeFieldValue;
import com.oracle.svm.core.annotate.TargetClass;
+import com.oracle.svm.core.annotate.TargetElement;
import org.apache.camel.spi.BeanIntrospection;
import org.apache.camel.support.LRUCacheFactory;
+//
+// Don't use class here to avoid warning triggered by IntrospectionSupport
deprecation
+//
@TargetClass(className = "org.apache.camel.support.IntrospectionSupport")
-final class Target_org_apache_camel_support_IntrospectionSupport {
-
+final class SubstituteIntrospectionSupport {
@Alias
+@TargetElement(name = "CACHE")
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.FromAlias)
-private static Map, BeanIntrospection.ClassInfo> CACHE =
LRUCacheFactory.newLRUWeakCache(256);
-
+private static Map, BeanIntrospection.ClassInfo> cache =
LRUCacheFactory.newLRUWeakCache(256);
Review comment:
Yes, one of the reason for the renaming was to be able to run checkstyle
against substitutions but then `final` does not make much sense for substrate
and uppercase makes checkstyle unhappy so this is a compromise.
As alternative I can explicit ignore that class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
