Re: Where to add Spring Boot integration tests?

2019-09-12 Thread Andrea Cosentino
Probably we can also think about adding a module in the tests folder, but
for the naming it will be hard.

Il giorno gio 12 set 2019 alle ore 13:03 Tadayoshi Sato <
sato.tadayo...@gmail.com> ha scritto:

> Thanks Andrea for your comments.
>
> On Thu, Sep 12, 2019 at 7:26 PM Andrea Cosentino 
> wrote:
>
> > I don't think it's a good idea to create something with issues in the
> > folder name.
> >
>
> Yes, it was just a bad example for further better ideas ;-)
>
>
> >
> > If this is an integration tests specific to camel-servlet, you can create
> > an integration test in the component starter folder.
> >
>
> Ideally this isn't specific to any single starter; it is rather based on a
> real use case, which may grow into cross-component integration tests. But
> practically this time it seems to only need camel-log & camel-rest other
> than camel-servlet, so it appears that I can put it in
> camel-servlet-starter.
>
> If things grow otherwise and I cannot put it in a single starter project
> I'll consider other options.
>
> Thank you!
>
>
> >
> > Il giorno gio 12 set 2019 alle ore 12:21 Tadayoshi Sato <
> > sato.tadayo...@gmail.com> ha scritto:
> >
> > > Hi folks,
> > >
> > > I'd like to add an integration test for camel-servlet that can run only
> > on
> > > Spring Boot. Initially I thought to add it to
> > > tests/camel-itest-spring-boot, but this is rather for systematic
> > > compatibility checks for camel components with Spring Boot, not where a
> > > real cross-component regression test is placed.
> > >
> > > Where should I put such Spring Boot integration tests in Camel project?
> > Is
> > > it good idea to create another sub-project under tests/?  If so what do
> > you
> > > think is the best name for the project?  I cannot think of a good name
> > for
> > > such a project..., e.g. tests/camel-itest-spring-boot-issues?
> > >
> > > Best regards,
> > > Tadayoshi
> > >
> >
>


Re: Where to add Spring Boot integration tests?

2019-09-12 Thread Tadayoshi Sato
Thanks Andrea for your comments.

On Thu, Sep 12, 2019 at 7:26 PM Andrea Cosentino  wrote:

> I don't think it's a good idea to create something with issues in the
> folder name.
>

Yes, it was just a bad example for further better ideas ;-)


>
> If this is an integration tests specific to camel-servlet, you can create
> an integration test in the component starter folder.
>

Ideally this isn't specific to any single starter; it is rather based on a
real use case, which may grow into cross-component integration tests. But
practically this time it seems to only need camel-log & camel-rest other
than camel-servlet, so it appears that I can put it in
camel-servlet-starter.

If things grow otherwise and I cannot put it in a single starter project
I'll consider other options.

Thank you!


>
> Il giorno gio 12 set 2019 alle ore 12:21 Tadayoshi Sato <
> sato.tadayo...@gmail.com> ha scritto:
>
> > Hi folks,
> >
> > I'd like to add an integration test for camel-servlet that can run only
> on
> > Spring Boot. Initially I thought to add it to
> > tests/camel-itest-spring-boot, but this is rather for systematic
> > compatibility checks for camel components with Spring Boot, not where a
> > real cross-component regression test is placed.
> >
> > Where should I put such Spring Boot integration tests in Camel project?
> Is
> > it good idea to create another sub-project under tests/?  If so what do
> you
> > think is the best name for the project?  I cannot think of a good name
> for
> > such a project..., e.g. tests/camel-itest-spring-boot-issues?
> >
> > Best regards,
> > Tadayoshi
> >
>


Re: Where to add Spring Boot integration tests?

2019-09-12 Thread Andrea Cosentino
I don't think it's a good idea to create something with issues in the
folder name.

If this is an integration tests specific to camel-servlet, you can create
an integration test in the component starter folder.

Il giorno gio 12 set 2019 alle ore 12:21 Tadayoshi Sato <
sato.tadayo...@gmail.com> ha scritto:

> Hi folks,
>
> I'd like to add an integration test for camel-servlet that can run only on
> Spring Boot. Initially I thought to add it to
> tests/camel-itest-spring-boot, but this is rather for systematic
> compatibility checks for camel components with Spring Boot, not where a
> real cross-component regression test is placed.
>
> Where should I put such Spring Boot integration tests in Camel project?  Is
> it good idea to create another sub-project under tests/?  If so what do you
> think is the best name for the project?  I cannot think of a good name for
> such a project..., e.g. tests/camel-itest-spring-boot-issues?
>
> Best regards,
> Tadayoshi
>