[GitHub] incubator-carbondata pull request #237: [CARBONDATA-317] - CSV having only s...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #237: [CARBONDATA-317] - CSV having only s...
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/237#discussion_r83584249
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/csv/CarbonCsvRelation.scala
---
@@ -148,6 +150,10 @@ case class CarbonCsvRelation protected[spark] (
.withSkipHeaderRecord(false)
CSVParser.parse(firstLine,
csvFormat).getRecords.get(0).asScala.toArray
}
+ if(null == firstRow) {
+throw new DataLoadingException("Please check your input path and
make sure " +
--- End diff --
"Give a message First line cannot be empty", irrespective of header
present or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #237: [CARBONDATA-317] - CSV having only s...
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/237#discussion_r83549178
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/csv/CarbonCsvRelation.scala
---
@@ -148,6 +150,10 @@ case class CarbonCsvRelation protected[spark] (
.withSkipHeaderRecord(false)
CSVParser.parse(firstLine,
csvFormat).getRecords.get(0).asScala.toArray
}
+ if(null == firstRow) {
+throw new DataLoadingException("Please check your input path and
make sure " +
--- End diff --
May be csv file does not have header and user is passing the header from
load command in that case is this a valid message??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #237: [CARBONDATA-317] - CSV having only s...
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/incubator-carbondata/pull/237 [CARBONDATA-317] - CSV having only space char is throwing NullPointer⦠Problem: Data loading fails if csv is having only empty chars Analysis: During data load, in global dictionary generation step while reading the first line for the headers its getting null value from the LineCsvReader. Solution : Added null check over first row and throwing exception asking to provide valid csv. "Please check your input path and make sure csv file contains valid header." Impact area: Data load with csv having only space char in first line. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata having_only_space_char Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/237.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
