Re: CASSANDRA-14482

2019-03-01 Thread Jonathan Haddad
I plan on doing some more thorough testing, it’s just a matter of finding time. On Fri, Mar 1, 2019 at 7:17 PM Dinesh Joshi wrote: > Thanks for testing this out Jon. Apart from the compression ratio could > you also test the insertion rate and GC? 14482 allows you to use full range > of Zstd

Re: CASSANDRA-14482

2019-03-01 Thread Dinesh Joshi
Thanks for testing this out Jon. Apart from the compression ratio could you also test the insertion rate and GC? 14482 allows you to use full range of Zstd compression levels. Dinesh > On Mar 1, 2019, at 6:41 PM, Jonathan Haddad wrote: > > Hey all, > > I finally got around to doing some

Re: CASSANDRA-14482

2019-03-01 Thread Jonathan Haddad
Hey all, I finally got around to doing some testing. Nothing too crazy, I had it run on my laptop while I did other things around the house. Test 1: Inserting Random Data in a K/V table, 10 million inserts LZ4 compression rate: 0.909857609644112 ZStd: 0.6136099401596449 Test 2: Inserting

Re: CASSANDRA-14482

2019-02-17 Thread dinesh.jo...@yahoo.com.INVALID
Thanks all for your input. The consensus is to go forward with this ticket. Dinesh On Friday, February 15, 2019, 12:54:20 PM PST, Sumanth Pasupuleti wrote: +1 On Fri, Feb 15, 2019 at 12:14 PM Dikang Gu wrote: > +1 > > On Fri, Feb 15, 2019 at 10:27 AM Vinay Chella > wrote: > > > We

Re: CASSANDRA-14482

2019-02-15 Thread Sumanth Pasupuleti
+1 On Fri, Feb 15, 2019 at 12:14 PM Dikang Gu wrote: > +1 > > On Fri, Feb 15, 2019 at 10:27 AM Vinay Chella > wrote: > > > We have been using Zstd compressor across different products/services > here > > and have seen significant improvements, getting this in 4.0 would be a > big > > win. > >

Re: CASSANDRA-14482

2019-02-15 Thread Dikang Gu
+1 On Fri, Feb 15, 2019 at 10:27 AM Vinay Chella wrote: > We have been using Zstd compressor across different products/services here > and have seen significant improvements, getting this in 4.0 would be a big > win. > > +1 > > Thanks, > Vinay Chella > > > On Fri, Feb 15, 2019 at 10:19 AM Jeff

Re: CASSANDRA-14482

2019-02-15 Thread Vinay Chella
We have been using Zstd compressor across different products/services here and have seen significant improvements, getting this in 4.0 would be a big win. +1 Thanks, Vinay Chella On Fri, Feb 15, 2019 at 10:19 AM Jeff Jirsa wrote: > +1 > > -- > Jeff Jirsa > > > > On Feb 15, 2019, at 9:35 AM,

Re: CASSANDRA-14482

2019-02-15 Thread Jeff Jirsa
+1 -- Jeff Jirsa > On Feb 15, 2019, at 9:35 AM, Jonathan Ellis wrote: > > IMO "add a new compression class that has demonstrable benefits to Sushma > and Joseph" is sufficiently noninvasive that we should allow it into 4.0. > > On Fri, Feb 15, 2019 at 10:48 AM Dinesh Joshi > wrote: > >>

Re: CASSANDRA-14482

2019-02-15 Thread dinesh.jo...@yahoo.com.INVALID
Thanks Ariel & Jonathan. Michael, I have addressed the comments in the issue so we're using the latest jar now. I've posted the updated patch in the latest comment of the ticket. In addition there is a JMH performance benchmark in the C* repo (CompressorPerformance) that tests various

Re: CASSANDRA-14482

2019-02-15 Thread Jonathan Haddad
Seems low risk, potentially high reward. I can run some tests next week to get a rough idea of how compression ratios differ as well as if there's a difference in performance. I won't be testing correctness, just looking at the performance profile. Jon On Fri, Feb 15, 2019 at 9:56 AM Michael

Re: CASSANDRA-14482

2019-02-15 Thread Michael Shuler
+0.5 I skimmed the jira and github diff and a few things came to mind: - There are multiple comments about using an older jar than the latest version. - I did not see any performance test results to form an opinion on any gains/caveats as a user. This was the first thing I looked for. - I did not

Re: CASSANDRA-14482

2019-02-15 Thread Ariel Weisberg
Hi, I am +1 since it's an additional compressor and not the default. Ariel On Fri, Feb 15, 2019, at 11:41 AM, Dinesh Joshi wrote: > Hey folks, > > Just wanted to get a pulse on whether we can proceed with ZStd support. > The consensus on the ticket was that it’s a very valuable addition >

Re: CASSANDRA-14482

2019-02-15 Thread Jonathan Ellis
IMO "add a new compression class that has demonstrable benefits to Sushma and Joseph" is sufficiently noninvasive that we should allow it into 4.0. On Fri, Feb 15, 2019 at 10:48 AM Dinesh Joshi wrote: > Hey folks, > > Just wanted to get a pulse on whether we can proceed with ZStd support. > The