Re: findbugs

2012-07-30 Thread Jonathan Ellis
I don't think there is much value in integrating it into the build process, since there is a fairly high rate of false positives. Intermittently running it manually could be valuable, and we have done this in the past. On Mon, Jul 30, 2012 at 9:32 AM, Radim Kolar h...@filez.com wrote: was any

Re: findbugs

2012-07-30 Thread Edward Capriolo
I am sure no one would have an issue with an optional findbugs target. On Mon, Jul 30, 2012 at 10:32 AM, Radim Kolar h...@filez.com wrote: was any decision about findbugs made? you do not consider code style recommended by findbugs as good practice which should be followed? I can submit few

Re: findbugs

2012-07-30 Thread Jonathan Ellis
Is Jenkins smart enough to be able to say, I know we had X findbugs warnings previously, which are known to be false positives, but now there are X+1 ? On Mon, Jul 30, 2012 at 9:47 AM, Edward Capriolo edlinuxg...@gmail.com wrote: I am sure no one would have an issue with an optional findbugs

Re: findbugs

2012-07-30 Thread Brandon Williams
On Mon, Jul 30, 2012 at 9:52 AM, Jonathan Ellis jbel...@gmail.com wrote: Is Jenkins smart enough to be able to say, I know we had X findbugs warnings previously, which are known to be false positives, but now there are X+1 ? In my experience, jenkins hasn't even been smart enough to build

Re: findbugs

2012-07-30 Thread Zoltan Farkas
Findbugs can be customized with a exclude filter to exclude from checking issues that produce a high number of false positives. For the rest of false positives @suppresswarnings annotation can be used. I suggest Understanding the issue Findbugs highlights before suppressing it, I did see devs

Re: findbugs

2012-07-30 Thread Radim Kolar
i am using maven to build cassandra. i didnt have in mind to contribute build system because you are not interested in maven. In maven you just call findbugs plugin, nothing special to contribute. I had in mind patch fixing various FB discovered problems. but because its difficult to post it

Re: findbugs

2012-07-30 Thread Radim Kolar
Dne 30.7.2012 16:52, Jonathan Ellis napsal(a): Is Jenkins smart enough to be able to say, I know we had X findbugs warnings previously, which are known to be false positives, but now there are X+1 ? yes. Look at hadoop project pre-commit check builds.

Build failed in Jenkins: Cassandra-quick #994

2012-07-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/Cassandra-quick/994/changes Changes: [sylvain] Add support for row key composite [brandonwilliams] enable jamm for OpenJDK = 1.6.0.23 -- Started by an SCM change Building remotely on ubuntu2 in workspace

Build failed in Jenkins: Cassandra #1826

2012-07-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/Cassandra/1826/ -- Started by an SCM change Building remotely on ubuntu4 in workspace https://builds.apache.org/job/Cassandra/ws/ Checkout:Cassandra / https://builds.apache.org/job/Cassandra/ws/ -

Build failed in Jenkins: Cassandra #1827

2012-07-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/Cassandra/1827/changes Changes: [sylvain] Add support for row key composite [brandonwilliams] enable jamm for OpenJDK = 1.6.0.23 [xedin] improve DynamicEndpointSnitch by using reservoir sampling -- Started by an SCM

Build failed in Jenkins: Cassandra-quick #995

2012-07-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/Cassandra-quick/995/ -- Started by an SCM change Started by an SCM change Building remotely on ubuntu4 in workspace https://builds.apache.org/job/Cassandra-quick/ws/ Checkout:Cassandra-quick /

Build failed in Jenkins: Cassandra-quick #996

2012-07-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/Cassandra-quick/996/changes Changes: [xedin] improve DynamicEndpointSnitch by using reservoir sampling [jbellis] fix build [jbellis] clean up SequentialWriter and friends -- [...truncated 597 lines...] [junit] Tests

Build failed in Jenkins: Cassandra #1828

2012-07-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/Cassandra/1828/ -- Started by an SCM change Building remotely on ubuntu4 in workspace https://builds.apache.org/job/Cassandra/ws/ Checkout:Cassandra / https://builds.apache.org/job/Cassandra/ws/ -

Caching Saving Question

2012-07-30 Thread Zhu Han
We have a CF on which both key cache and row cache are enabled. We found the key cache is saved to disk periodically per configuration, while row cache was not saved at all in the last two month. Both the log and ondisk mtime verified the result. Is it the expected behavior? The node runs

Build failed in Jenkins: Cassandra-quick #997

2012-07-30 Thread Apache Jenkins Server
See https://builds.apache.org/job/Cassandra-quick/997/changes Changes: [brandonwilliams] FIx cqlsh COPY FROM without explicit column names. [jbellis] handle ApplicationState.SCHEMA not present [brandonwilliams] enable jamm for OpenJDK = 1.6.0.23 [sylvain] Update news, version and licenses for