Re: [proposal] Introduce AssertJ in test framework

+1 On Tue, Mar 10, 2020 at 6:18 PM Jon Haddad wrote: > I've used assertj in a lot of projects, I prefer it by a wide margin over > using only junit. > > On Tue, Mar 10, 2020 at 9:45 AM David Capwell wrote: > > > +1 from me > > > > In CASSANDRA-15564 I build my own assert chain to make the

Re: [Discuss] num_tokens default in Cassandra 4.0

> I propose we drop it to 16 immediately. I'll add the production docs > in CASSANDRA-15618 with notes on token count, the reasons why you'd want 1, > 4, or 16. As a follow up, if we can get a token simulation written we can > try all sorts of topologies with whatever token algorithms we

[proposal] Introduce AssertJ in test framework

I would like to propose adding AssertJ as a test dependency and therefore have it available for writing unit/distributed/any test assertions. In addition to the examples mentioned on the AssertJ docs page (allows to do elaborate and comprehensible assertions on

Re: [proposal] Introduce AssertJ in test framework

+1 from me In CASSANDRA-15564 I build my own assert chain to make the tests cleaner; did it since assertj wasn't there. On Tue, Mar 10, 2020, 9:28 AM Kevin Gallardo wrote: > I would like to propose adding AssertJ as > a test dependency and therefore have it

Re: [proposal] Introduce AssertJ in test framework

I've used assertj in a lot of projects, I prefer it by a wide margin over using only junit. On Tue, Mar 10, 2020 at 9:45 AM David Capwell wrote: > +1 from me > > In CASSANDRA-15564 I build my own assert chain to make the tests cleaner; > did it since assertj wasn't there. > > On Tue, Mar 10,

Re: [proposal] Introduce AssertJ in test framework

If it encourages more and higher quality test writing +1 (nb). Also, low risk given it’s a test dep. Using QuickTheories as an example, merging it with a new or updated test could be a good way to get it merged Jordan On Tue, Mar 10, 2020 at 10:33 AM Benjamin Lerer wrote: > +1 > > On Tue,

Re: [proposal] Introduce AssertJ in test framework

Definitely +1 Coding in Java every day, I can't write test without assertJ. Once you get to know assertJ, it's impossible to go back to basic assertions of JUnit that feels really boilerplate On Tue, Mar 10, 2020 at 8:53 PM Jordan West wrote: > If it encourages more and higher quality test

Re: [proposal] Introduce AssertJ in test framework

Strong +1 here. Many of you know I'm a C# / LINQ junkie though. ;) On Tue, Mar 10, 2020 at 3:55 PM DuyHai Doan wrote: > Definitely +1 > > Coding in Java every day, I can't write test without assertJ. Once you get > to know assertJ, it's impossible to go back to basic assertions of JUnit > that