[DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-20 Thread Branimir Lambov
Proposal for a mechanism for plugging in memtable implementations: https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-11%3A+Pluggable+memtable+implementations The proposal supports using custom memtable implementations to support development and testing of improved alternatives, but also

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-20 Thread bened...@apache.org
+1. I haven’t looked in detail at the API that’s been proposed, but I’m very much in favour of the work to support this, and the introduction of the newly proposed implementations. In particular, really happy to see somebody finally finish up C-7282! I look forward to seeing how the different

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-20 Thread Joshua McKenzie
+1 to the idea. In general, I think we need to make up our mind as to whether we consider the Memtable and CommitLog one logical entity (As stated in the CEP: "Conceptually these two pieces of the storage engine form one component — the LSM buffer of Cassandra, and as such it makes a lot of sense

Re: [DISCUSS] CEP-10: Cluster and Code Simulations

2021-07-20 Thread Jeremiah D Jordan
+1 from me for the proposal ignoring the "where it goes". I think the refactors proposed in it make sense no matter what, and the simulation ability should provide some very much needed testability improvements. In particular replacing File with Path is something we have been looking to do

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-20 Thread Nate McCall
Yay for pluggable memtables!! I havent gone over this in detail yet, but personally I've always thought integrating something like Arrow would be cool for sharing data (that's as far as i've gotten, but anything that makes that kind of experimentation easier would also help with mocking test

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-20 Thread bened...@apache.org
I think it would be a mistake to combine the Memtable with CommitLog; several systems use CommitLog-like functionality, and in the medium term I think these would benefit from a unified system, that Memtables may opt to register with. It might make sense to give the Memtable the choice over

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-20 Thread Jeremiah D Jordan
+1 from me. I like the direction many of these proposals are going to clean up/add internal interfaces along with the new features proposed. -Jeremiah > On Jul 20, 2021, at 1:27 PM, bened...@apache.org wrote: > > I think it would be a mistake to combine the Memtable with CommitLog; several >

Re: [DISCUSS] CEP-11: Pluggable memtable implementations

2021-07-20 Thread Berenguer Blasi
+1. De-tangling, going more modular and clean interfaces sgtm. On 20/7/21 21:45, Nate McCall wrote: > Yay for pluggable memtables!! I havent gone over this in detail yet, but > personally I've always thought integrating something like Arrow would be > cool for sharing data (that's as far as i've