Re: Inclusive/exclusive endpoints when compacting token ranges

2022-08-08 Thread Berenguer Blasi
+1 to new flags also from me On 26/7/22 18:39, Andrés de la Peña wrote: I think that's right, using a closed range makes sense to consume the data provided by "sstablemetadata", which also provides closed ranges. Especially because with half-open ranges we couldn't compact a sstable with a

dtests to reproduce the schema disagreement

2022-08-08 Thread Cheng Wang via dev
Hello, I am working on improving the schema disagreement issue. I need some dtests which can reproduce the schema disagreement. Anyone know if there are any existing tests for that? Or something similar? Thanks Cheng

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Brandon Williams
If you simply do a lot of schema changes quickly without waiting for agreement, that should get you there. Kind Regards, Brandon On Mon, Aug 8, 2022 at 5:08 PM Cheng Wang via dev wrote: > > Hello, > > I am working on improving the schema disagreement issue. I need some dtests > which can

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Cheng Wang via dev
Jeff, The issue I was trying to address is when there are two CREATE TABLE queries running on two coordinator nodes concurrently, it might end up with 2 schema versions and they would never get resolved automatically because table id is random TimeUUID. On Mon, Aug 8, 2022 at 3:54 PM Jeff

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Cheng Wang via dev
Thank you for the reply, Brandon! It is helpful! I was thinking of creating a cluster with 2 nodes and having two concurrent CREATE TABLE statements running. But the test will be flaky as there is no guarantee that the query runs before the schema agreement has been reached. Any ideas for that?

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Jeff Jirsa
Which (of the many) schema disagreement issue(s)? On Mon, Aug 8, 2022 at 3:29 PM Cheng Wang via dev wrote: > Thank you for the reply, Brandon! It is helpful! > > I was thinking of creating a cluster with 2 nodes and having two > concurrent CREATE TABLE statements running. But the test will be

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Jeff Jirsa
I see. Then yes, make a cluster with at least 2 hosts, run the CREATE TABLE on them at the same time. If you use the pause injection framework, you can probably pause threads after the CFID is generated but before it's broadcast. If you make the CFID deterministic, you can avoid the race, but can

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Cheng Wang via dev
Hi Jeff, Thank you for your reply! Yes, we are working on generating a deterministic CFID at table creation time. We will also most likely block the pattern of drop and create to avoid the data reassurance issue once we identify all the potential risks with the deterministic id. That's why I