Re: Guidelines for test coverage

2016-09-22 Thread sankalp kohli
Hi Nate, Good we have these guidelines. I have seen several parts of the code which were added without any tests over the years. We should at the minimum make it mandatory to add tests specially when adding major features to the code base. Thanks, Sankalp On Wed, Sep 21, 2016 at 3:27

Re: Guidelines for test coverage

2016-09-21 Thread Dave Lester
A related question: I noticed that dtest is not part of the Apache project: https://github.com/riptano/cassandra-dtest. Are there plans to contribute this to the ASF? Dave > On Sep 21, 2016, at 3:17 PM, Nate McCall wrote: > > We have these already written down in from both the reviewing and

Re: Guidelines for test coverage

2016-09-21 Thread Nate McCall
We have these already written down in from both the reviewing and development perspective: http://cassandra.apache.org/doc/latest/development/how_to_review.html http://cassandra.apache.org/doc/latest/development/testing.html My takeaway from recent in-person discussions the other week about this t

Guidelines for test coverage

2016-09-19 Thread sankalp kohli
Hi, I wanted to know if there are any guidelines for contributors to give out unit and integration tests along with the patches. If not, we should discuss and have them in place. I know we are making good progress with test coverage but we should add guidelines around adding unit and integrati