Re: [DISCUSS] Remove deprecated CQL functions dateof and unixtimestampof on 5.0

2023-03-14 Thread Andrés de la Peña
I have created https://issues.apache.org/jira/browse/CASSANDRA-18328 for
removing the deprecated functions, as part of CASSANDRA-18306
<https://issues.apache.org/jira/browse/CASSANDRA-18306> epic.

On Mon, 13 Mar 2023 at 12:28, Miklosovic, Stefan <
[email protected]> wrote:

> Actually, this one https://issues.apache.org/jira/browse/CASSANDRA-18306
>
> 
> From: Miklosovic, Stefan 
> Sent: Monday, March 13, 2023 13:26
> To: [email protected]
> Subject: Re: [DISCUSS] Remove deprecated CQL functions dateof and
> unixtimestampof on 5.0
>
> NetApp Security WARNING: This is an external email. Do not click links or
> open attachments unless you recognize the sender and know the content is
> safe.
>
>
>
>
> I am +1.
>
> Could you please link the ticket to
> https://issues.apache.org/jira/browse/CASSANDRA-17973 ?
>
> Thanks
>
> 
> From: Andrés de la Peña 
> Sent: Monday, March 13, 2023 13:22
> To: [email protected]
> Subject: [DISCUSS] Remove deprecated CQL functions dateof and
> unixtimestampof on 5.0
>
> NetApp Security WARNING: This is an external email. Do not click links or
> open attachments unless you recognize the sender and know the content is
> safe.
>
>
>
> The CQL functions "dateof" and "unixtimestampof" were deprecated on
> Cassandra 2.2.0, almost eight years ago [1]. They were deprecated in favour
> of the then new "totimestamp" and "tounixtimestamp" functions.
>
> I think that we can finally remove those functions in 5.0, since they have
> been deprecated for so long.
>
> A note about their deprecation was added to NEWS.txt [2], and they were
> marked as deprecated on CQL.textile [3]. They are also listed as deprecated
> on the new doc [4].
>
> I came to this while working on the adoption of snake case conventions for
> CQL function names on CASSANDRA-18037. It probably doesn't make sense to
> add new "date_of" and "unix_timestamp_of" aliases for them.
>
> What do you think? Should we remove them?
>
> [1]
> https://github.com/apache/cassandra/commit/c08aaabd95d4872593c29807de6ec1485cefa7fa
> [2] https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L1421-L1423
> [3]
> https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#time-conversion-functions
> [4]
> https://github.com/apache/cassandra/blob/trunk/doc/modules/cassandra/pages/cql/functions.adoc#time-conversion-functions
>


Re: [DISCUSS] Remove deprecated CQL functions dateof and unixtimestampof on 5.0

2023-03-13 Thread Miklosovic, Stefan
Actually, this one https://issues.apache.org/jira/browse/CASSANDRA-18306


From: Miklosovic, Stefan 
Sent: Monday, March 13, 2023 13:26
To: [email protected]
Subject: Re: [DISCUSS] Remove deprecated CQL functions dateof and 
unixtimestampof on 5.0

NetApp Security WARNING: This is an external email. Do not click links or open 
attachments unless you recognize the sender and know the content is safe.




I am +1.

Could you please link the ticket to 
https://issues.apache.org/jira/browse/CASSANDRA-17973 ?

Thanks


From: Andrés de la Peña 
Sent: Monday, March 13, 2023 13:22
To: [email protected]
Subject: [DISCUSS] Remove deprecated CQL functions dateof and unixtimestampof 
on 5.0

NetApp Security WARNING: This is an external email. Do not click links or open 
attachments unless you recognize the sender and know the content is safe.



The CQL functions "dateof" and "unixtimestampof" were deprecated on Cassandra 
2.2.0, almost eight years ago [1]. They were deprecated in favour of the then 
new "totimestamp" and "tounixtimestamp" functions.

I think that we can finally remove those functions in 5.0, since they have been 
deprecated for so long.

A note about their deprecation was added to NEWS.txt [2], and they were marked 
as deprecated on CQL.textile [3]. They are also listed as deprecated on the new 
doc [4].

I came to this while working on the adoption of snake case conventions for CQL 
function names on CASSANDRA-18037. It probably doesn't make sense to add new 
"date_of" and "unix_timestamp_of" aliases for them.

What do you think? Should we remove them?

[1] 
https://github.com/apache/cassandra/commit/c08aaabd95d4872593c29807de6ec1485cefa7fa
[2] https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L1421-L1423
[3] 
https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#time-conversion-functions
[4] 
https://github.com/apache/cassandra/blob/trunk/doc/modules/cassandra/pages/cql/functions.adoc#time-conversion-functions


Re: [DISCUSS] Remove deprecated CQL functions dateof and unixtimestampof on 5.0

2023-03-13 Thread Miklosovic, Stefan
I am +1.

Could you please link the ticket to 
https://issues.apache.org/jira/browse/CASSANDRA-17973 ?

Thanks


From: Andrés de la Peña 
Sent: Monday, March 13, 2023 13:22
To: [email protected]
Subject: [DISCUSS] Remove deprecated CQL functions dateof and unixtimestampof 
on 5.0

NetApp Security WARNING: This is an external email. Do not click links or open 
attachments unless you recognize the sender and know the content is safe.



The CQL functions "dateof" and "unixtimestampof" were deprecated on Cassandra 
2.2.0, almost eight years ago [1]. They were deprecated in favour of the then 
new "totimestamp" and "tounixtimestamp" functions.

I think that we can finally remove those functions in 5.0, since they have been 
deprecated for so long.

A note about their deprecation was added to NEWS.txt [2], and they were marked 
as deprecated on CQL.textile [3]. They are also listed as deprecated on the new 
doc [4].

I came to this while working on the adoption of snake case conventions for CQL 
function names on CASSANDRA-18037. It probably doesn't make sense to add new 
"date_of" and "unix_timestamp_of" aliases for them.

What do you think? Should we remove them?

[1] 
https://github.com/apache/cassandra/commit/c08aaabd95d4872593c29807de6ec1485cefa7fa
[2] https://github.com/apache/cassandra/blob/trunk/NEWS.txt#L1421-L1423
[3] 
https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile#time-conversion-functions
[4] 
https://github.com/apache/cassandra/blob/trunk/doc/modules/cassandra/pages/cql/functions.adoc#time-conversion-functions