Re: Cleanup after yourselves please

2016-10-18 Thread Josh McKenzie
> > tests hastily and messly commented out line by line (*whyy?*) Couldn't we use /* */ comments instead of every single line one by one? When Jake and I were mass porting unit tests for 8099, I know I used idea's shortcut (ctrl + /) to block comment out things that wouldn't compile while

Re: Cleanup after yourselves please

2016-10-18 Thread Michael Kjellman
Cool, as I would have assumed they would need to be. Given they were initially commented out on 6/30/15 maybe cleanup and removal of that dead code is still at least warranted. On Oct 18, 2016, at 9:15 AM, Oleksandr Petrov > wrote:

Re: Cleanup after yourselves please

2016-10-18 Thread Oleksandr Petrov
It makes sense to make them work for backwards compatibility. There was no announcement that if you migrated to 3.x they wouldn't work, so everyone would most likely expect a clear upgrade path. it's not bringing them back from the dead, but rather helping people who want to upgrade to have this

Re: Cleanup after yourselves please

2016-10-18 Thread Michael Kjellman
Gotcha, I didn't know we were actually bringing them back from the dead! That being said, won't the unit tests need to be re-writtten (or at least refactored) after your work? Couldn't we use /* */ comments instead of every single line one by one? Given we use source control couldn't we remove

Re: Cleanup after yourselves please

2016-10-18 Thread Oleksandr Petrov
I'm currently working on actually making Super Columns work in CQL context. Currently they do not really work[1]. It's not a very small piece of work. It was in the pipeline for some time, although there most likely were more important things that had to be worked on. I understand your