Re: Guidelines for test coverage
Hi Nate, Good we have these guidelines. I have seen several parts of the code which were added without any tests over the years. We should at the minimum make it mandatory to add tests specially when adding major features to the code base. Thanks, Sankalp On Wed, Sep 21, 2016 at 3:27 PM, Dave Lester wrote: > A related question: > > I noticed that dtest is not part of the Apache project: > https://github.com/riptano/cassandra-dtest. Are there plans to contribute > this to the ASF? > > Dave > > > On Sep 21, 2016, at 3:17 PM, Nate McCall wrote: > > > > We have these already written down in from both the reviewing and > > development perspective: > > http://cassandra.apache.org/doc/latest/development/how_to_review.html > > http://cassandra.apache.org/doc/latest/development/testing.html > > > > My takeaway from recent in-person discussions the other week about this > > topic, is that it's really just a matter of making this less of a > > chore/sharing the burden of reviews when the whole dtest suite has to be > > run. > > > > Thanks for bringing this up, though. > > > > On Tue, Sep 20, 2016 at 6:42 AM, sankalp kohli > > wrote: > > > >> Hi, > >>I wanted to know if there are any guidelines for contributors to give > >> out unit and integration tests along with the patches. If not, we should > >> discuss and have them in place. > >> > >> I know we are making good progress with test coverage but we should add > >> guidelines around adding unit and integration tests with every patch. > >> Thoughts on this? > >> > >> Thanks, > >> Sankalp > >> > > > > > > > > -- > > - > > Nate McCall > > Wellington, NZ > > @zznate > > > > CTO > > Apache Cassandra Consulting > > http://www.thelastpickle.com > >
Re: Guidelines for test coverage
A related question: I noticed that dtest is not part of the Apache project: https://github.com/riptano/cassandra-dtest. Are there plans to contribute this to the ASF? Dave > On Sep 21, 2016, at 3:17 PM, Nate McCall wrote: > > We have these already written down in from both the reviewing and > development perspective: > http://cassandra.apache.org/doc/latest/development/how_to_review.html > http://cassandra.apache.org/doc/latest/development/testing.html > > My takeaway from recent in-person discussions the other week about this > topic, is that it's really just a matter of making this less of a > chore/sharing the burden of reviews when the whole dtest suite has to be > run. > > Thanks for bringing this up, though. > > On Tue, Sep 20, 2016 at 6:42 AM, sankalp kohli > wrote: > >> Hi, >>I wanted to know if there are any guidelines for contributors to give >> out unit and integration tests along with the patches. If not, we should >> discuss and have them in place. >> >> I know we are making good progress with test coverage but we should add >> guidelines around adding unit and integration tests with every patch. >> Thoughts on this? >> >> Thanks, >> Sankalp >> > > > > -- > - > Nate McCall > Wellington, NZ > @zznate > > CTO > Apache Cassandra Consulting > http://www.thelastpickle.com
Re: Guidelines for test coverage
We have these already written down in from both the reviewing and development perspective: http://cassandra.apache.org/doc/latest/development/how_to_review.html http://cassandra.apache.org/doc/latest/development/testing.html My takeaway from recent in-person discussions the other week about this topic, is that it's really just a matter of making this less of a chore/sharing the burden of reviews when the whole dtest suite has to be run. Thanks for bringing this up, though. On Tue, Sep 20, 2016 at 6:42 AM, sankalp kohli wrote: > Hi, > I wanted to know if there are any guidelines for contributors to give > out unit and integration tests along with the patches. If not, we should > discuss and have them in place. > > I know we are making good progress with test coverage but we should add > guidelines around adding unit and integration tests with every patch. > Thoughts on this? > > Thanks, > Sankalp > -- - Nate McCall Wellington, NZ @zznate CTO Apache Cassandra Consulting http://www.thelastpickle.com
