Re: Guidelines on testing

2017-05-05 Thread Blake Eggleston
I haven't had any objections, so I've openedĀ  https://issues.apache.org/jira/browse/CASSANDRA-13497 On May 4, 2017 at 10:18:10 AM, Jonathan Haddad (j...@jonhaddad.com) wrote: +1 On Tue, Apr 25, 2017 at 2:21 AM Stefan Podkowinski wrote: > I don't see any reasons not to

Re: Guidelines on testing

2017-05-04 Thread Jonathan Haddad
+1 On Tue, Apr 25, 2017 at 2:21 AM Stefan Podkowinski wrote: > I don't see any reasons not to make this part of our guidelines. The > idea of having a list of what should be tested in each kind of test > makes sense. I also like the examples how to improve tests dealing with >

Re: Guidelines on testing

2017-04-25 Thread Stefan Podkowinski
I don't see any reasons not to make this part of our guidelines. The idea of having a list of what should be tested in each kind of test makes sense. I also like the examples how to improve tests dealing with global state. Some of the integration test cases, such as "dry