[jira] [Commented] (CAUSEWAY-3753) Per-param validation errors show in wrong slot, for all params
[
https://issues.apache.org/jira/browse/CAUSEWAY-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852086#comment-17852086
]
Daniel Keir Haywood commented on CAUSEWAY-3753:
---
tested with the following added to SimpleObjects:
{noformat}
@Action(semantics = SemanticsOf.SAFE)
public Integer add(Integer first, Integer second) {
return first + second;
}
@MemberSupport
public String validate0Add(Integer first) {
return first > 30 ? "Can't be more than 30!" : null;
}
@MemberSupport
public String validate1Add(Integer first, Integer second) {
return second < first ? "Can't be less than first" : null;
}
@MemberSupport
public String validateAdd(Integer first, Integer second) {
return first + second > 100 ? "Can't be more than 100!" : null;
}
{noformat}
> Per-param validation errors show in wrong slot, for all params
> --
>
> Key: CAUSEWAY-3753
> URL: https://issues.apache.org/jira/browse/CAUSEWAY-3753
> Project: Causeway
> Issue Type: Bug
> Components: Viewer Wicket
>Affects Versions: 2.0.0
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: image-2024-05-29-12-29-47-312.png,
> image-2024-05-29-12-31-43-390.png, image-2024-06-01-15-55-29-991.png,
> image-2024-06-01-15-56-33-654.png, image-2024-06-01-15-59-48-335.png
>
>
> to reproduce:
> for example,with the petclinic tutorial
>
> git checkout tags/08-01-home-page-additional-collections
> mvn clean install
> mvn -pl webapp spring-boot:run
>
> attempt to create an Pet Owner ; there's validation on the first param, name
> ... but is only activated when hit OK.
>
> !image-2024-05-29-12-29-47-312.png!
>
> and compare changing name vs changing email address (regex):
>
> !image-2024-05-29-12-31-43-390.png!
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CAUSEWAY-3753) Per-param validation errors show in wrong slot, for all params
[ https://issues.apache.org/jira/browse/CAUSEWAY-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851299#comment-17851299 ] Daniel Keir Haywood commented on CAUSEWAY-3753: --- also CAUSEWAY-3436, marked as a duplicate: !image-2024-06-01-15-59-48-335.png! > Per-param validation errors show in wrong slot, for all params > -- > > Key: CAUSEWAY-3753 > URL: https://issues.apache.org/jira/browse/CAUSEWAY-3753 > Project: Causeway > Issue Type: Bug > Components: Viewer Wicket >Affects Versions: 2.0.0 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.1.0 > > Attachments: image-2024-05-29-12-29-47-312.png, > image-2024-05-29-12-31-43-390.png, image-2024-06-01-15-55-29-991.png, > image-2024-06-01-15-56-33-654.png, image-2024-06-01-15-59-48-335.png > > > to reproduce: > for example,with the petclinic tutorial > > git checkout tags/08-01-home-page-additional-collections > mvn clean install > mvn -pl webapp spring-boot:run > > attempt to create an Pet Owner ; there's validation on the first param, name > ... but is only activated when hit OK. > > !image-2024-05-29-12-29-47-312.png! > > and compare changing name vs changing email address (regex): > > !image-2024-05-29-12-31-43-390.png! > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CAUSEWAY-3753) Per-param validation errors show in wrong slot, for all params
[ https://issues.apache.org/jira/browse/CAUSEWAY-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851296#comment-17851296 ] Daniel Keir Haywood commented on CAUSEWAY-3753: --- also CAUSEWAY-3480, marked as duplicate, is another scenario: !image-2024-06-01-15-56-33-654.png! > Per-param validation errors show in wrong slot, for all params > -- > > Key: CAUSEWAY-3753 > URL: https://issues.apache.org/jira/browse/CAUSEWAY-3753 > Project: Causeway > Issue Type: Bug > Components: Viewer Wicket >Affects Versions: 2.0.0 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.1.0 > > Attachments: image-2024-05-29-12-29-47-312.png, > image-2024-05-29-12-31-43-390.png, image-2024-06-01-15-55-29-991.png, > image-2024-06-01-15-56-33-654.png > > > to reproduce: > for example,with the petclinic tutorial > > git checkout tags/08-01-home-page-additional-collections > mvn clean install > mvn -pl webapp spring-boot:run > > attempt to create an Pet Owner ; there's validation on the first param, name > ... but is only activated when hit OK. > > !image-2024-05-29-12-29-47-312.png! > > and compare changing name vs changing email address (regex): > > !image-2024-05-29-12-31-43-390.png! > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CAUSEWAY-3753) Per-param validation errors show in wrong slot, for all params
[ https://issues.apache.org/jira/browse/CAUSEWAY-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851295#comment-17851295 ] Daniel Keir Haywood commented on CAUSEWAY-3753: --- see also CAUSEWAY-3438, CAUSEWAY-3480 ... have been marked as duplicates, but have additional scenarios > Per-param validation errors show in wrong slot, for all params > -- > > Key: CAUSEWAY-3753 > URL: https://issues.apache.org/jira/browse/CAUSEWAY-3753 > Project: Causeway > Issue Type: Bug > Components: Viewer Wicket >Affects Versions: 2.0.0 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.1.0 > > Attachments: image-2024-05-29-12-29-47-312.png, > image-2024-05-29-12-31-43-390.png > > > to reproduce: > for example,with the petclinic tutorial > > git checkout tags/08-01-home-page-additional-collections > mvn clean install > mvn -pl webapp spring-boot:run > > attempt to create an Pet Owner ; there's validation on the first param, name > ... but is only activated when hit OK. > > !image-2024-05-29-12-29-47-312.png! > > and compare changing name vs changing email address (regex): > > !image-2024-05-29-12-31-43-390.png! > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
