Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-20 Thread Hugi
Being somewhat absent these days I just wanted to thank you guys for your work. Feel free to laugh but I don’t think I’ve been this excited about a software upgrade since System 7. Doing a production upgrade for a non-essential but high-traffic app in the coming week.

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-20 Thread Michael Gentry
Thanks Nikita! On Mon, Apr 20, 2020 at 3:53 AM Nikita Timofeev wrote: > Here is my > +1 > > And here is the results: > > John Huss (PMC): +1 > Michael Gentry (PMC): +1 > Andrus Adamchik (PMC): +1 > Nikita Timofeev (PMC): +1 > > Non-binding: > Emerson Castañeda: +1 > > I will finish the release

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-20 Thread Nikita Timofeev
Here is my +1 And here is the results: John Huss (PMC): +1 Michael Gentry (PMC): +1 Andrus Adamchik (PMC): +1 Nikita Timofeev (PMC): +1 Non-binding: Emerson Castañeda: +1 I will finish the release today. Thanks, everyone! On Sat, Apr 18, 2020 at 10:56 AM Andrus Adamchik wrote: > > +1 > > >

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-18 Thread Andrus Adamchik
+1 > On Apr 15, 2020, at 3:55 PM, Nikita Timofeev > wrote: > > Hi all, > > I hope this will be the last try for the 4.2.M1. > > Release notes: https://github.com/apache/cayenne/blob/4.2.M1/RELEASE-NOTES.txt > Maven repo: >

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-17 Thread Emerson Castañeda
Hi +1 (non-binding) 1) Compiled from code 2) Ran unit testing 3) RAT indicated no unlicensed files 4) Verified signatures 5) Verified SHA512 6) Ran compiled modeler / created and saved project (java-11-openjdk-amd64) Thanks Emerson On Thu, Apr 16, 2020 at 10:16 AM Michael Gentry wrote: >

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-16 Thread Michael Gentry
Hi Nikita! All of my release steps passed (assuming I use the RAT 0.14 snapshot) and building with Java 8 and Java 11 works. +1 Thanks! On Wed, Apr 15, 2020 at 9:04 AM Nikita Timofeev wrote: > Hi all, > > I hope this will be the last try for the 4.2.M1. > > Release notes: >

[VOTE] Apache Cayenne 4.2.M1 release

2020-04-15 Thread Nikita Timofeev
Hi all, I hope this will be the last try for the 4.2.M1. Release notes: https://github.com/apache/cayenne/blob/4.2.M1/RELEASE-NOTES.txt Maven repo: https://repository.apache.org/content/repositories/orgapachecayenne-1039/ Assemblies: https://dist.apache.org/repos/dist/dev/cayenne/4.2.M1/

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-15 Thread Nikita Timofeev
I just checked LinkMove with the fixed version, everything seems good to me. I'll start a new voting thread. On Tue, Apr 14, 2020 at 7:57 PM Andrus Adamchik wrote: > > > @Andrus: We'll let you test LM first this time? > > Be happy to. > > > > On Apr 14, 2020, at 7:48 PM, Michael Gentry wrote: >

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-14 Thread Andrus Adamchik
> @Andrus: We'll let you test LM first this time? Be happy to. > On Apr 14, 2020, at 7:48 PM, Michael Gentry wrote: > > @John & @Nikita: If easy to fix, let's go ahead and do it just to have a > better M1. > @Andrus: We'll let you test LM first this time? > > I guess that makes me more of a

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-14 Thread Michael Gentry
@John & @Nikita: If easy to fix, let's go ahead and do it just to have a better M1. @Andrus: We'll let you test LM first this time? I guess that makes me more of a -0 now. I'm still not opposed to releasing as-is, but a better M1 is still desirable. On Tue, Apr 14, 2020 at 5:10 AM Nikita

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-14 Thread Nikita Timofeev
That's not a big effort to prepare a fresh release, it getting faster each time :). So I think I could do it one more time. As for the issue, the fix seems straightforward, so I'll just go for it. On Tue, Apr 14, 2020 at 4:30 AM John Huss wrote: > > I would be fine with fixing it up and

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-13 Thread John Huss
I would be fine with fixing it up and remaking the release, but I don’t know how much of a hassle that is. I can find time to fix AutoAdapter in the next two days I think. On Mon, Apr 13, 2020 at 1:34 PM Andrus Adamchik wrote: > Been thinking more about this... This breaks basic commit

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-13 Thread Andrus Adamchik
Been thinking more about this... This breaks basic commit operations for both Derby and SQLServer, making it a major issue. We've never shipped releases with known bugs like this, even milestones. On the other hand there is a workaround - use an explicit adapter. I am voting -0, which means

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-13 Thread Michael Gentry
Hi Andrus, Given this is a milestone release, I think it is fine to release with the AutoAdapter issue. These releases aren't required or expected to be production-ready, although that would certainly be nice. They are for finding issues needing to be addressed, and you have. :-) mrg On

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-13 Thread Andrus Adamchik
So looks like this will affect users of Derby and SQLServer who are also using the AutoAdapter (don't know if anyone still NOT using the AutoAdapter?). I suppose we can still release the M1, though it will not be usable for me unfortunately until this is fixed. Thoughts? Andrus > On Apr 13,

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-13 Thread Nikita Timofeev
Hi Andrus, Yes, LinkMove problems related to batch generated keys. The problem is with AutoAdapter, it simply doesn't define supportsGeneratedKeysForBatchInserts() method. DerbyAdapter itself works fine. On Sun, Apr 12, 2020 at 11:47 AM Andrus Adamchik wrote: > > Still testing the release... As

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-12 Thread Andrus Adamchik
Still testing the release... As expected 4.2 is no longer a drop-in replacement of 4.0 for either Agrest or LinkMove (because of the Property class refactoring). So I made a few tweaks to LM to make it compile [1]. Now I am getting the following error on commit in a bunch of tests (e.g.

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-11 Thread Emerson Castañeda
Hi Nikita WOW a lot of changes, new features, and bug fixes. Congrats +1 (Non-binding) My checks: - Compiled from source, all tests passed, and ran generated generic modeler (java-8-openjdk-amd64 linux) - RAT script executed - no unlicensed files - Verified signature and hash for generic

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-11 Thread Michael Gentry
Hi Nikita! All of my release steps passed and building with Java 8 and Java 11 worked, including using Cayenne Modeler. +1 Thanks! On Tue, Apr 7, 2020 at 7:03 AM Nikita Timofeev wrote: > Hi all, > > Here is another try for the Cayenne 4.2.M1 release. > > Release notes: >

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-09 Thread Andrus Adamchik
> On Apr 7, 2020, at 9:28 PM, John Huss wrote: > > I got the rat 0.14 snapshot release, and everything looks good! Thanks! Interesting. I tried building Rat 0.14 from their SVN trunk and got https-related errors. The binary SNAPSHOT from the repo works though. So I am all good too and will

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-07 Thread John Huss
+1 I got the rat 0.14 snapshot release, and everything looks good! Thanks! 1) verified signatures 2) verified archives are basically identical between platforms 3) RAT indicates no unlicensed files 4) compiled from source 5) unit tests ran successfully 6) macOS specific and Platform-agnostic

[VOTE] Apache Cayenne 4.2.M1 release

2020-04-07 Thread Nikita Timofeev
Hi all, Here is another try for the Cayenne 4.2.M1 release. Release notes: https://github.com/apache/cayenne/blob/4.2.M1/RELEASE-NOTES.txt Maven repo: https://repository.apache.org/content/repositories/orgapachecayenne-1038/ Assemblies: https://dist.apache.org/repos/dist/dev/cayenne/4.2.M1/

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-03 Thread John Huss
Thanks, that issue appears to be fixed now! On Fri, Apr 3, 2020 at 6:57 AM Nikita Timofeev wrote: > Hi all, > > I've rolled back 4.2.M1 release and will start new voting soon. > Fix for the meaningful FK is committed now [1]. > I've also checked that the latest snapshot version of the Apache

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-04-03 Thread Nikita Timofeev
Hi all, I've rolled back 4.2.M1 release and will start new voting soon. Fix for the meaningful FK is committed now [1]. I've also checked that the latest snapshot version of the Apache RAT [2] is ok with the "https://;, so we could use it. I'll update docs and also will mention the maven plugin.

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-03-27 Thread John Huss
Thanks. I figured out the problem with cgen was that I had velocity-engine-core-2.0 instead of velocity-engine-core-2.1. Updating the jar fixed the problem. On Thu, Mar 26, 2020 at 12:25 PM Nikita Timofeev wrote: > Thank you, John, for your thorough testing. > > 1. Seems like RAT don't like

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-03-26 Thread Nikita Timofeev
Thank you, John, for your thorough testing. 1. Seems like RAT don't like the change from "http://; to "https://; in the license text. I've updated settings for the RAT maven plugin (as I use it to check sources) and that works ok. Need to update config for the standalone script. 2. Cgen + ant.

Re: [VOTE] Apache Cayenne 4.2.M1 release

2020-03-25 Thread John Huss
Thanks for all your work on this. 4.2 is going to be a great release! I ran all my checks on the release and almost everything passed. I don't know what changed, but I'm having a RAT problem I haven't seen before. RAT (both 0.12 and 0.13) show this header: Printing headers for text files without

[VOTE] Apache Cayenne 4.2.M1 release

2020-03-24 Thread Nikita Timofeev
Hi all, Here is a long-awaited 4.2.M1 release. JIRA tells that it has impressive 100 issues resolved. Release notes: https://github.com/apache/cayenne/blob/4.2.M1/RELEASE-NOTES.txt Maven repo: https://repository.apache.org/content/repositories/orgapachecayenne-1037/ Assemblies: