Re: Cayenne own template renderer to replace Velocity

2017-08-14 Thread Mike Kienenberger
Just a note that Velocity 2.0 is finally released. If I remember right, lots of dependency fixes there too. On Mon, Aug 14, 2017 at 8:21 AM, Andrus Adamchik wrote: >> If we choose a 'provided' scope, won't that work and be better? > > I think it will be worse. Velocity is not like servlet spec ja

Re: Cayenne own template renderer to replace Velocity

2017-08-14 Thread Andrus Adamchik
> If we choose a 'provided' scope, won't that work and be better? I think it will be worse. Velocity is not like servlet spec jar or something that comes from a container (and less and less ppl are using containers anyways nowadays). The result of making it "provided" will be that our library wi

Re: Cayenne own template renderer to replace Velocity

2017-08-14 Thread Michael Gentry
Yes, but that's us kind of forcing a version of Velocity upon our users rather than them choosing the version that works with their environment. Sure, they can do dependency exclusions, etc, in the POM, but that's a slight hassle. If we choose a 'provided' scope, won't that work and be better? It

Re: Cayenne own template renderer to replace Velocity

2017-08-14 Thread Nikita Timofeev
Cayenne-velocity module should use version of Velocity we specify, the main point is that cayenne-server won't use it anymore. As for explicit "compile" scope that's just copy-past, it can be omitted as it's default anyway. On Mon, Aug 14, 2017 at 2:16 PM, Michael Gentry wrote: > Won't a compile

Re: Cayenne own template renderer to replace Velocity

2017-08-14 Thread Michael Gentry
Won't a compile scope pull in a version of Velocity we specify? https://github.com/apache/cayenne/pull/238/files#diff-e286320b0b1da27d2621bf787ddd75b1R48 On Fri, Aug 11, 2017 at 7:23 AM, Andrus Adamchik wrote: > > I'm assuming the template engine will be injectable > > Yes, and even better. Wi

Re: Cayenne own template renderer to replace Velocity

2017-08-11 Thread Michael Gentry
Awesome! On Fri, Aug 11, 2017 at 7:23 AM, Andrus Adamchik wrote: > > I'm assuming the template engine will be injectable > > Yes, and even better. With module auto-loading, you simply put your > template engine jar on classpath, and you get it installed automatically. > This is how backwards-co

Re: Cayenne own template renderer to replace Velocity

2017-08-11 Thread Andrus Adamchik
> I'm assuming the template engine will be injectable Yes, and even better. With module auto-loading, you simply put your template engine jar on classpath, and you get it installed automatically. This is how backwards-compatible cayenne-velocity will operate. Andrus > On Aug 11, 2017, at 2:21

Re: Cayenne own template renderer to replace Velocity

2017-08-11 Thread Michael Gentry
I haven't looked into the details, but I like the idea of reducing dependencies upon external libraries, which can cause headaches with applications using Cayenne. I'm assuming the template engine will be injectable so that you can choose Velocity, Freemarker, etc if you'd like? (Of course, you m

Cayenne own template renderer to replace Velocity

2017-08-10 Thread Nikita Timofeev
Hi all, I've opened a PR [1] just now with new SQLTemplateProcessor implementation based on new Cayenne own parser (instead of Velocity). It doesn't support all features of Velocity but it's enough to seamlessly replace Velocity in all core and test code in Cayenne, plus it's faster (up to x15 in