[GitHub] [celix] abroekhuis commented on pull request #234: Only disable optimizations for specific test, rather than entire celix

2020-05-20 Thread GitBox 


abroekhuis commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-631293443


   > It sometimes works: https://github.com/apache/celix/runs/689314715
   > Sometimes doesn't: 
https://github.com/apache/celix/runs/691022810?check_suite_focus=true
   
   Nice those random failures :(. Any idea if we can figure out what is going 
on?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [celix] abroekhuis commented on pull request #234: Only disable optimizations for specific test, rather than entire celix

2020-05-19 Thread GitBox 


abroekhuis commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-631248351


   @Oipo this still seems to fail on CLang (see nightly builds for Ubuntu 
CLang).
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [celix] abroekhuis commented on pull request #234: Only disable optimizations for specific test, rather than entire celix

2020-05-17 Thread GitBox 


abroekhuis commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-629978117


   > The fact that disabling opts specifically for this function 'fixes' it, 
suggests it's not ffi that's the problem, but maybe something like register 
clobbering. Or wrong usage of ffi.
   
   I also agree with this, but then we should also be able to fix it ;). 
Anyway, I'll approve it. Let's look into this if needed, or in another issue/pr.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [celix] abroekhuis commented on pull request #234: Only disable optimizations for specific test, rather than entire celix

2020-05-17 Thread GitBox 


abroekhuis commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-629849705


   While this does work, I don't feel really comfortable with it. Even though 
this test triggers the problem, the problem also seems to come from the ffi 
library.
   Are we certain it is due to the test? And if not, how certain are we that 
this will not happen in a released version?
   
   @pnoltes wdyt?
   
   Having said that, I'm fine with approving it, as long as we remember this is 
an issue, if it comes up again.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org