[GitHub] [celix] codecov-commenter edited a comment on pull request #253: Feature/proposal protocol footer
codecov-commenter edited a comment on pull request #253: URL: https://github.com/apache/celix/pull/253#issuecomment-640841097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-commenter edited a comment on pull request #253: Feature/proposal protocol footer
codecov-commenter edited a comment on pull request #253: URL: https://github.com/apache/celix/pull/253#issuecomment-640841097 # [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report > Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/6c5ea5ac7254d416a0bae651244012ab03a223b2&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `85.18%`. [](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #253 +/- ## == + Coverage 67.88% 67.96% +0.08% == Files 127 130 +3 Lines 2639826605 +207 == + Hits1791918081 +162 - Misses 8479 8524 +45 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `78.12% <ø> (-10.94%)` | :arrow_down: | | [...tocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_common.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2NvbW1vbi5j) | `51.61% <51.61%> (ø)` | | | [...sub/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19zZW5kZXIuYw==) | `69.25% <78.26%> (+0.95%)` | :arrow_up: | | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.48% <81.48%> (+0.30%)` | :arrow_up: | | [...b/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19yZWNlaXZlci5j) | `63.63% <87.50%> (+0.61%)` | :arrow_up: | | [...b\_protocol\_wire\_v1/src/pubsub\_wire\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3B1YnN1Yl93aXJlX3Byb3RvY29sX2ltcGwuYw==) | `84.48% <88.23%> (-2.19%)` | :arrow_down: | | [...rotocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2ltcGwuYw==) | `92.38% <92.38%> (ø)` | | | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.12% <100.00%> (-0.03%)` | :arrow_down: | | [...\_protocol\_wire\_v1/src/ps\_wire\_protocol\_activator.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3BzX3dpcmVfcHJvdG9jb2xfYWN0aXZhdG9yLmM=) | `100.00% <100.00%> (ø)` | | | [...otocol\_wire\_v2/src/ps\_wire\_v2\_protocol\_activator.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3BzX3dpcmVfdjJfcHJvdG9jb2xfYWN0aXZhdG9yLmM=) | `100.00% <100.00%> (ø)` | | | ... and [6 more](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=footer). Last update [6c5ea5a...a09cda8](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-commenter edited a comment on pull request #253: Feature/proposal protocol footer
codecov-commenter edited a comment on pull request #253: URL: https://github.com/apache/celix/pull/253#issuecomment-640841097 # [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report > Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **increase** coverage by `0.11%`. > The diff coverage is `77.87%`. [](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #253 +/- ## == + Coverage 67.82% 67.94% +0.11% == Files 127 130 +3 Lines 2637526591 +216 == + Hits1789018068 +178 - Misses 8485 8523 +38 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `78.12% <ø> (ø)` | | | [...tocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_common.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2NvbW1vbi5j) | `51.61% <51.61%> (ø)` | | | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.48% <65.94%> (-0.72%)` | :arrow_down: | | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: | | [...sub/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19zZW5kZXIuYw==) | `69.25% <78.26%> (+0.95%)` | :arrow_up: | | [...b/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19yZWNlaXZlci5j) | `63.63% <87.50%> (+0.61%)` | :arrow_up: | | [...b\_protocol\_wire\_v1/src/pubsub\_wire\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3B1YnN1Yl93aXJlX3Byb3RvY29sX2ltcGwuYw==) | `84.48% <88.23%> (-2.19%)` | :arrow_down: | | [...rotocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2ltcGwuYw==) | `92.38% <92.38%> (ø)` | | | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.12% <100.00%> (ø)` | | | [...\_protocol\_wire\_v1/src/ps\_wire\_protocol\_activator.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3BzX3dpcmVfcHJvdG9jb2xfYWN0aXZhdG9yLmM=) | `100.00% <100.00%> (ø)` | | | ... and [5 more](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=footer). Last update [f25f19f...996eea7](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-commenter edited a comment on pull request #253: Feature/proposal protocol footer
codecov-commenter edited a comment on pull request #253: URL: https://github.com/apache/celix/pull/253#issuecomment-640841097 # [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report > Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #253 +/- ## == + Coverage 67.82% 67.90% +0.07% == Files 127 130 +3 Lines 2637526594 +219 == + Hits1789018059 +169 - Misses 8485 8535 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `89.06% <ø> (+10.93%)` | :arrow_up: | | [...tocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_common.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2NvbW1vbi5j) | `51.61% <51.61%> (ø)` | | | [...sub/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19zZW5kZXIuYw==) | `67.86% <56.52%> (-0.44%)` | :arrow_down: | | [...b/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19yZWNlaXZlci5j) | `63.15% <62.50%> (+0.14%)` | :arrow_up: | | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.48% <65.94%> (-0.72%)` | :arrow_down: | | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: | | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.14% <75.00%> (+0.02%)` | :arrow_up: | | [...b\_protocol\_wire\_v1/src/pubsub\_wire\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3B1YnN1Yl93aXJlX3Byb3RvY29sX2ltcGwuYw==) | `84.48% <88.23%> (-2.19%)` | :arrow_down: | | [...rotocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2ltcGwuYw==) | `89.52% <89.52%> (ø)` | | | [...\_protocol\_wire\_v1/src/ps\_wire\_protocol\_activator.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3BzX3dpcmVfcHJvdG9jb2xfYWN0aXZhdG9yLmM=) | `100.00% <100.00%> (ø)` | | | ... and [7 more](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=footer). Last update [f25f19f...26ece37](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-commenter edited a comment on pull request #253: Feature/proposal protocol footer
codecov-commenter edited a comment on pull request #253: URL: https://github.com/apache/celix/pull/253#issuecomment-640841097 # [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report > Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #253 +/- ## == + Coverage 67.82% 67.90% +0.07% == Files 127 130 +3 Lines 2637526594 +219 == + Hits1789018059 +169 - Misses 8485 8535 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `89.06% <ø> (+10.93%)` | :arrow_up: | | [...tocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_common.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2NvbW1vbi5j) | `51.61% <51.61%> (ø)` | | | [...sub/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19zZW5kZXIuYw==) | `67.86% <56.52%> (-0.44%)` | :arrow_down: | | [...b/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19yZWNlaXZlci5j) | `63.15% <62.50%> (+0.14%)` | :arrow_up: | | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.48% <65.94%> (-0.72%)` | :arrow_down: | | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: | | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.14% <75.00%> (+0.02%)` | :arrow_up: | | [...b\_protocol\_wire\_v1/src/pubsub\_wire\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3B1YnN1Yl93aXJlX3Byb3RvY29sX2ltcGwuYw==) | `84.48% <88.23%> (-2.19%)` | :arrow_down: | | [...rotocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2ltcGwuYw==) | `89.52% <89.52%> (ø)` | | | [...\_protocol\_wire\_v1/src/ps\_wire\_protocol\_activator.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3BzX3dpcmVfcHJvdG9jb2xfYWN0aXZhdG9yLmM=) | `100.00% <100.00%> (ø)` | | | ... and [7 more](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=footer). Last update [f25f19f...26ece37](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-commenter edited a comment on pull request #253: Feature/proposal protocol footer
codecov-commenter edited a comment on pull request #253: URL: https://github.com/apache/celix/pull/253#issuecomment-640841097 # [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report > Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #253 +/- ## == + Coverage 67.82% 67.90% +0.07% == Files 127 130 +3 Lines 2637526594 +219 == + Hits1789018059 +169 - Misses 8485 8535 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `89.06% <ø> (+10.93%)` | :arrow_up: | | [...tocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_common.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2NvbW1vbi5j) | `51.61% <51.61%> (ø)` | | | [...sub/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19zZW5kZXIuYw==) | `67.86% <56.52%> (-0.44%)` | :arrow_down: | | [...b/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19yZWNlaXZlci5j) | `63.15% <62.50%> (+0.14%)` | :arrow_up: | | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.48% <65.94%> (-0.72%)` | :arrow_down: | | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: | | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.14% <75.00%> (+0.02%)` | :arrow_up: | | [...b\_protocol\_wire\_v1/src/pubsub\_wire\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3B1YnN1Yl93aXJlX3Byb3RvY29sX2ltcGwuYw==) | `84.48% <88.23%> (-2.19%)` | :arrow_down: | | [...rotocol\_wire\_v2/src/pubsub\_wire\_v2\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjIvc3JjL3B1YnN1Yl93aXJlX3YyX3Byb3RvY29sX2ltcGwuYw==) | `89.52% <89.52%> (ø)` | | | [...\_protocol\_wire\_v1/src/ps\_wire\_protocol\_activator.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3BzX3dpcmVfcHJvdG9jb2xfYWN0aXZhdG9yLmM=) | `100.00% <100.00%> (ø)` | | | ... and [7 more](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=footer). Last update [f25f19f...26ece37](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-commenter edited a comment on pull request #253: Feature/proposal protocol footer
codecov-commenter edited a comment on pull request #253: URL: https://github.com/apache/celix/pull/253#issuecomment-640841097 # [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=h1) Report > Merging [#253](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f25f19f304d80caf2c41bd21580075a1e935b190&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `72.50%`. [](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #253 +/- ## == + Coverage 67.82% 67.91% +0.08% == Files 127 127 Lines 2637526438 +63 == + Hits1789017955 +65 + Misses 8485 8483 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `89.06% <ø> (+10.93%)` | :arrow_up: | | [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `64.13% <66.66%> (+0.02%)` | :arrow_up: | | [...s/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_handler.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9oYW5kbGVyLmM=) | `75.65% <66.90%> (-0.55%)` | :arrow_down: | | [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `63.14% <75.00%> (+0.02%)` | :arrow_up: | | [...sub/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19zZW5kZXIuYw==) | `68.92% <75.00%> (+0.62%)` | :arrow_up: | | [...b/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_receiver.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19yZWNlaXZlci5j) | `63.28% <80.00%> (+0.26%)` | :arrow_up: | | [...b\_protocol\_wire\_v1/src/pubsub\_wire\_protocol\_impl.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3B1YnN1Yl93aXJlX3Byb3RvY29sX2ltcGwuYw==) | `87.50% <93.33%> (+0.83%)` | :arrow_up: | | [...\_protocol\_wire\_v1/src/ps\_wire\_protocol\_activator.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sX3dpcmVfdjEvc3JjL3BzX3dpcmVfcHJvdG9jb2xfYWN0aXZhdG9yLmM=) | `100.00% <100.00%> (ø)` | | | [libs/framework/src/framework.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `75.52% <0.00%> (+0.21%)` | :arrow_up: | | [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `94.23% <0.00%> (+1.15%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/celix/pull/253/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=footer). Last update [f25f19f...864ad47](https://codecov.io/gh/apache/celix/pull/253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
