[GitHub] [celix] codecov-io edited a comment on pull request #293: Feature/add build to svc dep creation
codecov-io edited a comment on pull request #293: URL: https://github.com/apache/celix/pull/293#issuecomment-725653571 # [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=h1) Report > Merging [#293](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=desc) (6d1b2dd) into [master](https://codecov.io/gh/apache/celix/commit/7a26aea42fd33849e54a33d69969e42d096b9dcd?el=desc) (7a26aea) will **increase** coverage by `1.48%`. > The diff coverage is `96.96%`. [](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #293 +/- ## == + Coverage 66.69% 68.18% +1.48% == Files 147 148 +1 Lines 2994730088 +141 == + Hits1997420516 +542 + Misses 9973 9572 -401 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/include/celix/dm/types.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS90eXBlcy5o) | `92.85% <ø> (ø)` | | | [libs/framework/include/celix/dm/Component\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnRfSW1wbC5o) | `76.92% <93.54%> (+14.27%)` | :arrow_up: | | [libs/framework/include/celix/dm/Component.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnQuaA==) | `100.00% <100.00%> (ø)` | | | [...ramework/include/celix/dm/DependencyManager\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9EZXBlbmRlbmN5TWFuYWdlcl9JbXBsLmg=) | `100.00% <100.00%> (+12.50%)` | :arrow_up: | | [libs/framework/include/celix/dm/ProvidedService.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2UuaA==) | `100.00% <100.00%> (ø)` | | | [.../framework/include/celix/dm/ProvidedService\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2VfSW1wbC5o) | `100.00% <100.00%> (ø)` | | | [...ibs/framework/include/celix/dm/ServiceDependency.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeS5o) | `84.21% <100.00%> (ø)` | | | [...ramework/include/celix/dm/ServiceDependency\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeV9JbXBsLmg=) | `82.35% <100.00%> (+17.64%)` | :arrow_up: | | ... and [13 more](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=footer). Last update [7a26aea...6d1b2dd](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-io edited a comment on pull request #293: Feature/add build to svc dep creation
codecov-io edited a comment on pull request #293: URL: https://github.com/apache/celix/pull/293#issuecomment-725653571 # [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=h1) Report > Merging [#293](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=desc) (6d1b2dd) into [master](https://codecov.io/gh/apache/celix/commit/7a26aea42fd33849e54a33d69969e42d096b9dcd?el=desc) (7a26aea) will **increase** coverage by `1.47%`. > The diff coverage is `96.96%`. [](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #293 +/- ## == + Coverage 66.69% 68.17% +1.47% == Files 147 148 +1 Lines 2994730088 +141 == + Hits1997420512 +538 + Misses 9973 9576 -397 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/include/celix/dm/types.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS90eXBlcy5o) | `92.85% <ø> (ø)` | | | [libs/framework/include/celix/dm/Component\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnRfSW1wbC5o) | `76.92% <93.54%> (+14.27%)` | :arrow_up: | | [libs/framework/include/celix/dm/Component.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnQuaA==) | `100.00% <100.00%> (ø)` | | | [...ramework/include/celix/dm/DependencyManager\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9EZXBlbmRlbmN5TWFuYWdlcl9JbXBsLmg=) | `100.00% <100.00%> (+12.50%)` | :arrow_up: | | [libs/framework/include/celix/dm/ProvidedService.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2UuaA==) | `100.00% <100.00%> (ø)` | | | [.../framework/include/celix/dm/ProvidedService\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2VfSW1wbC5o) | `100.00% <100.00%> (ø)` | | | [...ibs/framework/include/celix/dm/ServiceDependency.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeS5o) | `84.21% <100.00%> (ø)` | | | [...ramework/include/celix/dm/ServiceDependency\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeV9JbXBsLmg=) | `82.35% <100.00%> (+17.64%)` | :arrow_up: | | ... and [11 more](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=footer). Last update [7a26aea...6d1b2dd](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-io edited a comment on pull request #293: Feature/add build to svc dep creation
codecov-io edited a comment on pull request #293: URL: https://github.com/apache/celix/pull/293#issuecomment-725653571 # [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=h1) Report > Merging [#293](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=desc) (94dc9cc) into [master](https://codecov.io/gh/apache/celix/commit/7a26aea42fd33849e54a33d69969e42d096b9dcd?el=desc) (7a26aea) will **increase** coverage by `1.41%`. > The diff coverage is `96.72%`. [](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #293 +/- ## == + Coverage 66.69% 68.11% +1.41% == Files 147 148 +1 Lines 2994730034 +87 == + Hits1997420457 +483 + Misses 9973 9577 -396 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/include/celix/dm/types.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS90eXBlcy5o) | `92.85% <ø> (ø)` | | | [libs/framework/include/celix/dm/Component\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnRfSW1wbC5o) | `75.75% <92.85%> (+13.10%)` | :arrow_up: | | [libs/framework/include/celix/dm/Component.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnQuaA==) | `100.00% <100.00%> (ø)` | | | [...ramework/include/celix/dm/DependencyManager\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9EZXBlbmRlbmN5TWFuYWdlcl9JbXBsLmg=) | `100.00% <100.00%> (+12.50%)` | :arrow_up: | | [libs/framework/include/celix/dm/ProvidedService.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2UuaA==) | `100.00% <100.00%> (ø)` | | | [.../framework/include/celix/dm/ProvidedService\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2VfSW1wbC5o) | `100.00% <100.00%> (ø)` | | | [...ibs/framework/include/celix/dm/ServiceDependency.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeS5o) | `84.21% <100.00%> (ø)` | | | [...ramework/include/celix/dm/ServiceDependency\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeV9JbXBsLmg=) | `88.00% <100.00%> (+23.29%)` | :arrow_up: | | ... and [13 more](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=footer). Last update [7a26aea...94dc9cc](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-io edited a comment on pull request #293: Feature/add build to svc dep creation
codecov-io edited a comment on pull request #293: URL: https://github.com/apache/celix/pull/293#issuecomment-725653571 # [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=h1) Report > Merging [#293](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=desc) (94dc9cc) into [master](https://codecov.io/gh/apache/celix/commit/7a26aea42fd33849e54a33d69969e42d096b9dcd?el=desc) (7a26aea) will **increase** coverage by `1.39%`. > The diff coverage is `96.72%`. [](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #293 +/- ## == + Coverage 66.69% 68.09% +1.39% == Files 147 148 +1 Lines 2994730034 +87 == + Hits1997420452 +478 + Misses 9973 9582 -391 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/include/celix/dm/types.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS90eXBlcy5o) | `92.85% <ø> (ø)` | | | [libs/framework/include/celix/dm/Component\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnRfSW1wbC5o) | `75.75% <92.85%> (+13.10%)` | :arrow_up: | | [libs/framework/include/celix/dm/Component.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnQuaA==) | `100.00% <100.00%> (ø)` | | | [...ramework/include/celix/dm/DependencyManager\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9EZXBlbmRlbmN5TWFuYWdlcl9JbXBsLmg=) | `100.00% <100.00%> (+12.50%)` | :arrow_up: | | [libs/framework/include/celix/dm/ProvidedService.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2UuaA==) | `100.00% <100.00%> (ø)` | | | [.../framework/include/celix/dm/ProvidedService\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2VfSW1wbC5o) | `100.00% <100.00%> (ø)` | | | [...ibs/framework/include/celix/dm/ServiceDependency.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeS5o) | `84.21% <100.00%> (ø)` | | | [...ramework/include/celix/dm/ServiceDependency\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeV9JbXBsLmg=) | `88.00% <100.00%> (+23.29%)` | :arrow_up: | | ... and [11 more](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=footer). Last update [7a26aea...94dc9cc](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-io edited a comment on pull request #293: Feature/add build to svc dep creation
codecov-io edited a comment on pull request #293: URL: https://github.com/apache/celix/pull/293#issuecomment-725653571 # [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=h1) Report > Merging [#293](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=desc) (f433fcc) into [master](https://codecov.io/gh/apache/celix/commit/4ebde14e5cd089223339f5a21c07c0cea9ab34f8?el=desc) (4ebde14) will **decrease** coverage by `0.29%`. > The diff coverage is `96.72%`. [](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #293 +/- ## == - Coverage 68.29% 67.99% -0.30% == Files 136 152 +16 Lines 2737931504+4125 == + Hits1869821422+2724 - Misses 868110082+1401 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/include/celix/dm/types.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS90eXBlcy5o) | `92.85% <ø> (ø)` | | | [libs/framework/include/celix/dm/Component\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnRfSW1wbC5o) | `75.75% <92.85%> (+13.10%)` | :arrow_up: | | [libs/framework/include/celix/dm/Component.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnQuaA==) | `100.00% <100.00%> (ø)` | | | [...ramework/include/celix/dm/DependencyManager\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9EZXBlbmRlbmN5TWFuYWdlcl9JbXBsLmg=) | `100.00% <100.00%> (+12.50%)` | :arrow_up: | | [libs/framework/include/celix/dm/ProvidedService.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2UuaA==) | `100.00% <100.00%> (ø)` | | | [.../framework/include/celix/dm/ProvidedService\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2VfSW1wbC5o) | `100.00% <100.00%> (ø)` | | | [...ibs/framework/include/celix/dm/ServiceDependency.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeS5o) | `84.21% <100.00%> (ø)` | | | [...ramework/include/celix/dm/ServiceDependency\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeV9JbXBsLmg=) | `88.00% <100.00%> (+23.29%)` | :arrow_up: | | [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `93.08% <0.00%> (-0.29%)` | :arrow_down: | | ... and [32 more](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=footer). Last update [4ebde14...f433fcc](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-io edited a comment on pull request #293: Feature/add build to svc dep creation
codecov-io edited a comment on pull request #293: URL: https://github.com/apache/celix/pull/293#issuecomment-725653571 # [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=h1) Report > Merging [#293](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=desc) (f433fcc) into [master](https://codecov.io/gh/apache/celix/commit/4ebde14e5cd089223339f5a21c07c0cea9ab34f8?el=desc) (4ebde14) will **increase** coverage by `1.50%`. > The diff coverage is `96.72%`. [](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #293 +/- ## == + Coverage 68.29% 69.80% +1.50% == Files 136 137 +1 Lines 2737927466 +87 == + Hits1869819172 +474 + Misses 8681 8294 -387 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/include/celix/dm/types.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS90eXBlcy5o) | `92.85% <ø> (ø)` | | | [libs/framework/include/celix/dm/Component\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnRfSW1wbC5o) | `75.75% <92.85%> (+13.10%)` | :arrow_up: | | [libs/framework/include/celix/dm/Component.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnQuaA==) | `100.00% <100.00%> (ø)` | | | [...ramework/include/celix/dm/DependencyManager\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9EZXBlbmRlbmN5TWFuYWdlcl9JbXBsLmg=) | `100.00% <100.00%> (+12.50%)` | :arrow_up: | | [libs/framework/include/celix/dm/ProvidedService.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2UuaA==) | `100.00% <100.00%> (ø)` | | | [.../framework/include/celix/dm/ProvidedService\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Qcm92aWRlZFNlcnZpY2VfSW1wbC5o) | `100.00% <100.00%> (ø)` | | | [...ibs/framework/include/celix/dm/ServiceDependency.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeS5o) | `84.21% <100.00%> (ø)` | | | [...ramework/include/celix/dm/ServiceDependency\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeV9JbXBsLmg=) | `88.00% <100.00%> (+23.29%)` | :arrow_up: | | [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `93.08% <0.00%> (-0.29%)` | :arrow_down: | | ... and [11 more](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=footer). Last update [4ebde14...f433fcc](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] codecov-io edited a comment on pull request #293: Feature/add build to svc dep creation
codecov-io edited a comment on pull request #293: URL: https://github.com/apache/celix/pull/293#issuecomment-725653571 # [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=h1) Report > Merging [#293](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=desc) (4e70741) into [master](https://codecov.io/gh/apache/celix/commit/4ebde14e5cd089223339f5a21c07c0cea9ab34f8?el=desc) (4ebde14) will **increase** coverage by `1.44%`. > The diff coverage is `98.82%`. [](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #293 +/- ## == + Coverage 68.29% 69.74% +1.44% == Files 136 135 -1 Lines 2737927408 +29 == + Hits1869819115 +417 + Misses 8681 8293 -388 ``` | [Impacted Files](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [libs/framework/include/celix/dm/types.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS90eXBlcy5o) | `92.85% <ø> (ø)` | | | [libs/framework/include/celix/dm/Component\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnRfSW1wbC5o) | `71.81% <97.77%> (+9.16%)` | :arrow_up: | | [libs/framework/include/celix/dm/Component.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9Db21wb25lbnQuaA==) | `100.00% <100.00%> (ø)` | | | [...ramework/include/celix/dm/DependencyManager\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9EZXBlbmRlbmN5TWFuYWdlcl9JbXBsLmg=) | `100.00% <100.00%> (+12.50%)` | :arrow_up: | | [...ibs/framework/include/celix/dm/ServiceDependency.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeS5o) | `84.21% <100.00%> (ø)` | | | [...ramework/include/celix/dm/ServiceDependency\_Impl.h](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvaW5jbHVkZS9jZWxpeC9kbS9TZXJ2aWNlRGVwZW5kZW5jeV9JbXBsLmg=) | `88.00% <100.00%> (+23.29%)` | :arrow_up: | | [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `94.23% <0.00%> (+0.86%)` | :arrow_up: | | [...dmin\_websocket/src/pubsub\_websocket\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF90b3BpY19zZW5kZXIuYw==) | `83.24% <0.00%> (+1.11%)` | :arrow_up: | | [...sub\_topology\_manager/src/pubsub\_topology\_manager.c](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3RvcG9sb2d5X21hbmFnZXIvc3JjL3B1YnN1Yl90b3BvbG9neV9tYW5hZ2VyLmM=) | `52.80% <0.00%> (+1.14%)` | :arrow_up: | | ... and [7 more](https://codecov.io/gh/apache/celix/pull/293/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=footer). Last update [4ebde14...4e70741](https://codecov.io/gh/apache/celix/pull/293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
