[GitHub] [celix] pnoltes commented on a diff in pull request #412: Feature/update documentation
pnoltes commented on code in PR #412: URL: https://github.com/apache/celix/pull/412#discussion_r848777412 ## documents/diagrams/services_tracker_services_rem_seq.puml: ## @@ -0,0 +1,42 @@ +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. + +@startuml +actor ProviderBundle +actor TrackerBundle +control celix_event_thread + +ProviderBundle -> celix_bundle_context_t ++: celix_bundleContext_unregisterService Review Comment: Again this is correct, because to shows the handling of a unregister service with an active service tracker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] pnoltes commented on a diff in pull request #412: Feature/update documentation
pnoltes commented on code in PR #412: URL: https://github.com/apache/celix/pull/412#discussion_r848776260 ## documents/diagrams/services_tracker_services_add_seq.puml: ## @@ -0,0 +1,44 @@ +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. + +@startuml +actor ProviderBundle +actor TrackerBundle +control celix_event_thread + +ProviderBundle -> celix_bundle_context_t ++: celix_bundleContext_registerService Review Comment: No this is correct. This shows how a synced register service is handled with an active service tracker. But maybe the puml file name should be different? Something like `register_service_with_active_service_tracker_seq.puml`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] pnoltes commented on a diff in pull request #412: Feature/update documentation
pnoltes commented on code in PR #412: URL: https://github.com/apache/celix/pull/412#discussion_r848776260 ## documents/diagrams/services_tracker_services_add_seq.puml: ## @@ -0,0 +1,44 @@ +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. + +@startuml +actor ProviderBundle +actor TrackerBundle +control celix_event_thread + +ProviderBundle -> celix_bundle_context_t ++: celix_bundleContext_registerService Review Comment: No this is correct. This shows how a synced register service is handled with an active service tracker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] pnoltes commented on a diff in pull request #412: Feature/update documentation
pnoltes commented on code in PR #412: URL: https://github.com/apache/celix/pull/412#discussion_r848774380 ## documents/diagrams/services_tracker_services_rem_async_seq.puml: ## @@ -0,0 +1,38 @@ +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. + +@startuml +actor ProviderBundle +actor TrackerBundle +control celix_event_thread + +ProviderBundle -> celix_bundle_context_t ++: celix_bundleContext_unregisterService Review Comment: It should be `celix_bundleContext_unregisterServiceAsync` instead of `celix_bundleContext_unregisterService` , but not service tracker. This shows how a unregister service async is handled with an active service tracker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] pnoltes commented on a diff in pull request #412: Feature/update documentation
pnoltes commented on code in PR #412: URL: https://github.com/apache/celix/pull/412#discussion_r848774380 ## documents/diagrams/services_tracker_services_rem_async_seq.puml: ## @@ -0,0 +1,38 @@ +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. + +@startuml +actor ProviderBundle +actor TrackerBundle +control celix_event_thread + +ProviderBundle -> celix_bundle_context_t ++: celix_bundleContext_unregisterService Review Comment: It should be `celix_bundleContext_unregisterServiceAsync`, but not service tracker. This shows how a unregister service async is handled with an active service tracker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[GitHub] [celix] pnoltes commented on a diff in pull request #412: Feature/update documentation
pnoltes commented on code in PR #412: URL: https://github.com/apache/celix/pull/412#discussion_r846833185 ## documents/building/dev_celix_with_clion.md: ## @@ -0,0 +1,64 @@ +--- +title: Building and Developing Apache Celix with CLion +--- + + + +# Building and Developing Apache Celix with CLion +Apache Celix can be build for development in CLion with use of the Conan package manager. +Conan will arrange the building of the Apache Celix dependencies and generate Find files for these dependencies. + +Conan will also generate a `active_run.sh` and `deactivate_run.sh` script that does the environment (de)setup for the +binary locations of the build dependencies (i.e. configures `PATH` and `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH`). + +## Setting up the build directory +```shell +#clone git repo +git clone https://github.com/apache/celix.git +cd celix + +#if needed setup conan default and debug profile +conan profile new default --detect +conan profile new debug --detect +conan profile update settings.build_type=Debug debug + +#generate and configure cmake-build-debug directory +conan install . celix/2.3.0@apache/testing -pr:b default -pr:h debug -if cmake-build-debug/ -o celix:enable_testing=True -o celix:enable_address_sanitizer=True -o celix:build_all=True -b missing Review Comment: For the conan ref is used `celix/2.3.0@apache/testing`, because I was not sure if `celix/2.3.0@zhengpeng/testing` is correct ref to use. But I am happy to revert back to `celix/2.3.0@zhengpeng/testing` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
