[GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...

2016-03-01 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1425#issuecomment-190853930 Hi @pedro-martins thanks for your comments! About test cases you mean unit tests or an integration test for this changes? I planned to use that

RE: Important Pending Items

2016-03-01 Thread Paul Angus
Hi Will, It will be 100% open source. The $dayjob has blocked the team from working on it recently. I'd like to get some of our ideas into the CloudStack wiki this week before I go on leave for a week. Rohit has created a repo for us: https://github.com/shapeblue/Trillian (which looks a bit sad

Re: Slow remote debugging

2016-03-01 Thread Tutkowski, Mike
Thanks for the suggestion, Rohit! I think one problem we have, though, with regards to remotely debugging the CloudStack Management Server over a VPN is that there are (I'm estimating here) like 500 threads for the IDE to collect info about. Perhaps there's a way in one of these IDEs to

Re: Slow remote debugging

2016-03-01 Thread Will Stevens
baaa, skip the IDE and just use jdb directly. haha... *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Tue, Mar 1, 2016 at 2:27 PM, Tutkowski, Mike wrote: >

[GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...

2016-03-01 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1425#issuecomment-190874260 @nvazquez I mean unit tests for each new method. I think that use the Builder to get an instance with all variables initialized is a good

[GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...

2016-03-01 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1425#issuecomment-190961759 @nvazquez and @pedro-martins, I am ok with the code now, expect the constructor bit. The question you should ask about the constructor is, is it

Build failed in Jenkins: build-master-slowbuild #3363

2016-03-01 Thread jenkins
See -- [...truncated 28689 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Build failed in Jenkins: build-master-slowbuild #3358

2016-03-01 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Important Pending Items

2016-03-01 Thread Will Stevens
Awesome, thanks Remi. I will review this. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Tue, Mar 1, 2016 at 4:29 PM, Remi Bergsma wrote: > Hi Will, > > We

Build failed in Jenkins: build-master-slowbuild #3362

2016-03-01 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Slow remote debugging

2016-03-01 Thread Tutkowski, Mike
Thanks for the info, Remi! Sent from my iPhone > On Mar 1, 2016, at 2:24 PM, Remi Bergsma wrote: > > IntelliJ is cool indeed. What’s even better, is that as an Apache committer > you get a free license ;-) > >

Re: Important Pending Items

2016-03-01 Thread Will Stevens
Thanks Paul. Great to hear you are planning to make everything available and you are willing to take contributions from the community. I am currently trying to get up to speed on everything that has been done and all the different pieces in play. I would like to have a CI in place (even if it

Re: Slow remote debugging

2016-03-01 Thread Will Stevens
Ya, in my experience IntelliJ is the best Java IDE. Glad you are sorted. :) *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Tue, Mar 1, 2016 at 3:41 PM, Tutkowski, Mike

Re: Slow remote debugging

2016-03-01 Thread Remi Bergsma
IntelliJ is cool indeed. What’s even better, is that as an Apache committer you get a free license ;-) https://www.jetbrains.com/shop/eform/apache?product=II Regards, Remi On 01/03/16 21:41, "Tutkowski, Mike" wrote: >​Wow, Rohit - IntelliJ is super fast

Re: Important Pending Items

2016-03-01 Thread Remi Bergsma
Hi Will, We used this to test hundreds of PRs: https://github.com/schubergphilis/MCT-shared/. I can talk you through it sometime next week or so if you want. Regards, Remi On 01/03/16 21:50, "williamstev...@gmail.com on behalf of Will Stevens"

Re: Slow remote debugging

2016-03-01 Thread Tutkowski, Mike
​Wow, Rohit - IntelliJ is super fast compared to Eclipse and NetBeans debugging over my VPN. It's actually not just usable, but fast. Thanks! From: Tutkowski, Mike Sent: Tuesday, March 1, 2016 12:27 PM To: dev@cloudstack.apache.org Subject: Re: Slow remote

Re: Important Pending Items

2016-03-01 Thread Sanjeev N
Hi Steve, Currently travis runs all simulator tests(marvin tests which does not require any hardware, tagged with requierd_hardware=false) on every PR. If any test fails it updates the PR and marks it red. IMO apart from 2 LGTMs travis test pass is also mandatory for PR merge. Thanks, Sanjeev N

Build failed in Jenkins: build-master-slowbuild #3365

2016-03-01 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Slow remote debugging

2016-03-01 Thread Rohit Yadav
Hi Mike, try IntelliJ you’ll be delighted. Cheers. > [ShapeBlue] Rohit Yadav Software Architect , ShapeBlue d: | s: +44 203 603 0540 | m: +91 8826230892 e:

Build failed in Jenkins: build-master-slowbuild #3359

2016-03-01 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-8745 : verify usage after root...

2016-03-01 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/713#issuecomment-191098254 sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: marvin functional test cases or junits for the api 'deployVirtualMachine' and 'resizeVolume'

2016-03-01 Thread Erik Weber
Are anyone able to help Prakash out with the testing? -- Erik On Mon, Feb 29, 2016 at 7:50 PM, B Prakash wrote: > I am looking for marvin functional test cases or junits for the api > 'deployVirtualMachine' and 'resizeVolume'. Please could someone share this > info? > >

Build failed in Jenkins: build-master-slowbuild #3361

2016-03-01 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Anyone Can Help

2016-03-01 Thread Simon Weller
Can you give us more info on the network design you tested this on, as well as the Cloudstack setup? I honestly don't know who in the community is utilizing this feature today. - Si From: Keerthiraja SJ Sent: Tuesday, March 1,

[GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...

2016-03-01 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1425#issuecomment-190753666 Hi @rafaelweingartner, Sure, I changed it to a method and added javadoc to it. I added the new constructor at ResourceTagJoinVO to set all that

Build failed in Jenkins: build-master-slowbuild #3360

2016-03-01 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-03-01 Thread pedro-martins
Github user pedro-martins commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1424#discussion_r54595010 --- Diff: server/src/com/cloud/template/TemplateManagerImpl.java --- @@ -275,6 +277,8 @@ private StorageCacheManager cacheMgr;

[GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...

2016-03-01 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1425#issuecomment-190791313 @nvazquez, nice changes. So, I guess that a test cases for these new methods will be important to detect future changes in these methods behavior.