Re: [PR] Improves service offering resource [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
vishesh92 merged PR #64: URL: https://github.com/apache/cloudstack-terraform-provider/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixup acceptance tests [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
vishesh92 commented on PR #96: URL: https://github.com/apache/cloudstack-terraform-provider/pull/96#issuecomment-1980998466 > ``` > === RUN TestAccCloudStackKubernetesVersion_basic > testing.go:568: Step 0 error: errors during apply: > > Error: CloudStack

Re: [PR] Bump github.com/go-ini/ini from 1.40.0 to 1.67.0 [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
rohityadavcloud commented on PR #94: URL: https://github.com/apache/cloudstack-terraform-provider/pull/94#issuecomment-1980984848 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add UEFI support [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
rohityadavcloud merged PR #83: URL: https://github.com/apache/cloudstack-terraform-provider/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.15.0 [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
rohityadavcloud closed pull request #93: Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.15.0 URL: https://github.com/apache/cloudstack-terraform-provider/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.15.0 [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
dependabot[bot] commented on PR #93: URL: https://github.com/apache/cloudstack-terraform-provider/pull/93#issuecomment-1980984141 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major

Re: [PR] Bump github.com/go-ini/ini from 1.40.0 to 1.67.0 [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
dependabot[bot] commented on PR #94: URL: https://github.com/apache/cloudstack-terraform-provider/pull/94#issuecomment-1980984984 Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot

Re: [PR] Fixup acceptance tests [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
rohityadavcloud commented on PR #96: URL: https://github.com/apache/cloudstack-terraform-provider/pull/96#issuecomment-1980982689 ``` === RUN TestAccCloudStackKubernetesVersion_basic testing.go:568: Step 0 error: errors during apply: Error: CloudStack API

Re: [PR] Bump github.com/hashicorp/go-multierror from 1.0.0 to 1.1.1 [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
rohityadavcloud merged PR #95: URL: https://github.com/apache/cloudstack-terraform-provider/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Allow connecting network ACL to a (VPC) network according API specs [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
vishesh92 commented on issue #28: URL: https://github.com/apache/cloudstack-terraform-provider/issues/28#issuecomment-1982725696 @synergiator `resource_cloudstack_network_acl` is actually a network ACL list. And resource_cloudstack_network_acl_rule is the network ACL. Network ACL requires

Re: [VOTE] next version 20 instead of 4.20

2024-03-06 Thread Daan Hoogland
I think we will (and have) changed APIs and dropped plugin support in major versions with at least a deprecation period. this is exactly the reason I now (finally) proposed we should drop the 4 and proceed with regarding the second number as the primary version. Semantic versioning is well defined

Re: [PR] Add UEFI support [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
vishesh92 commented on code in PR #83: URL: https://github.com/apache/cloudstack-terraform-provider/pull/83#discussion_r1514083157 ## cloudstack/resource_cloudstack_instance.go: ## @@ -277,6 +283,11 @@ func resourceCloudStackInstanceCreate(d *schema.ResourceData, meta

Re: [PR] Adds dependabot [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
rohityadavcloud merged PR #70: URL: https://github.com/apache/cloudstack-terraform-provider/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Add Override root disk offering and Disk Offerings to cloudstack_instance Resource [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
vishesh92 commented on issue #68: URL: https://github.com/apache/cloudstack-terraform-provider/issues/68#issuecomment-1980423213 Had a discussion with @kiranchavala. This requires go SDK to be upgraded. Changed the milestone to v0.6.0 -- This is an automated message from the Apache Git

[PR] Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.15.0 [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
dependabot[bot] opened a new pull request, #93: URL: https://github.com/apache/cloudstack-terraform-provider/pull/93 Bumps [github.com/apache/cloudstack-go/v2](https://github.com/apache/cloudstack-go) from 2.13.2 to 2.15.0. Release notes Sourced from

[PR] Bump github.com/go-ini/ini from 1.40.0 to 1.67.0 [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
dependabot[bot] opened a new pull request, #94: URL: https://github.com/apache/cloudstack-terraform-provider/pull/94 Bumps [github.com/go-ini/ini](https://github.com/go-ini/ini) from 1.40.0 to 1.67.0. Release notes Sourced from

[PR] Bump github.com/hashicorp/go-multierror from 1.0.0 to 1.1.1 [cloudstack-terraform-provider]

2024-03-06 Thread via GitHub
dependabot[bot] opened a new pull request, #95: URL: https://github.com/apache/cloudstack-terraform-provider/pull/95 Bumps [github.com/hashicorp/go-multierror](https://github.com/hashicorp/go-multierror) from 1.0.0 to 1.1.1. Commits

RE: [VOTE] next version 20 instead of 4.20

2024-03-06 Thread Paul Angus
That logic doesn't hold with what's proposed Taking your interpretation, after moving to 20.x.y we would then have to stay on 20.x.y until "incompatible API changes" happen. New features and updates would go into 20 . x+1 . y which only achieves removing the security fix dot releases

RE: [VOTE] next version 20 instead of 4.20

2024-03-06 Thread Giles Sirett
IMO - they are two different subjects. Everybody hopes that we'd never break API compatibility, but there may be a situation at some point in the future where it may be required and we fundamentally cant take a decision now that limits what the community may want to do in 10 years time.