Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
LGTM but
I hope you appreciate the concerns @marcaurele , on the other hand let's
fix what breaks and make sure the 4.9 to 4.10 works with this. We can always
advice to upgrade t
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
btw @marcaurele @rhtyd idempotent will only be possible if we encode it. It
is not encoded in older upgrades. Unless we clean those upgrades up we will
have some issues.
---
If your
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@karuturi I think this should go in. Even being a bit of a risk, it will
potentially reduce the support hours on upgrades.
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1944
seen it work in practice: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@syed the -cleanup scripts are for removing data that had been migrated,
not for temporary tables. also a use case for those may be if things are done
partly in the migrate script and
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@BlueOrangUtan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@BlueOrangUtan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103212914
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/EnableHAForClusterCmd.java
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103213259
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/EnableHAForZoneCmd.java ---
@@ -0,0 +1,115 @@
+// Licensed to the Apache Software
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103210828
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103207344
--- Diff: .travis.yml ---
@@ -42,13 +42,18 @@ env:
smoke/test_dynamicroles
smoke/test_global_settings
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103212736
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForZoneCmd.java ---
@@ -0,0 +1,115 @@
+// Licensed to the Apache
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@rhtyd I don't see how your concern is more true for the new code by
@marcaurele then it is true for old code. cleanup is still going to be executed
after the scripts, is it? only dir
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1768
[1768.network.results.txt](https://github.com/apache/cloudstack/files/805988/1768.network.results.txt)
[1768.vpc_routers.results.txt](https://github.com/apache/cloudstack/files/805989
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103221221
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
---
@@ -108,4 +108,8 @@ public void execute
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103221397
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
---
@@ -74,7 +74,7
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1960
I went through the code and found no real issues. for any other reviewers I
recommend reading the FS first. It is quit a big chunk but very neat.
LGTM
---
If your project is set
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1779
@priyankparihar I agree that host should not show as up but indeed why hide
it? Unless we show no details for an unmanaged cluster we should be able to
find the host in there. It should
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103872151
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
---
@@ -108,4 +108,8 @@ public void execute
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103890661
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1988
WIP: CLOUDSTACK-9815 intergration of ApplicationClusterService
this external plugin will be integrated as core plugin. It was originally
created as plugin on 4.5. bouncycaste needs
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1779
Looks good to me, @rhtyd are your concerns met?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@ustcweizhou of course. It is still work in progress but all changes needed
will be added in time.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
ping @rhtyd @swill @chiradeep @NuxRo @pdion891 @wido @karuturi
I rebased
please send me any pull requests on this if you feel extra is needed.
---
If your project is set up for it
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1995
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r105162233
--- Diff: packaging/centos63/cloud.spec ---
@@ -445,7 +445,7 @@ grep -s -q "db.usage.driver=jdbc:mysql"
"%{_sysconfdir}/%{name}/m
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan package centos7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan package centos7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/669
@rafaelweingartner good improvement. @anshul1886 can you merge Rafael's
stuff? He addresses the code doublure and the generic exception.
---
If your project is set up for it, you can
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
So this PR will be useless as is!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
@karuturi @wido @rhtyd @swill @pdion891 @rafaelweingartner
I see the system VMs pointed to are still those in the 4.6 directory on the
download servers. Is that really intended? I
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@blueorangutan test centos7 kvm-centos7
component/application_clusters/test_application_cluster_life_cycle.py,component/application_clusters/test_application_cluster_provisioning.py
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1988
@ustcweizhou @sebgoa @rhtyd can you review this as a first version of an
integrated plugin for application clusters. It is still very k8s specific and I
want to defer making it more
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
sorry @karuturi should I update? This is really not on my radar that much
anymore. I will look at it this afternoon.
---
If your project is set up for it, you can reply to this email and
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r106667548
--- Diff:
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
@Parameter(name
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
@karuturi I rebased on latest master, is anything else expected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r106675353
--- Diff:
api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java ---
@@ -75,6 +75,7 @@
@Parameter(name
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2003
code LGTM but @ustcweizhou 's patch still makes sense to me. Maybe you can
add that separately? travis still fails!
---
If your project is set up for it, you can reply to this emai
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
@karuturi the intent of this PR was never to change any of the templates,
only the locations. I see some changes in there that I think are the result of
the many rebasing this PR has
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2011
@ustcweizhou this enables looking for a nic by a name like a1b2c3
(\D+\d+\D*\d*\D*\d*) it will also allow all shorter as long as they start with
which makes sense. But to satisfy
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1582
@karuturi I hade a brief peek, #1982 does not have templates for lxc or
ovm3, so that at least is one problem.
I think it needs to be reverted and recreated, probably on top of this one
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2011
thanks @ustcweizhou
@karuturi can we merge this? and merge forward?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1980
LGTM (based on code only)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2023
LGTM
@kishankavala did you check what went wrong with the kvm template.
@karuturi reported that and it was probably some auto-conflict-resolution.
---
If your project is set up for it
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2022#discussion_r108918688
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ---
@@ -1477,6 +1493,40 @@ public static String
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2023
@karuturi I think it is easiest to just reapply and not search for the
cause of an 8 month old PR resulting in conflicts. (if the original code has
the right URLS in it)
---
If your
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1997
@jayapalu your check is ok, what is not ok is that it is needed. Somehow a
stop can be send to a VM for which no host is known?
I am worried about the reason of your fix and that we
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2024
trivial enough: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1997
so that is two situations
1. it is known to be powered off (no sendStop() should be performed at all)
2. it is unknown because their is no report. Wouldn't one first check the
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/2030
WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2032
LGTM, checked the source
$ grep -r 4.9.3.0
no hits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/2044
CLOUDSTACK-9877 Cleanup unlinked templates
This implements CLOUDSTACK-9877 by marking templates for gc when
1. the template they where created with is deleted from cloudstack
2
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/2030
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2030
renaming and close-opening for retests. "it works on my laptop (tm)"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/2030
WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2030
show me the money (tm)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568225
--- Diff: core/src/com/cloud/network/HAProxyConfigurator.java ---
@@ -538,7 +536,7 @@ private String getLbSubRuleForStickiness(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568831
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568764
--- Diff: api/src/org/apache/cloudstack/config/ApiServiceConfiguration.java
---
@@ -28,6 +28,8 @@
"API end point. Can be us
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r11156
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2044
@serg38
ad 1. yes they can, if you look in the ticket there is a part of
description that describes this possibility. But that said I don't see how
restore is going to be hinder
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2044
ah ok, I was not aware of that @serg38 . I'll look it up, except from not
enabling the feature, how would you handle this?
a. To not allow restore
b. To recognise that the di
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111591078
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/17#issuecomment-54707381
I merged it without closely reading the comment in #15. Does other logic
need to ported as well, Leo?
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/17#issuecomment-54790328
Leo, you are right but if it is in 4.3 not putting it in 4.4 would make it
a double behavioural change from a user perspective. So I will look at
cherry
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/22
Vpc refactor clean for pr
maybe wait with merging untill 4.5 is branched of. On the other hand we cn
branch below this refatoring as well
You can merge this pull request into a Git
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/22#issuecomment-59035961
two small conflicts with present master. Can you decide on them, Wilder?
On Mon, Oct 13, 2014 at 1:49 PM, Wilder Rodrigues
wrote:
> T
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/23
Merge 4.5 back into master
It would be good to have this as a daily practice
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/23#issuecomment-59348377
Seems like you are the RM for 4.6/master now Rohit, congratulations. I
suggest that you and @ke4qqq do a merge like this on a daily basis. Of course I
would like
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/69
CLOUDSTACK-8197 create MinVRVersion config item
move is complete. testing isn't and is invited as not all possible
use-cases are clear yet
You can merge this pull request into
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/69#issuecomment-72683816
travis failed due to timeout, is that usual on master these days?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/75#discussion_r24511453
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1622,6 +1630,23 @@ protected StringBuilder
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/82
mvn on buildslaves that don't have it in path
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack m
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/82#issuecomment-75069672
it does retrieve the version from the pom now but the build still fails on
rpm dependencies. feel free to merge.
---
If your project is set up for it, you can
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/83
test fails unexplicalby while functionality is ok
needs looking into but for now i want the jenkins jobs running
You can merge this pull request into a Git repository by running:
$ git
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/84
catch specific exception and log clear message on error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack hotfix
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/84#issuecomment-75370781
travis timeout again. will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/85#issuecomment-75445041
seems usefull, you feel it is ready for merge, Laszlo/@K0zka?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/87#issuecomment-75833513
I recognize the problem and did some code to implement it in the response
generation. might be this didn't make it to any release yet. Have a lo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/86#issuecomment-75929584
"Instance Scaled" doesn't seem like a very descriptive message. SHouldn't
we expand a little, like "instances scaled to requested size(s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/88#issuecomment-76213072
@ghxandsky : is this ready for merge?
@K0zka : Are you working together on this?
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/88#issuecomment-76397624
had reviewed, wanted to merge but was stopped by git ssl problems
On Fri, Feb 27, 2015 at 2:09 PM, Star Guo wrote:
> @bhaisaab <
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/89#issuecomment-76398427
LGTM, I would not trust a travis failure any more. Our simulator run has
really outgrown it. I would look at the
http://jenkins.buildacloud.org/view/simulator
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/87#issuecomment-77703465
I solved this privately and forgot to give back to the community. Please
consider this solution @bhaisaab . It seems to be custom for these
@transient-annotated
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/87#issuecomment-77741942
I don't mind. I'm just worried about the rammifications for the API design.
I stole my implementation from somewhere else. It must have once been
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/124
Feature/4.4/centos7
Got an internal request to package 4.4 for centos7, hence...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/124#issuecomment-85097429
against wrong branch :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/125
4.4 for centos7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack feature/4.4/centos7
Alternatively you can
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/126
remove stale project cloud-systemvm
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack
hotfix/remove-dead-sysvm
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/125#issuecomment-85235970
H Laszlo, i noticed and updated the pull request for the jasypt version.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/126#issuecomment-85479293
good point, will have to check that, thanks
On Tue, Mar 24, 2015 at 12:22 PM, Rohit Yadav
wrote:
> @DaanHoogland <https://gith
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/commit/b527aabfc352474541a2f6c7831b819356ec453a#commitcomment-10372774
@ghxandsky we use this in production, I think we use only the agent for KVM
but still. If people run into problems we&#x
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/128#issuecomment-86147021
I think the typo is in the commit message, unless these are really supposed
to be related.
---
If your project is set up for it, you can reply to this email
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/131
findbugs: Boolen function should not return null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack
hotfix
1 - 100 of 1880 matches
Mail list logo
