Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1922
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/1964
Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mode. Added corresponding
changes in UI
NetScaler can work in inline mode also along with other Firewall devices.
Enabled netscaler
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/843
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1824#discussion_r101981147
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -232,28 +233,50 @@ def deleteFile(session, args):
return txt
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1824
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1883
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1886
Tested manually. Did not see any issues with long list of IPs.
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1866#discussion_r103861408
--- Diff:
tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh ---
@@ -67,6 +67,8 @@ function install_packages
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1866#discussion_r103861501
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade4920to41000.java
---
@@ -53,6 +55,7 @@ public boolean supportsRollingUpgrade
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/859
@DaanHoogland cloudmonger failures are not related to this PR. Changes in
this PR are related to usage server only.
---
If your project is set up for it, you can reply to this email and
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/1982
CLOUDSTACK-9807/CLOUDSTACK-9808 - Added upgrade changes for 4.10 system vm
template
Removed systemvm template upgrade code in 4.6 upgrade. Added 4.10 system vm
template upgrade changes
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1982
@karuturi updated template URLs and md5sum
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1993
Changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/2023
BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path for LXC and OVM
`mysql> select id,unique_name,name,type,url,updated,created from
vm_template where type=
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1996#discussion_r109835294
--- Diff: server/src/com/cloud/user/AccountManager.java ---
@@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s
public
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1917
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/874
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/163#discussion_r28395781
--- Diff: plugins/hypervisors/kvm/pom.xml ---
@@ -45,7 +38,7 @@
${project.version}
- org.libvirt
Github user kishankavala closed the pull request at:
https://github.com/apache/cloudstack/pull/577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/1244
Bug-ID: CLOUDSTACK-8654: Added guest_os mappings for CoreOS
Tested CoreOS Vm deploy in Xenserver, KVM and VMware hypervisors
Tested upgrade with new guest OS mappings
You can merge
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-181715514
@nvazquez
Apologies for reviewing it late.
1. Since version is fetched from image_store_details, can we send a map
with all details for the image_store
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-181771585
One more query:
How is the nfs.version set in image_store_details table?
---
If your project is set up for it, you can reply to this email and have your
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-185176731
@nvazquez
Can you please repond to my earlier question also.
>> How is the nfs.version set in image_store_details table?
---
If your project is
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/185#issuecomment-95800447
@svscorp Commit looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101917044
---
Test set: com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101918061
@wilderrodrigues Sorry, I could not test the PR earlier. I see the
following issues while trying to bring up my KVM setup:
1. LibvirtUtilitiesHelper NPE
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/374
CLOUDSTACK-5409: Include projectid during ACL check while listing S2S Vpn
gateways
ACL check is failing when listing S2S vpn gateway withn a project. Added
missing projectId in ACL check
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/920#issuecomment-147944007
@runseb @pvr9711 @sanjeevneelarapu
Can we include all regression simulator tests also?
---
If your project is set up for it, you can reply to this email
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/924#issuecomment-147945829
@remibergsma We not have any tests that will check for correct events on
account delete.
@nnesic Would you be able to add one?
---
If your project is set
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/920#issuecomment-147947974
@sanjeevneelarapu
1. We should look at ways to improve the simulator to run faster.
2. We have PRs open for more than a day in most cases. I would
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163492909
@ustcweizhou Changes look good to me. But I could not actually test them,
patch doesn't apply on latest master
---
If your project is set up for it, yo
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163538722
You are right @ustcweizhou . My branch was not up to date. Applied the
patch on latest master.
- Able to see vpcname and vpcid in listRouters response
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/557
BUG-ID:CLOUDSTACK-7472: kvmclock fix for LXC is not required after fixing
CLOUDSTACK-8177
kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177
You can merge this pull request
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/334#issuecomment-118248786
There is an API change. Should this go into master only?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/552#issuecomment-119812602
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/568#issuecomment-119917422
Looks good to me.
Commented on older PR earlier.
PR https://github.com/apache/cloudstack/pull/552 can be removed
---
If your project is set up for it
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/571#issuecomment-120222980
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/577
CLOUDSTACK-8605: KVM: Config Drive and getVmIp support
- CLOUDSTACK-8324 added support for External DHCP/DNS support along with
ConfigDrive for XenServer
- FS link:
https
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/576#issuecomment-120400649
Can we rephrase it as "Expected 1 VDI template but found..."
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/577#issuecomment-121645521
/var/lib/libvirt/images is used for local storage also.
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource#configure
_localStoragePath
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-122189103
LGTM.
Yes some tests would be good to validate expunge/recover behavior when the
config is set to true/false for an account
---
If your project is set up
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/577#issuecomment-122219752
@wido @bhaisaab Made the suggested changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-123699898
@DaanHoogland double URL decoding was added during registerSSHKeyPair
refactor. commit 968e71ad0e49088b5f2f022df29aec02b10a5ede
Can you please check if this
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/611#issuecomment-123703777
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35290636
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -368,8 +368,14 @@ private boolean setup
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/586#issuecomment-123971770
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-124323020
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/620#issuecomment-124323473
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/622#issuecomment-124481535
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-125136388
LGTM. @bhaisaab can you also take a look at the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/627
CLOUDSTACK-8668: VR type in shared network is dhcpsrvr. Ips are being
removed due to this issue
- VR IP config is loaded from /var/cache/cloud/cmdline
- For shared network VR type is
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125571871
Thanks @wilderrodrigues for merging.
Ran into another blocker after VR came up:
https://issues.apache.org/jira/browse/CLOUDSTACK-8683
---
If your project
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125580306
Yes @wilderrodrigues "VR started successfully ". But port 3922 is not open.
Once I add iptables rule to allow 3922, MS is able to program rules.
I
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125846995
Hi @wilderrodrigues
Please look into CLOUDSTACK-8683 when possible
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125864299
@wilderrodrigues
Below changes fixed the issue but not sure if it breaks anything else:
kk-cloudstack > git diff
diff --git a/systemvm/patc
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125882216
Sure @wilderrodrigues
I'll create a PR.
But iptables rules are more open now (default ACCEPT).
root@r-30-VM:~# iptables -L INPUT -nv
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/634
CLOUDSTACK-8683: process cmd_line.json for shared network VR in
cloud-early-config
- SSH access on link_local_ip is blocked for shared VR
- MS is unable to program rules on VR. Vm
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125890106
@wilderrodrigues iptables issue is not specific to dhcpsrvr (shared VR). On
isolated VR also default policy is ACCEPT
```
root@r-23-VM:~# iptables -L
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125915281
Thanks @wilderrodrigues
I merged https://github.com/apache/cloudstack/pull/634/
I'll created separate ticket to track "default policy ACC
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-126186427
Hi @wilderrodrigues,
@sanjeevneelarapu filed ticket for "default policy ACCEPT" issue.
https://issues.apache.org/jira/browse/CLOUDSTACK-8688
-
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126205414
@DaanHoogland
Agreed that setting appropriate log level is out of the scope for this PR.
But we should file a jira ticket to track and address it before
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/635#discussion_r35849002
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
---
@@ -60,6 +61,15 @@
description
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/635#discussion_r35862098
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
---
@@ -60,6 +61,15 @@
description
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/636#issuecomment-126288404
@sspans
Since Test case is updated to cover VXLAN also, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35948897
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -398,3 +398,5 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-127560212
@karuturi This issue exists in releases > 4.5.0
Shouldn't this be fixed in 4.5.0, 4.5.1 and merged forward as per the new
release process?
O
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/655#issuecomment-127855771
@jayapalu
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128227678
@remibergsma
Agreed. In this case fix will go into 4.5.2 and 4.6
Updated fixVersion accordingly
---
If your project is set up for it, you can reply to
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36381969
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -242,16 +242,19 @@ public void scheduleRestartForVmsOnHost(final HostVO
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/657#issuecomment-128306138
LGTM if 4.5.2 is released before 4.6.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/663#issuecomment-128666248
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-130282420
@kansal Can you add a similar check for duplicates keys in the
createSSHKeyPair API validation?
---
If your project is set up for it, you can reply to this
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/577#issuecomment-132073136
Updated code to use local.storage.path config instead of hard-coded
/var/lib/libvirt/images/. Local Storage pool is also created using same config.
Removed
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/577#issuecomment-132073238
@remibergsma I've update the PR. There is still one issue open regarding
the usage of /tmp
---
If your project is set up for it, you can reply to this
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-133283527
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/731#issuecomment-134636230
@remibergsma changes looks fine. I would like to test it and get back to
you, hopefully by tomorrow.
---
If your project is set up for it, you can reply to
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/784#issuecomment-139513737
After applying patch, was able to create VPC successfully.
LGTM.
Sub-process optimization is good to have. This PR will unblock the VPC
creation
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/846
Bug-ID: CLOUDSTACK-8870: Skip external device usage collection if no
external devices exist
external network device usage monitor thread that runs every 5mins by
default (based on global
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/847
Bug-ID: CLOUDSTACK-8880: calculate free memory on host before deploying Vm.
free memory = total memory - (all vm memory)
With memory over-provisioning set to 1, when mgmt server starts
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/859
Bug-ID: CLOUDSTACK-8882: calculate network offering usage per nic instead
of per network offering
Issues occurs when:
A Vm is created with mutiple nics:
If 2 networks use same
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/842#issuecomment-142185868
LGTM
integration.smoke.test_vm_life_cycle test case validates ssh access to Vm
as part of test_10_attachAndDetach_iso test
Would be better
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-220935383
@swill rebased with latest master
@GabrielBrascher fixed the typo
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r64195431
--- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ---
@@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@pdube though the fix looks good, the root of the issue is different.
Earlier when bash scripts were used to configure rules on VR, iptable rules
for ACLs were inserted (-I option
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@swill This is a regression caused by VR refactor. There could be more such
issues. I would prefer a fix in the VR script. Current fix is more like
reversing the order twice to make it
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@leprechau ACL rule ordering was introduced in 2013 in ACS 4.2. Since 4.2
release, the order was never changed.
Older commit your are referring to, was during development phase of 4.2
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@pdube Current fix is good enough. I'm only concerned about more such
issues in VR.
can you please create a tracking bug for VR fix and make a note that this
is a regression?
-
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/780#discussion_r56311601
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3332,7 +3332,14 @@ public
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/780#issuecomment-197262533
Tested Manually. memorykbs, memoryintfreekbs,memorytargetkbs are listed
correctly.
LGTM.
`1a574e9d1-8057-4195-a8b3-2117e9059652VM-a574e9d1
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-197768091
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/780#issuecomment-199222784
@swill @remibergsma @DaanHoogland PR was open since Sep 2015. Review from
@swill came after the PR was merged on Mar 17 2016. By then, there were code
reviews
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1357#issuecomment-200185858
@DaanHoogland
Failed tests are the ones which we should be looking at.
integration.smoke.test_privategw_acl.TestPrivateGwACL is the only failed test
in
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-212842771
@kansal
LGTM. See if you can add an integration test.
Actual response from traffic sentinel resource in the logs will also help.
---
If your
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1939
LGTM
API response:
admin
8c91c04e-f282-11e6-8a09-d4ae52cb9a54
8c91ab6a-f282-11e6-8a09-d4ae52cb9a54
ROOT
a6401f5b-b090-4a64-9d73-c04369d15ca8
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/859
@DaanHoogland , Test creates two UsageNetworkOfferings, both with same
network offering but different nicIds. Test case is verified by checking that 2
usage records are created instead of
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/847
@borisroman moved free memory calculation to separate method
@rhtyd rebased fix with latest master
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/847
@rhtyd Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1379
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1824#discussion_r101981007
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -232,28 +233,50 @@ def deleteFile(session, args):
return txt
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Code looks good.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
100 matches
Mail list logo
