[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....

2016-06-05 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1531 @rhtyd Maybe we can replace all this with a Packer build? I already did that for Cosmic and I think it's at least 90% the same so it should be fairly easy. As a matter of fact, we use Cosmic

[GitHub] cloudstack-www issue #27: downloads: update page for security releases

2016-06-09 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack-www/pull/27 Thanks @runseb will do that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack-www pull request #27: downloads: update page for security release...

2016-06-09 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack-www/pull/27 downloads: update page for security releases /cc @pdion891 @DaanHoogland @wido @karuturi @runseb @swill and others You can merge this pull request into a Git repository by running

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1584 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1584 @nvazquez I've tested and with this fix unable to reproduce your issue, can you help review and test this PR? Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...

2016-06-07 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1531#discussion_r66175607 --- Diff: tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh --- @@ -19,7 +19,7 @@ set -e set -x

[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....

2016-06-07 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1531 Alright, I've fixed the debian version without changing systemvmtemplate version. @remibergsma we can get this merged for the time being, and let's have your packer stuff - that looks

[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...

2016-06-07 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1531#discussion_r66175640 --- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb --- @@ -27,15 +27,15 @@ architectures = { :i386

[GitHub] cloudstack pull request #1584: CLOUDSTACK-9409: Add role_id to cloud_usage.a...

2016-06-07 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1584 CLOUDSTACK-9409: Add role_id to cloud_usage.account Adds role_id column to cloud_usage.account, fixes UsageDaoImpl to insert Accounts with role_id from account table. This fixes

[GitHub] cloudstack pull request:

2016-05-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/commit/8af677a0f0b2a74db74223fc3d0e2d3e9549e960#commitcomment-17655645 In pom.xml: In pom.xml on line 91: @pdion891 @swill get it here: https://github.com/rhtyd/cloudstack-nonoss

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2016-06-13 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1582 @DaanHoogland I did not test it, but LGTM. As a project we can also publish a sql file or python script that would update the links (systemvm and default templates) in the db of existing

[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....

2016-06-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1531 @remibergsma sounds good to me, would you like to send a PR; port your work to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request #1588: packaging: remove openjdk install deps on clo...

2016-06-09 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1588: packaging: remove openjdk install deps on clo...

2016-06-09 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1588 packaging: remove openjdk install deps on cloudstack-agent - Removes openjdk as installation requirement, for oracle jre users we don't need that - Adds oracle JDK home (default) paths

[GitHub] cloudstack pull request: travis: use ipmitool from ubuntu reposito...

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1570#issuecomment-222416264 @swill can you merge this, as it would fix the ipmitool issue. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request:

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/commit/8af677a0f0b2a74db74223fc3d0e2d3e9549e960#commitcomment-17662189 In pom.xml: In pom.xml on line 91: @pdion891 I think it's a grey area on where to host the noredist jars, also I don't

[GitHub] cloudstack pull request: fix noredist build because of missing mav...

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1569#issuecomment-222354088 @swill there is a ipmitool pkg that needs to be installed before each run. I'll send a PR for a workaround. The packages.shapeblue.com repository is down, which

[GitHub] cloudstack pull request: fix noredist build because of missing mav...

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1569#issuecomment-222354130 @pdion891 usually, I clone this repo: https://github.com/rhtyd/cloudstack-nonoss and execute the install-non-oss.sh script in that repo: https://github.com/rhtyd

[GitHub] cloudstack pull request:

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/commit/8af677a0f0b2a74db74223fc3d0e2d3e9549e960#commitcomment-17659126 In pom.xml: In pom.xml on line 91: Since noredist required additional jars, recommended approach is to git clone

[GitHub] cloudstack pull request: travis: use ipmitool from ubuntu reposito...

2016-05-29 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1570 travis: use ipmitool from ubuntu repository @swill @pdion891 please review, merge this once Travis is green. The packages.shapeblue.com server is unreachable which is causing a wget command

[GitHub] cloudstack pull request: fix noredist build because of missing mav...

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1569#issuecomment-222354132 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Dockerfile4.9

2016-05-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1435#discussion_r65123586 --- Diff: tools/docker/Dockerfile.centos6 --- @@ -18,14 +18,16 @@ FROM centos:6 MAINTAINER "Apache CloudStack" <dev@cloudsta

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-26 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1511 4.9/master bountycastle changes This PR adds bountycastle related version and code fixes from @DaanHoogland on top of https://github.com/apache/cloudstack/pull/1510 I could not fix

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-26 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65159038 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65159171 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65158988 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1574#issuecomment-222653613 In general, LGTM though it's up to general community acceptance. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #1595: ui: show resize volume button to all users

2016-06-23 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1595 ui: show resize volume button to all users ![screenshot from 2016-06-23 12-29-56](https://cloud.githubusercontent.com/assets/95203/16294438/436f6dbc-393e-11e6-91b5-cb2e49a01cc6.png

[GitHub] cloudstack issue #1595: ui: show resize volume button to all users

2016-06-25 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1595 Thanks @remibergsma /cc @swill ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1549: CLOUDSTACK-9348: NioConnection improvements

2016-06-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1549 @swill may I have the mgmt server and agent logs when the failures were intercepted. This is to make sure it's not your environment specific issue. I'll also need the JRE version in use (openjdk

[GitHub] cloudstack pull request #1549: CLOUDSTACK-9348: NioConnection improvements

2016-06-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1549#discussion_r68709839 --- Diff: utils/src/main/java/com/cloud/utils/nio/NioConnection.java --- @@ -125,7 +125,7 @@ public boolean isStartup() { public Boolean call

[GitHub] cloudstack issue #1599: Independent marvin

2016-06-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 /cc @swill @jburwell @abhinandanprateek @murali-reddy @DaanHoogland @wido --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1599: Independent marvin

2016-06-28 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1599 Independent marvin The aim is to make marvin independent of CloudStack. I had started this work few months ago, but recently resumed it after working on Trillian. - The aim is to show

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213618402 @DaanHoogland additional notes on how tests work; we've introduce a new dependency `ipmisim` that I wrote for this feature, ipmisim is both a tool and a library

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213617967 @DaanHoogland thanks, in your test environment you'll need to install ipmitool (yum/apt-get) and the oobm tests would pass. These tests are also run by Travis

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214430311 > @rhtyd My comment regarding the test was more in the context of perf. test. In the DB for regular user I saw ~250 permissions got created. So this means iterat

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-214432357 @swill done, though as I mentioned in the comments above the test that failed in last travis run is a component test and fails on master too (i.e. not related

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60938011 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,167 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60937993 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,167 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60944411 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,478 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2016-04-28 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-215392929 @wido that is true, so will simply fixing the imports and usage work? I found using `git grep MySQLdb`: ``` client/bindir/cloud-update-xenserver

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-215675646 @swill can you try again with your CI? @agneya2001 @jburwell @wido @kiwiflyer @nvazquez @DaanHoogland and others - please review and share your LGTM, thanks

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-215170748 @swill yes that was a good to have suggestion; keep large string based test data separated from test, though since this request is cosmetic in nature I'm okay if we

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-215165382 @mlsorensen - presently, setting bitmask to 0 in commands.properties does not disable the API but that no roles would have that API; though if an API through its

[GitHub] cloudstack pull request: Kvm plugin restructure

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1521#issuecomment-215191105 @DaanHoogland I'm not sure about others, but gradle has become most popular and widely-support in modern java development @jburwell agree, the discussion here

[GitHub] cloudstack pull request: Kvm plugin restructure

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1521#issuecomment-215172757 In my experience when you are doing a lot of backporting or forward-porting work, if a plugin/module has got its filesystem structure (for example, due to moving

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-215197356 Rebased against latest master, please consider this for merge Performed final rounds of testing: - Build/maven, unit and integration tests - Upgrade

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-215217268 @wido I tested your original PR and the current updated PR, the locking never happened on my test env (Ubuntu x64). I read the manpage, and found that when

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-214992687 @DaanHoogland @wido @jburwell review/lgtm please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9283: add pid to java argument...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1409#issuecomment-214994528 @swill agree --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-214995585 @DaanHoogland yes that or something similar so test data can be separate to its own file --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-26 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214723830 > @rhtyd The current way you have implemented it using global config is confusing. Especially when you say that simply disabling the flag won't fall b

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-215015234 @wido thanks, can you comment on how an acquired lock is released or it's not critical to release the lock at all? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

2016-04-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-215024033 Thanks @koushik-das CI will be able to test it though as cloudstack-setup-database deploys 4.0 schema and ACS mgmt server upgrades it or DatabaseUpgrader runs

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214212648 @koushik-das this is part of the feature to be able to check access based on rules in DB and be consistent across all mgmt servers. In my local environment

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880204 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880231 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881499 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60882026 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java --- @@ -119,6 +131,9 @@ private Long

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60885329 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60885367 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214240215 I've fixed all outstanding issues, please comment if you see any outstanding issue. LGTMs welcome, thanks. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880846 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880213 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880195 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880160 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881018 --- Diff: server/src/org/apache/cloudstack/acl/RoleManagerImpl.java --- @@ -0,0 +1,273 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881906 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java --- @@ -70,10 +72,12

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214229683 I found this article by Oracle MySQL team useful: https://www.digitalocean.com/community/tutorials/how-to-prepare-for-your-mysql-5-7-upgrade --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60879938 --- Diff: utils/src/main/java/com/cloud/utils/PropertiesUtil.java --- @@ -34,6 +34,10 @@ public class PropertiesUtil { private static final

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

2016-04-25 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1517 engine/schema: fix upgrade path to work with MySQL 5.7 Found this issue when using MySQL 5.7 with Ubuntu 16.04. The upgrade path fix removes an invalid `IGNORE` param that is deprecated now

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214233279 @wido thanks for the comments. It seemed easier to pass the arguments to the oobm subsystem, there is a immutable map of option,string being returned this is why all

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214257913 Marvin Init Successful === TestName: test_oobm_background_powerstate_sync | Status : SUCCESS === === TestName: test_oobm_change_password

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-9299: doc for out-o...

2016-04-25 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/38 CLOUDSTACK-9299: doc for out-of-band management Admin documentation for out-of-band management feature cc @pdion891 @swill You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60890271 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60890292 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214249307 @DaanHoogland thanks, if we can migrate to Java8 I won't mind not fixing the issue for 1.7 at all --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-214252922 All tests passes, except for a test that runs only on simulator that sometimes passes, sometimes fails. This issue is due to master and not specific to this PR

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r60898417 --- Diff: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh --- @@ -71,7 +71,7 @@ function install_packages() { iptables

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-215815079 thanks @kiwiflyer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-28 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-215501683 @swill existing users won't be automatically migrated to use this feature, see the admin-doc PR that documents the upgrade/migrate procedure; though new

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2016-04-28 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-215502330 @swill for the CI you can install using pip with: (this is also in tools/travis/install.sh) pip install --upgrade --egg http://cdn.mysql.com/Downloads/Connector

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-26 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214636312 Thank you @DaanHoogland @pyr @wido for the review @swill I think we've enough votes for this one, though le'ts wait for @borisstoyanov 's test results which

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-26 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214637482 >@rhtyd maybe in a follow-up; can we split the test in hardware required true and false? @DaanHoogland for this feature's integration test, we don't n

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

2016-04-26 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-214855374 @wido in general alright, I've left few comments that can help us improve this For master, looks like we'll need to build/publish a new 4.9+ a systemvm template

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

2016-04-26 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-214856702 @nvazquez I'm not sure, can you try to reproduce and fix it locally; test with MySQL 5.6 and 5.5 (both major versions) --- If your project is set up for it, you can

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

2016-04-26 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1408#discussion_r61146381 --- Diff: scripts/vm/network/security_group.py --- @@ -1029,6 +1046,14 @@ def addFWFramework(brname): sys.exit(1) cmd = args[0

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

2016-04-26 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1408#discussion_r61146384 --- Diff: scripts/vm/network/security_group.py --- @@ -36,6 +39,20 @@ hyper = cfo.getEntry("hypervisor.type") if hyper == "lxc&qu

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-04-26 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-214858450 LGTM, though it would be great if @DaanHoogland can move part of the test string from the Test to an xml file under resources --- If your project is set up

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

2016-04-26 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1517#discussion_r61145609 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java --- @@ -1297,7 +1297,7 @@ private void addHostDetailsIndex(Connection conn

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-26 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214858085 @swill @pdion891 thanks, I don't know of any format or wiki/document where we keep this thing. Each feature/marvin-test may require test specific environment so I'm

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214617500 @jburwell I've not tested, but if it is using/enforcing SQL99 it should fail too (or it could be mysql 5.7.4+ issue); "As of MySQL 5.7.4, the IGNORE c

[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1510#issuecomment-214620580 @swill thanks, this can be merged first as we wait for bountycastle related changes to work with openjdk 1.7.0_95+ --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214276787 @koushik-das Yes, all tests run as a regular user too. See the integration test, we're using user api clients (search self.getUserApiClient) to perform tests -- i.e

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r60899950 --- Diff: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh --- @@ -71,7 +71,7 @@ function install_packages() { iptables

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214281121 @koushik-das can you share what you think are the advantages of static role-base api checker? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220533786 @swill the error suggests the template response is missing the key 'status' in its json response. It may happen if there has been any change around template

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220675652 Thanks @swill if we keep getting this error, I'll try to find some time to see what's causing this as well --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-220675720 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

  1   2   3   4   5   6   7   8   9   10   >