Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

ay, March 23, 2018 6:54:55 PM To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs Thanks all for your feedback. Since it's been positive so far, I'll start a vote on Monday to formalize this. In the meanwhile, please keep

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

: Syed Ahmed <sah...@cloudops.com> Sent: Thursday, March 22, 2018 12:51:01 AM To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org Subject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs +1 To Rohit’s suggestion On Wed, Mar 21, 2018 at 11:35 AM Khosrow Moossavi <kmooss.

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

> > - Rohit > > > > > > <https://cloudstack.apache.org> > > > > > > > > > > > > > > > From: Rafael Weingärtner <rafaelweingart...@gmail.com> > > > Sent: Tuesday, March 20, 2018 11:46:32 PM

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

gt; > > > <https://cloudstack.apache.org> > > > > > > > > ____ > > From: Rafael Weingärtner <rafaelweingart...@gmail.com> > > Sent: Tuesday, March 20, 2018 11:46:32 PM > > To: dev > > Cc: us...@cloud

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

aelweingart...@gmail.com> > Sent: Tuesday, March 20, 2018 11:46:32 PM > To: dev > Cc: us...@cloudstack.apache.org > Subject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs > > It looks like you have done all of the homework here. If it comes to a > vote, I am +

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

org> From: Rafael Weingärtner <rafaelweingart...@gmail.com> Sent: Tuesday, March 20, 2018 11:46:32 PM To: dev Cc: us...@cloudstack.apache.org Subject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs It looks like you have done all of the homework here. If it comes to a v

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

around contribution, and > fix the CONTRIBUTING.md in the repository, and update the release process > and related articles on cwiki. > Thoughts, feedback? Thanks. > - Rohit > > <https://cloudstack.apache.org> > > > > > &

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

ck.apache.org> rohit.ya...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue From: Rohit Yadav Sent: Tuesday, March 13, 2018 2:27:29 PM To: dev@cloudstack.apache.org Subject: [DISCUSS] Relax strict requirement of JIRA ID for PRs All, To make it e

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

che.org <mailto:dev@cloudstack.apache.org>> Subject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs Let me add to the below that I do think a ticketing system is a big help for keeping track of *un*implemented changes and *un*fixed bugs

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

t;> >> paul.an...@shapeblue.com >> www.shapeblue.com >> 53 Chandos Place, Covent Garden, London WC2N 4HSUK >> @shapeblue >> >> >> -Original Message- >> From: Daan Hoogland <daan.hoogl...@gmail.com> >> Sent: 14 March 2018 10:05

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

Daan Hoogland <daan.hoogl...@gmail.com> Sent: 14 March 2018 10:05 To: dev <dev@cloudstack.apache.org> Subject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs Let me add to the below that I do think a ticketing system is a big help for keeping track of *un*implemented chang

RE: [DISCUSS] Relax strict requirement of JIRA ID for PRs

lace, Covent Garden, London WC2N 4HSUK @shapeblue -Original Message- From: Daan Hoogland <daan.hoogl...@gmail.com> Sent: 14 March 2018 10:05 To: dev <dev@cloudstack.apache.org> Subject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs Let me add to the below

RE: [DISCUSS] Relax strict requirement of JIRA ID for PRs

@shapeblue -Original Message- From: Daan Hoogland <daan.hoogl...@gmail.com> Sent: 14 March 2018 10:05 To: dev <dev@cloudstack.apache.org> Subject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs Let me add to the below that I do think a ticketing system i

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

ubject: Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs Let me add to the below that I do think a ticketing system is a big help for keeping track of *un*implemented changes and *un*fixed bugs. On Wed, Mar 14, 2018 at 11:04 AM, Daan Hoogland <daan.hoogl...@gmail.com> wrote: >

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

Let me add to the below that I do think a ticketing system is a big help for keeping track of *un*implemented changes and *un*fixed bugs. On Wed, Mar 14, 2018 at 11:04 AM, Daan Hoogland wrote: > Boris, I hate to be strongly opinionated but I have to violently disagree >

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

Boris, I hate to be strongly opinionated but I have to violently disagree with you on some things here; On Wed, Mar 14, 2018 at 9:48 AM, Boris Stoyanov < boris.stoya...@shapeblue.com> wrote: > Hi all, > > I do understand your point as developers if you want to fix something just > open the PR

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

Hi all, I do understand your point as developers if you want to fix something just open the PR and not deal with any extra details like JIRA tickets and etc, but I must say that JIRA tickets are quite often looked up from users as they experience an issue. Let’s say we’ve fixed an annoying UI

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

I'm completely +1 on using GH as source of truth, both PR and issue wise, with Daan comment regarding Apache rules in mind. At least it doesn't need to have "yet another" integration to do automated actions on an issue (such as auto close an issue by "Fixes NUMBER", "Closes NUMBER") directly from

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

To add another $0.02 to this conversation, beyond what I posted above. Ideally, in my humble opinion, we would use Github Issues for issues that do not currently have code associated with it. Jira is currently being used for this and it is useful for users to be able to flag bugs without knowing

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

I agree with the relaxation as Rohit pointed out. At this point we should ask if Jira is really needed. Most people here I believe agree that it is not. The only reason we have Jira is to track releases. This could easily be replicated in GitHub as I see that GitHub is the place where we all

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

I was checking and for some reason ACS does not have an issue tab ( https://github.com/apache/cloudstack/issues). It might be some configuration in the repository. On Tue, Mar 13, 2018 at 10:54 AM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > What do you mean by issue? PR or issue

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

What do you mean by issue? PR or issue (Github issue)? On Tue, Mar 13, 2018 at 10:53 AM, Daan Hoogland wrote: > right, also when an issue is created? > > > On Tue, Mar 13, 2018 at 2:50 PM, Rafael Weingärtner < > rafaelweingart...@gmail.com> wrote: > > > We already have.

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

right, also when an issue is created? On Tue, Mar 13, 2018 at 2:50 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > We already have. All messages on ACS' GH go to commits@c.a.o > > On Tue, Mar 13, 2018 at 10:49 AM, Daan Hoogland > wrote: > > > Ok, one

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

We already have. All messages on ACS' GH go to commits@c.a.o On Tue, Mar 13, 2018 at 10:49 AM, Daan Hoogland wrote: > Ok, one issue there is Apache foundation rules. If we copy every thing into > jira or the mail list we are fine, where ever we have our discussions. The

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

Ok, one issue there is Apache foundation rules. If we copy every thing into jira or the mail list we are fine, where ever we have our discussions. The only thing is that we need a Apache hosted record. (as in not github) On Tue, Mar 13, 2018 at 2:09 PM, Rafael Weingärtner <

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

I prefer the workflow in Github as you guy, but to be fair with Jira ticket system I mentioned it. @Marc, yes Jira can facilitate a lot the management. However, we do not use it fully. In our workflow, there is no planning/roadmap for the next release per se. Things seem to work in an ad-hoc

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

@rafael, you said: they all required Jira tickets to track the discussion and facilitate the management I can see the discussion happening in the PR on github, but the Jira ticket by itself doesn't do much, except copy/pasting the github discussion. Then it's down to "facilitate the management",

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

Will, you are speaking my mind; any external registration tool should be based on the source. The only reason for having an external tool without relation to the code is to keep track of what is *not* (or not fully) implemented. On Tue, Mar 13, 2018 at 12:58 PM, Rafael Weingärtner <

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

I meant a way of describing them (changes/proposals) further. Sometimes we have commits only with title, and then the Jira ticket would be a way of documenting that commit. I do prefer the idea of inserting the whole description in the commit body though. [for me] it looks easier to work directly

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

I am +1 to relaxing the requirement of Jira ticket. Rafael, what do you mean when you say "Jira tickets are used to register changes"? I think ever since 4.9 the actual PRs included in the code are the source of truth for the changes in the actual code (at least from a release notes

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

Marc, yes Jira tickets are used to register changes. However, what Rohit and others (including me) are noticing is that there are certain types of changes (minor/bureaucracy) that do not require Jira tickets. The issue is the wording “change”. What consist of a change that is worth mentioning in

Re: [DISCUSS] Relax strict requirement of JIRA ID for PRs

That's a good idea, because people are more and more used to only create PR on github, and it would be helpful to be more explanatory on the way we work to push changes. I still think we should encourage the use of the github milestone as Rohit did with the 4.11.0 (

[DISCUSS] Relax strict requirement of JIRA ID for PRs

All, To make it easier for people to contribute changes and encourage PR/contributions, should we relax the requirement of a JIRA ticket for pull requests that solve trivial/minor issues such as doc bugs, build fixes etc? A JIRA ticket may still be necessary for new features and non-trivial