Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Thank you all for helping us in merging this PR, much appreciated !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell @murali-reddy I'll work on the Travis issue separately, this is
an intermittent issue with Travis/simulator. The only failing test is
`test_create_volume_under_domain` in
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@murali-reddy @rhtyd is there an ETA on the
`test_create_volume_under_domain` fix? The current Travis build is failing on
the following test cases:
* `test_volumes`
*
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd can we merge in ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Volumes test (test_create_volume_under_domain) is only failure ; unrelated
to this PR
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1579
code changes LGTM
Travis run has been failing due to test 'test_create_volume_under_domain'
for all the PR's. Lets wait till we fix the test or disable this component test.
---
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd I have re-kicked Travis, but it still fails due to the following
exception (test environment and/or code issue) while running the test
"test_create_volume_under_domain":
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma we're waiting for a final LGTM from @murali-reddy can you
do a `push -f` to re-kick Travis. (though I checked the failure is not due to
your PR). @murali-reddy can you please
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd Just to make sure, are we waiting for a LGTM to merge this PR ?
May be, @jburwell can comment and/or give a LGTM as he has reviewed the PR
:)
---
If your project is set
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Test LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-584)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41829 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-585)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35923 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan test centos7 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Packaging result: âcentos6 âcentos7 âdebian. JID-327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd Travis is happy
findbugs fails at globodns though (not due to this PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Thanks @rhtyd , I resubmitted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-575)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27915 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Packaging result: âcentos6 âcentos7 âdebian. JID-322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@krissterckx Yes. Though, Travis failed due to failure in one of the
component tests, please see `test_volumes`
https://travis-ci.org/apache/cloudstack/jobs/180954289
This may be an
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Hi @rhtyd
as #1806 got merged, can a travis re-run be initiated ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd @jburwell We have resolved all your review comments, and updated
this PR. Moreover, all our internal regressions are looking good with the
latest code in this PR.
Let me
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Travis is failing due to an env issue in their VMs, I'm investigating it
with #1806
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd We have now resolved all your review comments including adding of
the requested unit test coverage, and we have rebased this PR with the latest
master (i.e. contains PR #1801
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
I'm seeing no new errors except for `test_06_download_detached_volume` and
`test_01_create_template`. @prashanthvarma can you have a look, they may be
intermittent in nature.
@jburwell
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma agreed regarding the most common causes of failures.
@murali-reddy @borisstoyanov and @abhinandanprateek have been working to
address these issues as they are encountered. To
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell Thank you for the update, I was planning to investigate the same
test failure (test_router_dhcp_opts) as unlike other test failures it looked
like an actual reproducible issue
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma the redundant router/VPC failures are known. We have a fix
pending for the `test_snapshot` failures in XenServer (#1800). However, I am
concerned about
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma please ignore my last comment. It appears that we have
found an issue with the `test_router_dhcp_opts` test case. #1801 has been
submitted to fix it. Once #1800 and #1801
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-507)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40678 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-505)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 34519 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Trillian test result (tid-506)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29877 seconds
Marvin logs:
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma @fmaximus @nlivens thanks, I've kicked some tests. I'll be
willing to merge the PR once they pass and we've no outstanding review items.
---
If your project is set up for it, you
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt
+ vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
---
If your project is set up for
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Packaging result: âcentos6 âcentos7 âdebian. JID-284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
LGTM
From our internal code review and regression run results (including our
added Nuage VSP SDN plugin specific Marvin tests, refer the previous comment
for their
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Nuage VSP SDN plugin specific Marvin test code PEP8 & PyFlakes Compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$
Github user fmaximus commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Rebased and squashed all commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd @jburwell
UPDATE: We are currently re-qualifying this PR (internally, re-based with
latest master and commits squashed) as we hit the issue "systemvm: Fix
regression
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd @jburwell We will rebase this PR with the latest master asap, and
update you.
As mentioned in the previous comments, we wanted to merge this PR after
merging PR #1580 as
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@nlivens @prashanthvarma @singalrahul please squash your changes, fix
conflicts, rebase against latest master. Pending lgtm/review is requested. /cc
@jburwell
---
If your project is set up for
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@nlivens @prashanthvarma @singalrahul can you please squash your commits.
Pending review/lgtm is requested.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Packaging result: âcentos6 âcentos7 âdebian. JID-214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorganutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma please squash all commits down into one logical commit for
the enhancement. Multiple commits for the same feature muddy the long term
history.
---
If your project is set up
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell @rhtyd We want to get this PR merged in after merging in PR #1580
as there are some feature interactions and dependencies. Thus, we will rebase
this PR on top of the PR #1580
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma #1578 has been merged. Can you rebase this PR and squash
the commits? Once that is done and Jenkins and Travis are green, I will kick
regression tests via blueorganutan.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd As I mentioned in the earlier comments, this feature PR has
dependency with our other open feature PR #1578. Thus, we re-based this PR (2
commits) on top of that PR (2 commits) as
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma can you squash the commits please, I see 4 here. At least
squash the ones related, i.e. one for the feature and one for the integration
test.
---
If your project is set up for
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell @rhtyd I have rebased this PR with latest master, and squashed
commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here.
Moreover, we can re-run the added Marvin tests and share the results after the
re-base.
This PR has dependency
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@nlivens I can run tests on this PR if you can rebase, fix conflicts and
squash your changes. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@nlivens I would like to get this PR merged for 4.10.0.0. I will code
review in the next few days. In the meantime, please rebase this PR to pick up
the latest Marvin enhancements/fixes, as
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes
Github user singalrahul commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Added Marvin code PEP8 & PyFlakes compliance:
cloudstack$ pep8 --max-line-length=150
test_nuage_sharednetwork_vpc_vm_monitor.py
cloudstack$ pyflakes
70 matches
Mail list logo
