Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Great, thanks @rhtyd!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Thanks for your help @jburwell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@serg38 @nvazquez I will merge this PR when I get into the office on Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1602
LGTM for the testing. Smoke test results
```
test DeployVM in anti-affinity groups for project ... === TestName:
test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS ===
test
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Just realized I hadn't re-reviewed. LGTM for code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@karuturi @jburwell @rafaelweingartner Please disregard. We are still
running tests for this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@karuturi @jburwell @rafaelweingartner Can you check if this PR can be
merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1602
LGTM for testing
[root@ussarlabcsmgt41 MarvinLogs]# cat
/tmp//MarvinLogs/test_volumes_CP3Z7R/results.txt
test DeployVM in anti-affinity groups for project ... === TestName:
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@jburwell Are there any outstanding issues with this PR? It is waiting for
second LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Thanks @jburwell for your review! I refactored based on your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1602
---
If your project is set up for it, you can reply to this email and have your
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1602
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@rhtyd can you re-kick this PR for @blueorangutan?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
I rebased master branch and pushed again, could it be ran again?
@blueorangutan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1602
---
If your project is set up for it, you can reply to this email and have your
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Thanks guys. The code LGTM based on the code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Thanks @syed for your comments!
I agree with @serg38 that extension to other hypervisors could be done in a
separate PR
---
If your project is set up for it, you can reply to this email
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@syed. Absolutely it can although the effort seems to be well beyond and
scope of this PR. @nvazquez and I have only access to vmware hypervisors at
this point. If there is an interest to expand
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Thanks @serg38 my question is more along the lines of can this `fullClone`/
`linkedClone` functionality be extended to other hypervisors, in that case, we
can make the code hypervisor agnostic. If
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@syed. The default behavior won't change. The proposed enhancement will add
an ability to control link/full clone deployment of a primary storage level. If
it is not defined there a current
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@syed adding to use cases that @serg38 mentioned, I edited PR's title which
could be confusing
---
If your project is set up for it, you can reply to this email and have your
reply appear on
23 matches
Mail list logo
