[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 Closing this since #1944 has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1826 Thanks @rashmidixit both the PRs may be closed given the new performance improvement PR #1944 which also includes some case fixes from this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rhtyd I will take a look. However, this pull request is to do with additional bug fixes. Can you please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rashmidixit I've taken your feedback and improved the feature here https://github.com/apache/cloudstack/pull/1944 -- this reimplements the frontend logic at the backend, improving the overall performance 4-40x and handling missing error cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rhtyd Please take a look now. I have squashed the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rashmidixit can you squash your changes, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1826 Thanks @rashmidixit I'll review them soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rhtyd Have you been able to take a look at the commits? Will appreciate your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 Added one more fix to this: 1. List of Virtual Machines will be incorrect if the number is greater than the pagesize. Added -1 to the call of the API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rhtyd - There have been four things fixed here. I have explained each commit below. Your review/comments is most appreciated. 1. Goto Zone metrics or Hosts metrics. NUmerical values are not listed under Mem Usage and Mem Allocation columns. Instead 'NaN' is displayed - Mainly happening due to missing checks for undefined. 2. Create a Windows instance on a Xen cluster. No IOPS data is generated or shown in the Disk Usage Tab for that Instance: In some cases the diskiops from API comes back as 0. In this case, calculated it based on disk read and write values. 3. Changing storage.overprovisioning factor should cause changed values in storage metrics. This doesnt happen currently: The disk overprovisioning factor was not considered when calculating metrics 'disk total' and 'disk allocated'. Added this in. 4. Allocated memory is not correctly calculated on Hosts Metrics page for a xen server with multiple instances: The value being returned from API was % value. The Host metric page shows this in GB. Converted it correctly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rashmidixit please change PR's base branch to 4.9. I'm the author/maintainer of this feature. I would like to know more about your changes, and what issues you're fixing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
