[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1847 Hi @nvazquez, let me simplify what B.O. is doing, when it read 'test' it kicks a jenkins job that deploys the pr, deploys a zone and executes all tests in the smoketests directory. Personally I don't see anything wrong with appending an item in the test_data.py and using it, as long as we make sure to do `self.cleanup.append(new_object)`. In particular, this object can be reused by any test as long as it's not already added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1847
@borisstoyanov @rhtyd I was checking BlueOrangutan logs:
In `test_primary_storage_8NPG5G\runinfo.txt` lines 27-30, there's PS
creation:
2017-02-20 11:03:59,678 - DEBUG - Payload: {'apiKey':
u'LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q',
'name': 'Marvin Primary Pool', 'url':
'NFS://10.2.0.16/acs/primary/pr1847-t854-kvm-centos7/marvin_pri1', 'podid':
u'1c6f35e3-a31e-49cc-b0b0-801848dbb9bc', 'clusterid':
u'8ac40777-344d-4f36-93a3-7b685361a523', 'zoneid':
u'9c474c4e-0742-4fbb-b0ae-cb3d1e63cb70', 'command': 'createStoragePool',
'signature': 'zq6ff7P2n9iLmw3Cw9nDgMM1v90=', 'response': 'json'}
2017-02-20 11:03:59,678 - DEBUG - Sending GET Cmd :
createStoragePool===
2017-02-20 11:04:00,038 - DEBUG - Response : {podname : u'Pod1', name :
u'Marvin Primary Pool', disksizeallocated : 0, created :
u'2017-02-20T11:04:00+', clustername : u'p1-c1', ipaddress : u'10.2.0.16',
podid : u'1c6f35e3-a31e-49cc-b0b0-801848dbb9bc', clusterid :
u'8ac40777-344d-4f36-93a3-7b685361a523', zoneid :
u'9c474c4e-0742-4fbb-b0ae-cb3d1e63cb70', state : u'Up', scope : u'CLUSTER',
overprovisionfactor : u'2.0', path :
u'/acs/primary/pr1847-t854-kvm-centos7/marvin_pri1', zonename :
u'pr1847-t854-kvm-centos7', type : u'NetworkFilesystem', id :
u'fa44baa2-267d-3f36-88c9-c5c545e0204b', disksizetotal : 7514055770112}
2017-02-20 11:04:00,038 - DEBUG - Created storage pool in cluster:
8ac40777-344d-4f36-93a3-7b685361a523
Then, it gets removed, lines 46-48:
2017-02-20 11:04:35,193 - DEBUG - Payload: {'apiKey':
u'LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q',
'response': 'json', 'command': 'deleteStoragePool', 'signature':
'73NDgRVRZDU4uHR/Vc8pRbVg2p4=', 'id': u'fa44baa2-267d-3f36-88c9-c5c545e0204b'}
2017-02-20 11:04:35,193 - DEBUG - Sending GET Cmd :
deleteStoragePool===
2017-02-20 11:04:35,396 - DEBUG - Response : {success : u'true'}
Then, on `test_volumes_950C4W\runinfo.txt` lines 474-476 `listStoragePools`
command is sent and lists previously deleted PS:
2017-02-20 13:54:49,407 - DEBUG - Payload: {'apiKey':
u'LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q',
'command': 'listStoragePools', 'signature': 'l3xL+RNaPCVAYEpCovbu1snTIRI=',
'response': 'json'}
2017-02-20 13:54:49,407 - DEBUG - Sending GET Cmd :
listStoragePools===
2017-02-20 13:54:49,432 - DEBUG - Response : [{podname : u'Pod1',
storagecapabilities : {VOLUME_SNAPSHOT_QUIESCEVM : u'false'}, name : u'Marvin
Primary Pool', disksizeallocated : 8590328832, podid :
u'1c6f35e3-a31e-49cc-b0b0-801848dbb9bc', clustername : u'p1-c1', ipaddress :
u'10.2.0.16', created : u'2017-02-20T12:51:45+', clusterid :
u'8ac40777-344d-4f36-93a3-7b685361a523', zoneid :
u'9c474c4e-0742-4fbb-b0ae-cb3d1e63cb70', state : u'Up', disksizeused :
174845853696, id : u'fa44baa2-267d-3f36-88c9-c5c545e0204b', overprovisionfactor
: u'2.0', path : u'/acs/primary/pr1847-t854-kvm-centos7/marvin_pri1', zonename
: u'pr1847-t854-kvm-centos7', type : u'NetworkFilesystem', scope : u'CLUSTER',
disksizetotal : 7514055770112}, {podname : u'Pod1', storagecapabilities :
{VOLUME_SNAPSHOT_QUIESCEVM : u'false'}, name :
u'pr1847-t854-kvm-centos7-kvm-pri2', disksizeallocated : 977060864, podid :
u'1c6f35e3-a31e-49cc-b0b0-801848dbb9bc', clustername : u'p1-c1', ipaddress :
u'10.2.0.16', create
d : u'2017-02-20T08:52:51+', clusterid :
u'8ac40777-344d-4f36-93a3-7b685361a523', zoneid :
u'9c474c4e-0742-4fbb-b0ae-cb3d1e63cb70', state : u'Up', disksizeused :
174845853696, id : u'7a360219-f4a9-3edb-a1e3-241cbc2dee7f', overprovisionfactor
: u'2.0', path :
u'/acs/primary/pr1847-t854-kvm-centos7/pr1847-t854-kvm-centos7-kvm-pri2',
zonename : u'pr1847-t854-kvm-centos7', type : u'NetworkFilesystem', scope :
u'CLUSTER', disksizetotal : 7514055770112}, {podname : u'Pod1',
storagecapabilities : {VOLUME_SNAPSHOT_QUIESCEVM : u'false'}, name :
u'pr1847-t854-kvm-centos7-kvm-pri1', disksizeallocated : 3221422592, podid :
u'1c6f35e3-a31e-49cc-b0b0-801848dbb9bc', clustername : u'p1-c1', ipaddress :
u'10.2.0.16', created : u'2017-02-20T08:52:50+', clusterid :
u'8ac40777-344d-4f36-93a3-7b685361a523', zoneid :
u'9c474c4e-0742-4fbb-b0ae-cb3d1e63cb70', state : u'Up', disksizeused :
174845853696, id : u'4435931f-bb5a-3ce6-a2f5-6f7345d5eb0a', overprovisionfactor
: u'2.0', path : u'/acs/primary
/pr1847-t854-kvm-centos7/pr1847-t854-kvm-centos7-kvm-pri1', zonename :
u'pr1847-t854-kvm-centos7', type : u'NetworkFilesystem', scope : u'CLUSTER',
disksizetotal : 7514055770112}]
Please note that although there's almost 3-hour difference between logs,
there exists a PS with the same id
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @anshul1886 Can we tweak line 278 of test_snaphsot.py from self.services["nfs"], to self.services["nfs2"], and re-merge this PR so it doesn't conflict with other tests using "nfs" test data. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1847 @borisstoyanov can you have a look at ^^, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1847
@nvazquez @rhtyd @anshul1886 We might need to tweak the test_data.py to add
additional nfs mount e.g. nfs1 and use it in this test. E.g adding
"nfs1": {
"url": "nfs://nfs/export/automation/1/testprimary1",
"name": "Primary XEN1"
},
Blueorangutain environment will need to be adjusted as well. Otherwise the
test fails with
CloudstackAPIException: Execute cmd: createstoragepool failed, due to:
errorCode: 530, errorText:Failed to add data store: Storage pool
NFS://10.2.0.16/acs/primary/pr1847-t854-kvm-centos7/marvin_pri1 already in use
by another pod (id=1)\n']
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1847 Trillian test result (tid-854) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26568 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1847-t854-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Test completed. 46 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 315.29 | test_privategw_acl.py test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | test_snapshots.py test_01_vpc_site2site_vpn | Success | 140.99 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 66.12 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 220.68 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 284.23 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 513.11 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 503.72 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1404.04 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 538.71 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 741.04 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1286.74 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 151.44 | test_volumes.py test_08_resize_volume | Success | 156.61 | test_volumes.py test_07_resize_fail | Success | 156.51 | test_volumes.py test_06_download_detached_volume | Success | 157.60 | test_volumes.py test_05_detach_volume | Success | 151.18 | test_volumes.py test_04_delete_attached_volume | Success | 151.37 | test_volumes.py test_03_download_attached_volume | Success | 156.77 | test_volumes.py test_02_attach_volume | Success | 94.64 | test_volumes.py test_01_create_volume | Success | 621.09 | test_volumes.py test_deploy_vm_multiple | Success | 252.67 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.80 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 40.93 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 130.86 | test_vm_life_cycle.py test_03_reboot_vm | Success | 126.01 | test_vm_life_cycle.py test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.33 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 75.64 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.16 | test_templates.py test_03_delete_template | Success | 5.13 | test_templates.py test_02_edit_template | Success | 90.18 | test_templates.py test_01_create_template | Success | 25.33 | test_templates.py test_10_destroy_cpvm | Success | 161.44 | test_ssvm.py test_09_destroy_ssvm | Success | 163.81 | test_ssvm.py test_08_reboot_cpvm | Success | 101.37 | test_ssvm.py test_07_reboot_ssvm | Success | 133.56 | test_ssvm.py test_06_stop_cpvm | Success | 131.60 | test_ssvm.py test_05_stop_ssvm | Success | 133.67 | test_ssvm.py test_04_cpvm_internals | Success | 1.02 | test_ssvm.py test_03_ssvm_internals | Success | 3.29 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.10 | test_snapshots.py test_04_change_offering_small | Success | 210.81 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py test_09_reboot_router | Success | 40.33 | test_routers.py test_08_start_router | Success | 30.28 | test_routers.py test_07_stop_router | Success | 10.16 | test_routers.py test_06_router_advanced | Success | 0.06 | test_routers.py test_05_router_basic | Success | 0.04 | test_routers.py
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1847 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1847 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1847 Packaging result: âcentos6 âcentos7 âdebian. JID-506 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1847 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1847 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi, Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 Ok, Doing that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1847 Hi @anshul1886, I just observed that the related PR #1735 was for 4.9. Since this bug also exists in 4.9, can you change the base branch of this PR to 4.9 and rebase? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi Test failing is unrelated to this PR. === TestName: test_add_user_to_project | Status : EXCEPTION === === TestName: test_add_user_to_project | Status : EXCEPTION === Test failing in travis is | ContextSuite con | exceptions.Excep | 36.025 | test_project_lim | | text=TestResourc | tion | | its | | eLimitsProject>: | | | | | teardown --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1847 ### ACS CI BVT Run **Sumarry:** Build Number 352 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_routers_network_ops.py * test_03_RVR_Network_check_router_state Failed **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1847 oops.. will wait for travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1847 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @nvazquez , Added the marvin test from #1735. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1847 @anshul1886 great, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @nvazquez, Yeah I am fine with it. I will add the test from your PR to mine PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1847 Hi @anshul1886, I've deployed and tested your PR by replicating issue we had in our environment with Vmware and passed successfully! I think your solution is much cleaner and simpler than mine. Do you agree if I close mine and we go ahead on your PR? Would you mind adding marvin test written in mine to your PR (under test_snapshots.py)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @nvazquez What would you like to do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1847 @anshul1886 can you and @nvazquez work together and create a single PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi, One will be enough to fix the issue. #1735 has added the test which can be used. Other then test that PR needs some fixing for actual fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1847 @sateesh-chodapuneedi @anshul1886 @mike-tutkowski whats the relation with #1735? Is one of them required or both? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi Seems this is ready for merge, with code LGTMs and based on test results published by @cloudmonger ? The 4 test failures seems not relevant to this patch with code changes in API layer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1847 ### ACS CI BVT Run **Sumarry:** Build Number 204 Hypervisor xenserver NetworkType Advanced Passed=101 Failed=3 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_routers_network_ops.py * test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 3 runs * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 3 runs * test_03_RVR_Network_check_router_state Failing since 3 runs **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1847 To clarify this line: "If that comes back null, then we apparently have removed primary storage, which can only be done if your snapshots don't reside on it. If dataStore == null, return DataStoreRole.IMAGE." I meant this for managed storage. For unmanaged storage, the original primary storage from which the snapshot came can be deleted and the snapshot can remain. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @mike-tutkowski was in python mode so used try except mode instead of null check which is recommended in java. Pushed the changes for null check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1847 Let me provide a bit of background on this and then we can decide which way we want to correct this side effect. Here is the PR that went in a while ago that enabled CloudStack to support volume snapshots that reside on primary storage: https://github.com/apache/cloudstack/pull/1403 The idea being these types of snapshots are faster than the back-up-to-secondary-storage approach CloudStack does by default and they can be a lot more space efficient, as well. As part of this process, I went through and tried to identify all of the locations where we assumed a volume snapshot resided on secondary storage (and I put in code to see if it really resides there or, instead, if it's on primary storage). As we have noted, a couple places were missed and this PR (as wells as #1735) were opened to address those issues. The way this particular PR's code is written should work fine. In the case where the original primary storage has been removed, an exception will be thrown, caught, logged, and then we will default to returning secondary storage as the location (which it should be). Instead of the try/catch approach, though, it might be better if we see if dataStore is null. DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId, DataStoreRole.Primary); If that comes back null, then we apparently have removed primary storage, which can only be done if your snapshots don't reside on it. If dataStore == null, return DataStoreRole.IMAGE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1847 Hi @anshul1886, We addressed the same issue along with @serg38 in PR #1735. We proposed a way to fix the problem on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @serg38 seems so both addressing same issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @mike-tutkowski @anshul-gangwar @nvazquez I believe the same issue is addressed in PR1735 but in a more consistent fashion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @mike-tutkowski Its in bug description. Are you not seeing this issue on your end? 2016-08-26 14:34:36,709 DEBUG [c.c.a.ApiServlet] (catalina-exec-1:ctx-90c9ba3a) (logid:115e39ad) ===START=== 10.233.88.59 â GET command=listSnapshots=json=true=1=20&_=1472202277072 2016-08-26 14:34:36,747 ERROR [c.c.a.ApiServer] (catalina-exec-1:ctx-90c9ba3a ctx-94284178) (logid:115e39ad) unhandled exception executing api command: [Ljava.lang.String;@77f27ce8 com.cloud.utils.exception.CloudRuntimeException: Unable to locate datastore with id 1 at org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.getPrimaryDataStore(PrimaryDataStoreProviderManagerImpl.java:61) at org.apache.cloudstack.storage.datastore.DataStoreManagerImpl.getDataStore(DataStoreManagerImpl.java:48) at com.cloud.api.ApiResponseHelper.getDataStoreRole(ApiResponseHelper.java:571) at com.cloud.api.ApiResponseHelper.createSnapshotResponse(ApiResponseHelper.java:537) at org.apache.cloudstack.api.command.user.snapshot.ListSnapshotsCmd.execute(ListSnapshotsCmd.java:117) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:132) at com.cloud.api.ApiServer.queueCommand(ApiServer.java:707) at com.cloud.api.ApiServer.handleRequest(ApiServer.java:538) at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:297) at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126) at com.cloud.api.ApiServlet.doGet(ApiServlet.java:86) at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1847 Can you tell me which line was throwing a NullPointerException in the code that you fixed? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
