[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @karuturi I have rebased with master and pushed. I still see failures in Travis but they dont seem to be with my changes. Can you please check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1889 @rashmidixit travis is failing. Can you rebase with master and force push? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @karuturi requesting you to merge these changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1889 Nice work @rashmidixit, tested it and works great! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1889 LGTM, please merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1889 @rashmidixit finally I decide to say LGTM to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @ustcweizhou thanks. I guess there was a misunderstanding. I understand what you are saying. I think i will just remove that dialog. The problem is that we are lazy loading the list of hosts. If there are many, as the user scrolls down, the page loads. Can you tell me how many hosts you have in the list and explain a little about the problem you face? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1889 @rashmidixit thanks for the update. Compared with old patch, I notice you changed the return if args.page == 1. However, it does not solve my issue. We have several hosts (more than 1 page). Each time when I get the last page (full list), I get the alert dialog, that is what I want to avoid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @ustcweizhou I have made appropriate changes. Can you please check once the validations pass? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1889 Looks good (did not test it) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1889 @rashmidixit thanks for your work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @ustcweizhou The popup is to indicate that no hosts were found. If I remove that, then there will be no visual indication that the search has returned no results. We need to have an alternative way to show that 0 results found. Let me see if I can put a message somewhere beneath to say the same. Will get back to you in a day or so. Thanks for trying this out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1889
@rashmidixit We have ported it in our branch and found it inconvenient to
click the OK button in dialog with warning "No more hosts are available for
migration" frequently.
could you remove the line below ?
```
cloudStack.dialog.notice({
message:
_l('message.no.host.available')
}); //Only a
single host in the set up
-} else {
-
cloudStack.dialog.notice({
- message:
_l('message.no.more.hosts.available')
- });
}
}
});
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @karuturi ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1889 I ported this to 4.7.1,and tested it. It works fine (list/order/search). LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1889 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1889 LGTM, did not test it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
