[GitHub] cloudstack issue #1909: CLOUDSTACK-9740 : Search for secondary IP of NIC tha...

2017-02-16 Thread SudharmaJain
Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1909
  
@niteshsarda I see a problem here. The listNics command can be used to list 
both primary and secondary ips. In case if we pass nicid parameter with it, i 
feel we should use keywork to filter secondary nics. If only virtualmachineid 
is given, we should use it to filter primary IPs.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1909: CLOUDSTACK-9740 : Search for secondary IP of NIC tha...

2017-02-16 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1909
  
@niteshsarda in my opinion, what we should change is the search processing, 
not the process on creating nic response.
to be clear, in server/src/com/cloud/network/NetworkServiceImpl.java
```
public List listNics(ListNicsCmd cmd)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1909: CLOUDSTACK-9740 : Search for secondary IP of NIC tha...

2017-02-16 Thread niteshsarda
Github user niteshsarda commented on the issue:

https://github.com/apache/cloudstack/pull/1909
  
![screenshot after applying 
fix](https://cloud.githubusercontent.com/assets/25146827/23013185/9e11507e-f44f-11e6-8921-acc0c3eb35c4.PNG)
![screenshot before applying 
fix](https://cloud.githubusercontent.com/assets/25146827/23013197/a8838aa4-f44f-11e6-98c3-50f1d0bec8c1.PNG)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---