[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-222495165
  
Master is currently frozen for the 4.9 release.  Only fixes that stabilize 
master are to be added at this point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-222488422
  
@swill , recent CI run on this PR shows 0 Failures. Can you please merge 
this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-11023
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 66
 Hypervisor xenserver
 NetworkType Advanced
 Passed=72
 Failed=0
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-218596132
  
The additional run of these tests in a new environment gives the same 
results.  I think this needs some work still...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-218483982
  
The added test fails, but lots of tests failed.  I will rebuild my 
environment and test again to see if anything changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-218483641
  


### CI RESULTS

```
Tests Run: 7
  Skipped: 0
   Failed: 4
   Errors: 0
 Duration: 0h 37m 50s
```

**Summary of the problem(s):**
```
FAIL: Test restart network with cleanup
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2851, in test_restart_network_with_cleanup
self.validateResult(result)
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2749, in validateResult
self.fail("IP is missing from vpcVR")
AssertionError: IP is missing from vpcVR
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt
```

```
FAIL: Test network rules after starting a VpcVr that
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2465, in test_02_start_vm_network_gc
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt
```

```
FAIL: Test Stop all the Vms that are part of the a Network
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2557, in test_03_restart_vpcvr
(self.public_ip_1.ipaddress.ipaddress, e))
AssertionError: Failed to SSH into VM - 192.168.23.54, SSH connection has 
Failed. Waited 600s. Error is SSH Connection Failed
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt
```

```
FAIL: Test update Network that is part of a VPC to a network
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
1910, in test_01_network_services_upgrade
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_11_2016_08_32_17_9O5EIE:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__May_11_2016_08_32_17_9O5EIE/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__May_11_2016_08_32_17_9O5EIE/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__May_11_2016_08_32_17_9O5EIE/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_network_14GQ49:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_14GQ49/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_14GQ49/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_14GQ49/runinfo.txt)


Uploads will be available until `2016-07-11 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-216560467
  
Thank you @sanju1010, I will get this in for testing again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-216524259
  
@swill , added check to see if m has any match object and fail if not. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-216219841
  
@sanju1010 please rebase and push -f for travis job to be kicked off


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-215309683
  
Thanks @swill , I will fix the error and update the PR. Thanks for taking 
your time and running it on your CI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-215224845
  
Don't worry about the connectivity issues, that seems to be my environment 
right now.  The ERROR you do need to fix because that is a problem.  Cheers...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1304#discussion_r61333278
  
--- Diff: test/integration/component/test_vpc_network.py ---
@@ -2683,6 +2687,65 @@ def setUp(self):
 def tearDown(self):
 return
 
+def listRouter(self):
+routers = Router.list(
+self.apiclient,
+vpcid=self.vpc.id,
+listall="true"
+)
+self.assertEqual(validateList(routers)[0], PASS, "Invalid router 
response")
+return routers[0]
+
+def secondaryIP(self, router):
+hosts = list_hosts(
+self.apiclient,
+id=router.hostid
+)
+self.assertEqual(validateList(hosts)[0], PASS, "Invalid host 
response")
+host = hosts[0]
+if self.hypervisor.lower() in ('vmware', 'hyperv'):
+# SSH into system vms is done via management server for Vmware 
and
+# Hyper-V
+result = get_process_status(
+self.apiclient.connection.mgtSvr,
+22,
+self.apiclient.connection.user,
+self.apiclient.connection.passwd,
+router.privateip,
+"ip addr show",
+hypervisor=self.hypervisor
+)
+else:
+try:
+host.user, host.passwd = get_host_credentials(
+self.config, host.ipaddress
+)
+result = get_process_status(
+host.ipaddress,
+22,
+host.user,
+host.passwd,
+router.linklocalip,
+"ip addr show"
+)
+except KeyError:
+self.skipTest("Marvin configuration has no host 
credentials to check router services")
+return result
+
+def validateResult(self, output):
+ip = self.public_ip_1.ipaddress.ipaddress
+reg = re.compile(ip)
+for line in output:
+m = reg.search(line)
+if m:
+break
+if m.group(0) == ip and re.search("secondary", line):
--- End diff --

`m` is not guaranteed to be set.  You need to check `if m and len(m.group) 
> 0 ...` before you can try to access it.  Check the `Error` in the CI result.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-215221441
  


### CI RESULTS

```
Tests Run: 92
  Skipped: 0
   Failed: 4
   Errors: 1
```

**Summary of the problem(s):**
```
ERROR: Test restart network with cleanup
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2848, in test_restart_network_with_cleanup
self.validateResult(result)
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2742, in validateResult
if m.group(0) == ip and re.search("secondary", line):
AttributeError: 'NoneType' object has no attribute 'group'
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_21FMEY/results.txt
```

```
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_routers_network_ops.py", 
line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
"Attempt to retrieve google.com index page should be successful once 
rule is added!"
AssertionError: Attempt to retrieve google.com index page should be 
successful once rule is added!
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_21FMEY/results.txt
```

```
FAIL: Test network rules after starting a VpcVr that
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2465, in test_02_start_vm_network_gc
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_21FMEY/results.txt
```

```
FAIL: Test Stop all the Vms that are part of the a Network
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2557, in test_03_restart_vpcvr
(self.public_ip_1.ipaddress.ipaddress, e))
AssertionError: Failed to SSH into VM - 192.168.23.54, SSH connection has 
Failed. Waited 600s. Error is SSH Connection Failed
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_21FMEY/results.txt
```

```
FAIL: Test update Network that is part of a VPC to a network
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
1910, in test_01_network_services_upgrade
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_21FMEY/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_17_13_56_660M82:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_17_13_56_660M82/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_17_13_56_660M82/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_17_13_56_660M82/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_network_21FMEY:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_21FMEY/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_21FMEY/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_21FMEY/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_62M97S:`**
* 

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-214538838
  
Running tests again in the same setup to see if any of the connection 
issues are resolved.  The error for sure should be looked into...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-214537887
  


### CI RESULTS

```
Tests Run: 29
  Skipped: 10
   Failed: 3
   Errors: 1
```

**Summary of the problem(s):**
```
ERROR: Test restart network with cleanup
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2848, in test_restart_network_with_cleanup
self.validateResult(result)
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2742, in validateResult
if m.group(0) == ip and re.search("secondary", line):
AttributeError: 'NoneType' object has no attribute 'group'
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_JX5MBT/results.txt
```

```
FAIL: Test network rules after starting a VpcVr that
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2465, in test_02_start_vm_network_gc
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_JX5MBT/results.txt
```

```
FAIL: Test Stop all the Vms that are part of the a Network
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
2557, in test_03_restart_vpcvr
(self.public_ip_1.ipaddress.ipaddress, e))
AssertionError: Failed to SSH into VM - 192.168.23.54, SSH connection has 
Failed. Waited 600s. Error is SSH Connection Failed
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_JX5MBT/results.txt
```

```
FAIL: Test update Network that is part of a VPC to a network
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_vpc_network.py", line 
1910, in test_01_network_services_upgrade
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_vpc_network_JX5MBT/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Apr_25_2016_22_50_41_1M4DX6:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__Apr_25_2016_22_50_41_1M4DX6/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__Apr_25_2016_22_50_41_1M4DX6/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/DeployDataCenter__Apr_25_2016_22_50_41_1M4DX6/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_network_JX5MBT:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_JX5MBT/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_JX5MBT/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1304/tmp/MarvinLogs/test_vpc_network_JX5MBT/runinfo.txt)


Uploads will be available until `2016-06-25 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-214503490
  
Would you mind doing a force push to try to get everything green.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-213448269
  
I have made changes as per @pavanb018's comments and tested it on my 
environment.
Following are the test results:
Test restart network with cleanup ... === TestName: 
test_restart_network_with_cleanup | Status : SUCCESS ===
ok

--
Ran 1 test in 474.544s

OK

@pavanb018 , can you please review the changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-212934000
  
@sanju1010 can you review @pavanb018's comment.

We need 1 more LGTM code review, otherwise things are looking to be in 
pretty good shape here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[pavanb018]

Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-212892204
  
Done code review ,a part from the above comment , the code LGTM !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[pavanb018]

Github user pavanb018 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1304#discussion_r60570371
  
--- Diff: test/integration/component/test_vpc_network.py ---
@@ -2748,3 +2751,86 @@ def test_stop_start_vpc_router(self):
 if (exceptionOccured or (not isRouterInDesiredState)):
 self.fail(exceptionMessage)
 return
+
+@attr(tags=["advanced", "intervlan"], required_hardware="true")
+def test_restart_network_with_cleanup(self):
+""" Test restart network with cleanup
+
+#1.Acquire pubilc ip
+#2.Configure PF rule on acquired ip
+#3.Restart network wich leanup
+#4.Verify that IP won't be deleted from vpc VR
+"""
+self.public_ip_1 = PublicIPAddress.create(
+self.apiclient,
+accountid=self.account.name,
+zoneid=self.zone.id,
+domainid=self.account.domainid,
+networkid=self.network_1.id,
+vpcid=self.vpc.id
+)
+NATRule.create(
+self.apiclient,
+self.vm_1,
+self.services["natrule"],
+ipaddressid=self.public_ip_1.ipaddress.id,
+networkid=self.network_1.id
+)
--- End diff --

@sanju1010  Can we add a validation to make sure that secondary IP is 
indeed present on the VR even before restarting the network , so that the test 
will not miss out on the issue where secondary IP was not present on the VR 
interface even before restart for some reason ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-202117240
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 136
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1304#issuecomment-168653437
  
Test restart network with cleanup ... === TestName: 
test_restart_network_with_cleanup | Status : SUCCESS ===
ok

--
Ran 1 test in 161.169s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

[sanju1010]

GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/1304

[CLOUDSTACK-9207] Test to verify restarting vpc network with cleanup does 
not delete the secondary ip address from VR

Please check jira 
https://issues.apache.org/jira/browse/CLOUDSTACK-9207
 for more details.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack vpc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1304.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1304


commit e3f8becc578155b5491834b1632716111bccab67
Author: sanjeevn 
Date:   2016-01-04T09:13:47Z

Marvin test to verify CS-44071
Bug-Id: CS-44071
Reviewed-by: Self




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---