[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-222499981
  
This is a bit of a grey area.  I will consider it, but I need jenkins and 
travis coming back clean to be comfortable with merging and I will have to run 
another CI on it since you fixed the merge conflicts.  You may have to close 
and reopen this PR a few times to get travis and jenkins to go green...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-222489855
  
This will help in stabilizing CI runs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-222489678
  
@swill , can you consider marvin test related changes for merging into ACS 
master since they would not destabilize the master? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-222487710
  
Master is currently frozen.  I am merging bug fixes if they are needed to 
stabilize master, but I don't think this qualifies...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-219539120
  
@sanju1010 we have merge conflicts now. Can you please rebase against the 
current master. Code freeze is basically now, so if you want this in we need to 
get busy...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-218807584
  
@sanju1010 we have merge conflicts now.  Can you please rebase against the 
current master.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-218366880
  
Bump...  @sanju1010 can you please follow up on @DaanHoogland's comments.  
This one is ready to go otherwise, so it would be great if you could follow up 
with us on this @sanju1010.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-216887066
  
@sanju1010 can you address @DaanHoogland's concerns?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-215512619
  
@sanju1010 though the code looks alright I don't like the integration test 
should be snooping under the hood. I would rather see them behave as black-box 
tests. I am sure this kind of validating happens elsewhere but still I would 
like some reason for it, can you explain?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-215481337
  
Yes, I think this one is ready...  Can I get one more LGTM code review on 
this one?  

@pdube @kiwiflyer @DaanHoogland @rafaelweingartner 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-215427658
  
@swill , it is all green now. Can you please merge this PR ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-215266469
  
I have tested this and I think we are ready.  Can you please do a force 
push to kick off jenkins again so we can get this PR all green?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-215266162
  


### CI RESULTS

```
Tests Run: 4
  Skipped: 0
   Failed: 0
   Errors: 0
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Apr_28_2016_00_13_59_IGZ5H5:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1455/tmp/MarvinLogs/DeployDataCenter__Apr_28_2016_00_13_59_IGZ5H5/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1455/tmp/MarvinLogs/DeployDataCenter__Apr_28_2016_00_13_59_IGZ5H5/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1455/tmp/MarvinLogs/DeployDataCenter__Apr_28_2016_00_13_59_IGZ5H5/runinfo.txt)

**`/tmp/MarvinLogs/test_privategw_acl_IEZB6Z:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1455/tmp/MarvinLogs/test_privategw_acl_IEZB6Z/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1455/tmp/MarvinLogs/test_privategw_acl_IEZB6Z/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1455/tmp/MarvinLogs/test_privategw_acl_IEZB6Z/runinfo.txt)


Uploads will be available until `2016-06-27 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-206295391
  
@swill , I have made changes based on the CI results.

Following failure in the CI run is not related to the changes in this PR:
==
FAIL: Test Remote Access VPN in VPC
--
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 419, in test_01_vpc_remote_access_vpn
vpnUser, "Failed to create Remote Access VPN User")
AssertionError: Failed to create Remote Access VPN Us


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-205111794
  

### CI RESULTS




**MULTIPLE FAILURES, NEEDS WORK!**

There are problems with this code.  Here is a summary of the issues.  I 
have included detailed results so you can track down the issues.

```
==
ERROR: test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
263, in test_02_vpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
309, in performVPCTests
vlan_1 = int(vlans[0])
TypeError: int() argument must be a string or a number, not 'tuple'
```

```
==
ERROR: test_03_vpc_privategw_restart_vpc_cleanup 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
275, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, True)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
309, in performVPCTests
vlan_1 = int(vlans[0])
TypeError: int() argument must be a string or a number, not 'tuple'
```

```
==
ERROR: test_04_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
287, in test_04_rvpc_privategw_static_routes
self.performVPCTests(vpc_off)
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
309, in performVPCTests
vlan_1 = int(vlans[0])
TypeError: int() argument must be a string or a number, not 'tuple'
```

Not sure if this is related to one of the other failures or not...
```
==
FAIL: Test Remote Access VPN in VPC
--
Traceback (most recent call last):
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 419, in test_01_vpc_remote_access_vpn
vpnUser, "Failed to create Remote Access VPN User")
AssertionError: Failed to create Remote Access VPN User
```


**Associated Uploads**


* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1455/results.txt)


Uploads will be available until `2016-06-04 00:00:00 + GMT`

*Comment created by [`upr comment`](https://github.com/swill/upr).*




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-204248348
  
@alexandrelimassantana , cleanup does not clean the db connection. So it 
should work for other tests as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[eriweb]

Github user eriweb commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-203855979
  
@remibergsma @wilderrodrigues @borisroman you guys have been testing a lot 
previously, would this change work for you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[shwetaag]

Github user shwetaag commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-203818359
  
Did Code walk through . LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[alexandrelimassantana]

Github user alexandrelimassantana commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-202874549
  
Does the _cleanup_resources(cls.api_client, cls._cleanup)_ cleans the db 
connection as well? I see that it is only 1 test as of now, but if there would 
be another, the setUp should also work correctly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1455#issuecomment-202342204
  
Made changes as per Shwetaag's comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[shwetaag]

Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1455#discussion_r57562054
  
--- Diff: test/integration/smoke/test_privategw_acl.py ---
@@ -287,6 +298,16 @@ def performVPCTests(self, vpc_off, 
restart_with_cleanup = False):
 if not physical_networks:
 self.fail("No Physical Networks found!")
 
+qresultset = self.dbclient.execute(
+"select vnet from op_dc_vnet_alloc where physical_network_id=\
+(select id from physical_network where uuid='%s' ) and taken 
is NULL;" % physical_networks[0].id
+)
+self.assertEqual(validateList(qresultset)[0],
+ PASS,
+ "Invalid sql query response"
+)
+#vlans = physical_networks[0].vlan.split('-')
+vlans = qresultset
 vlans = physical_networks[0].vlan.split('-')
--- End diff --

this split is not needed for getting correct vlan entry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9328]: Fix vlan issues from t...

[sanju1010]

GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/1455

[CLOUDSTACK-9328]: Fix vlan issues from test suite test_privategw_acl.py in 
BVT

Please refer to CLOUDSTACK-9328 for the details.

Test Results:
==
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok

--
Ran 1 test in 108.273s

OK


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack vlan

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1455


commit fe73673d115b948930adab77669b1ef9236add0a
Author: sanjeev 
Date:   2016-03-28T10:36:57Z

[CLOUDSTACK-9328]: Fix vlan issues from test suite test_privategw_acl.py
in BVT
Bug-Id: CLOUDSTACK-9328




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---