[GitHub] cloudstack pull request: More VR performance!

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-215079521
  
I am not seeing the issue on master.  It appears that your issue may be 
related to the Host(9) being unreachable.  I would validate the connectivity is 
all working as expected in your environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[prashanthvarma]

Github user prashanthvarma commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-215041061
  
@milamberspace @swill @remibergsma @DaanHoogland, I am seeing a similar 
issue on master: https://issues.apache.org/jira/browse/CLOUDSTACK-9370

I have couple of questions regarding this issue:
Does this PR supposed to fix this issue as well, and is anyone else seeing 
this issue on master ? 

Please excuse me, if this is not the correct platform for such questions. 
Let me know, where I can ask such questions.

Thank you !!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199521648
  
Sorry, my bad.  I have been disconnected for 3 days and my inbox has 
exploded and I am trying to work my way through everything and my brain is a 
bit fried.  Sorry for the spam everyone...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199519708
  
@swill Already merge to 4.8 (for next 4.8.1) and on master (4.9)
same commit id: 3eceb60f5ca8b86b3308243ae2905bbfbd54bc39



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199514658
  
Sorry, I missed that line in the comments.  :)  Thanks @ustcweizhou.  I 
will check and see if it has been forward merged.  It should be if it hasn't 
been, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199513826
  
@swill this PR has already been merged into 4.7 on 2016-01-23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199512959
  
I am happy with this PR.  I believe I should be merging into 4.7 and then 
forward merging into 4.8 and master.  I am sorry this is a bit off topic, but 
should we be running integration tests for each forward merge or is that not 
necessarily required?  I am still ramping up as the RM, so bare with me.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199448860
  
@DaanHoogland @remibergsma I don't want backport this fix, my (new) current 
installation of CS is under 4.8, but this RV bug is coming with the new python 
script since systemvm 4.6. That was just a note if another user have this issue 
(and too because I don't know the current support of CS versions)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199270791
  
@milamberspace No back porting please :-) Just upgrade to 4.7, it's a 
painless 10min job.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-199210638
  
@milamberspace I think we seriously need to consider if we are going to 
maintain 4.6 as in the beginning of 4.7 many bugs were fixed on master and 
later 4.7 instead of on 4.6, not just this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-198946677
  
FYI
This PR fixes the bug CLOUDSTACK-9255
https://issues.apache.org/jira/browse/CLOUDSTACK-9255

(perhaps need to backport this PR on 4.6 branch.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1356


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-173871762
  
I see no harm in these changes and as they are putting related code closer 
together it improves readability: LGTM
However I have a question: How is this improving performance? The title of 
the PR does not reflect what I see obviously.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-173863164
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```
Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok

[GitHub] cloudstack pull request: More VR performance!

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-173872641
  
@DaanHoogland It improves performance due to fact firewall rules are only 
created (in memory) once we expect a change. If for example a dhcp lease needs 
to be added, no firewall rules will be build or changed.

At first these were always executed:
```
-# Always run both CsAcl().process() methods
 -# They fill the base rules in config.fw[] 
 -acls = CsAcl('networkacl', config)
 -acls.process()
 -  
 -acls = CsAcl('firewallrules', config) 
 -acls.process()
 -  
 -fwd = CsForwardingRules("forwardingrules", config)
 -fwd.process() 
 -  
 -vpns = CsSite2SiteVpn("site2sitevpn", config) 
 -vpns.process()
 -  
 -rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)   
 -rvpn.process()
 -  
 -lb = CsLoadBalancer("loadbalancer", config)   
 -lb.process()
```

Now they are only executed if we expect change to the firewall rules.

Less execution == more performance!

Hope that clears up! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-173915308
  
@boris, thanks. moving code to to be executed only conditionally is a very 
good idea, this is even better then seemed at first glance :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1356#issuecomment-173902852
  
@remibergsma already tested and code LGTM :+1: 

We have this PR already running in out Beta environment, which is a copy of 
our production environment.

Please, proceed with merge.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: More VR performance!

[borisroman]

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/1356

More VR performance!



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack 4.7-vr-performance-wip

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1356


commit 3eceb60f5ca8b86b3308243ae2905bbfbd54bc39
Author: Boris Schrijver 
Date:   2016-01-20T12:34:09Z

More VR performance!




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---